At Wed, 27 Jul 2022 00:16:33 +0800, Zhang Mingli <zmlpostg...@gmail.com> wrote in > FORCE_NOT_NULL and FORCE_NULL are only used when COPY FROM. > > And copyto.c and copyfrom.c are split in this commit > https://github.com/postgres/postgres//commit/c532d15dddff14b01fe9ef1d465013cb8ef186df > > <https://github.com/postgres/postgres//commit/c532d15dddff14b01fe9ef1d465013cb8ef186df> > . > > There is no need to handle these options when COPY TO.
Agreed. ProcessCopyOptions previously rejects force_quote_all for COPY FROM and copyfrom.c is not even conscious of the option (that is, even no assertion on it). The two options are rejected for COPY TO by the same function so it seems like a thinko of the commit. Getting rid of the code would be good in the view of code coverage and maintenance. On the otherhand I wonder if it is good that we have assertions on the option values. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
