Hello, Tom.
>> This is a pretty broad claim to make on the basis of one undocumented
>> test case on one unmentioned platform.
> I'll try to use pg_stat_kcache to check the difference between Wall
> and CPU for my case.
In my case I see pretty high correlation of pg_stat_kcache and
pg_stat_state
Hi hackers,
I saw a problem in logical replication, when the target table on subscriber is a
partitioned table, it only checks whether the Replica Identity of partitioned
table is consistent with the publisher, and doesn't check Replica Identity of
the partition.
For example:
-- publisher --
crea
On 6/8/22 08:29, Jakub Wartak wrote:
The attached patch is a trivial version that waits until we're at
least
32 pages behind the target, and then prefetches all of them. Maybe give it
a
>> try?
(This pretty much disables prefetching for e_i_c below 32, but for an
expe
At Tue, 07 Jun 2022 16:05:47 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Tue, 07 Jun 2022 12:39:38 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > One possible way to detect promotion reliably is to look into timeline
> > history files. It is written immediately at promotion even on
> > standb
At Wed, 08 Jun 2022 18:15:09 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Tue, 07 Jun 2022 16:05:47 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > At Tue, 07 Jun 2022 12:39:38 +0900 (JST), Kyotaro Horiguchi
> > wrote in
> > > One possible way to detect promotion reliably is to look into tim
On Wed, Jun 8, 2022 at 2:51 PM Kyotaro Horiguchi
wrote:
> At Wed, 08 Jun 2022 07:05:09 +0200, Laurenz Albe
> wrote in
> > I take Tom's comment above as saying that the current behavior is fine.
> > So yes, perhaps some documentation would be in order:
> >
> > diff --git a/doc/src/sgml/postgres-f
On Fri, Jun 3, 2022 at 1:03 AM Zhihong Yu wrote:
> Suggestion on formatting the comment:
>
> + * node (or that for any plan node in the subplan tree), 2)
> + * set_plan_references() modifies the tlist for every plan node in the
>
> It would be more readable if `2)` is put at the beginning of the s
On Wed, Jun 8, 2022 at 12:23 PM Peter Geoghegan wrote:
> ISTM that there are two mostly-distinct questions here:
>
> 1. How do we link to multiple versions of ICU at the same time, in a
> way that is going to work smoothly on mainstream platforms?
>
> 2. What semantics around collations do we want
On Tue, Jun 7, 2022 at 3:53 PM Tom Lane wrote:
> No, I quite agree that we have a problem. What I don't agree is that
> issuing a lot of false-positive warnings is a solution. That will
> just condition people to ignore the warnings, and then when their
> platform really does change behavior, th
On Fri, Jun 3, 2022 at 3:37 PM vignesh C wrote:
>
> Thanks for the comments, the attached v8 patch has the changes for the same.
>
AFAICS, the summary of this proposal is that we want to support
exclude of certain objects from publication with two kinds of
variants. The first variant is to add su
On Tue, Jun 7, 2022 at 4:10 PM Tom Lane wrote:
> I mean by "false positive" is telling every macOS user that they'd better
> reindex everything every year, when in point of fact Apple changes those
> collations almost never.
Do we actually know that to be true? Given how fast things seem to be
ge
Since Postgres 9.5 it is possible to use the => operators for filling in
named parameters in a function call, like perform my_func(named_param =>
'some value'). The old form, with the := operator is still allowed for
backward reference.
But with open cursor, still only the old := operator is a
Attached is a patch the finishes up the work to move the snowball SQL
script generation into a separate script.From 02ca51dfb918666dfde8e48499a4c73afae4e89e Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 8 Jun 2022 11:05:31 +0200
Subject: [PATCH] fixup! meson: prereq: move snowball_
We currently can check for missing heap/index files by comparing
pg_class with the database directory files. However, I am not clear if
this is safe during concurrent DDL. I assume we create the file before
the update to pg_class is visible, but do we always delete the file
after the update to pg
Hello Tom,
On Wed, Jun 8, 2022 at 12:44 AM Tom Lane wrote:
>
> Kuntal Ghosh writes:
> > While exploring some code in logical replication worker
> > implementation, I noticed that we're accessing an invalid memory while
> > traversing LogicalRepCtx->workers[i].
> > For the above structure, we're
st 8. 6. 2022 v 14:29 odesílatel Martin Butter <
martin.but...@splendiddata.com> napsal:
> Since Postgres 9.5 it is possible to use the => operators for filling in
> named parameters in a function call, like perform my_func(named_param =>
> 'some value'). The old form, with the := operator is stil
Hi, got some answers!
TL;DR for fio it would make sense to use many stressfiles (instead of 1) and
same for numjobs ~ VCPU to avoid various pitfails.
> >> The really
> >> puzzling thing is why is the filesystem so much slower for smaller
> >> pages. I mean, why would writing 1K be 1/3 of writing
Robert Haas writes:
> On Tue, Jun 7, 2022 at 3:53 PM Tom Lane wrote:
>> No, I quite agree that we have a problem. What I don't agree is that
>> issuing a lot of false-positive warnings is a solution.
> I mean, how many false-positive warnings do you think we'll get?
The proposed patch would re
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
> On Mon, Jun 6, 2022 at 7:21 PM Stephen Frost wrote:
> > > To revoke a grant entirely, you just say REVOKE foo FROM bar, as now.
> > > To change an option for an existing grant, you can re-execute the
> > > grant statement with a different
I believe functions in Postgres follow a late binding approach and hence
nested function dependencies are resolved using search_path at run time.
This way a user can override nested functions in its schema and change the
behaviour of wrapper functions. However, a more serious issue is when
function
On 6/8/22 16:15, Jakub Wartak wrote:
> Hi, got some answers!
>
> TL;DR for fio it would make sense to use many stressfiles (instead of 1) and
> same for numjobs ~ VCPU to avoid various pitfails.
> The really
puzzling thing is why is the filesystem so much slower for smaller
pages.
On Wed, Jun 8, 2022 at 7:29 AM Virender Singla
wrote:
> but I still expect Postgres to save us from such data inconsistencies
> issues by using early binding for functional Indexes.
>
Well, if the functions you are writing are "black boxes" to PostgreSQL this
expectation seems unreasonable. As
On Wed, Jun 8, 2022 at 10:16 AM Stephen Frost wrote:
> > That's why I proposed the name SET, not MEMBERSHIP. You would still
> > get a catalog entry in pg_auth_members, so you are still a member in
> > some loose sense even if your grant has INHERIT FALSE and SET FALSE,
> > but in such a case the
On 6/7/22 10:57 PM, Tom Lane wrote:
"Jonathan S. Katz" writes:
I don't know how frequently issues around "max_stack_depth" being too
small are reported -- I'd be curious to know that -- but I don't have
any strong arguments against allowing the behavior you describe based on
our current docs.
"Jonathan S. Katz" writes:
> Interesting. OK, I'd say let's keep the behavior that's in the patch.
Pushed then.
regards, tom lane
Robert Haas writes:
> On Tue, Jun 7, 2022 at 4:10 PM Tom Lane wrote:
>> I mean by "false positive" is telling every macOS user that they'd better
>> reindex everything every year, when in point of fact Apple changes those
>> collations almost never.
> Do we actually know that to be true? Given h
On 6/8/22 1:26 PM, Tom Lane wrote:
"Jonathan S. Katz" writes:
Interesting. OK, I'd say let's keep the behavior that's in the patch.
Pushed then.
Excellent -- thank you!
Jonathan
OpenPGP_signature
Description: OpenPGP digital signature
Tom Lane wrote:
> Yeah, and it's exactly at the level of quirks that things are likely
> to change. Nobody's going to suddenly start sorting B before A.
> They might, say, change their minds about where the digram "cz"
> sorts relative to single letters, in languages where special rules
>
On Wed, Jun 8, 2022 at 10:51 AM Tom Lane wrote:
> Their POSIX collations seem to be legacy code that's entirely unrelated to
> any modern collation support; in particular the "UTF8" ones are that in
> name only. I'm sure that Apple are indeed updating the UTF8 data behind
> their proprietary i18n
Hello Devs,
I am investigating backporting the fixes for CVE-2022-1552 to 9.6 and
9.4 as part of Debian LTS and Extended LTS. I am aware that these
releases are no longer supported upstream, but I have made an attempt at
adapting commits ef792f7856dea2576dcd9cab92b2b05fe955696b and
f26d5702857a9c
"Daniel Verite" writes:
> Independently of these rules, all Unicode collations change frequently
> because each release of Unicode adds new characters. Any string
> that contains a code point that was previously unassigned is going
> to be sorted differently by all collations when that code point
Roberto =?iso-8859-1?Q?C=2E_S=E1nchez?= writes:
> I am investigating backporting the fixes for CVE-2022-1552 to 9.6 and
> 9.4 as part of Debian LTS and Extended LTS. I am aware that these
> releases are no longer supported upstream, but I have made an attempt at
> adapting commits ef792f7856dea25
On Wed, Jun 8, 2022 at 4:02 PM Tom Lane wrote:
> I'm very skeptical of this process as being a reason to push users
> to reindex everything in sight. If U+ was not a thing last year,
> there's no reason to expect that it appears in anyone's existing data,
> and therefore the fact that it sort
> On Jun 7, 2022, at 1:10 PM, Tom Lane wrote:
>
> This is not the concern that I have. I agree that if we tell a user
> that collation X changed behavior and he'd better reindex his indexes
> that use collation X, but none of them actually contain any cases that
> changed behavior, that's not
On Wed, Jun 08, 2022 at 10:55:29AM +0900, Michael Paquier wrote:
> And applied, to take care of this open item.
Shouldn't this wait for the buildfarm to be updated again ?
--
Justin
We have these two definitions in the source code:
#define BTMaxItemSize(page) \
MAXALIGN_DOWN((PageGetPageSize(page) - \
MAXALIGN(SizeOfPageHeaderData + \
3*sizeof(ItemIdData) + \
3*sizeof(ItemPointerData)) - \
On Wed, Jun 08, 2022 at 04:15:47PM -0400, Tom Lane wrote:
> Roberto =?iso-8859-1?Q?C=2E_S=E1nchez?= writes:
> > I am investigating backporting the fixes for CVE-2022-1552 to 9.6 and
> > 9.4 as part of Debian LTS and Extended LTS. I am aware that these
> > releases are no longer supported upstream
Recently I had someone complaining about a pg_restore failure and I
believe we semi-regularly get complaints that are similar -- though
I'm having trouble searching for them because the keywords "dump
restore failure" are pretty generic.
The root cause here -- and I believe for a lot of users -- a
On Wed, Jun 8, 2022 at 2:23 PM Robert Haas wrote:
> In my tests, PageGetPageSize(page) = 8192, SizeOfPageHeaderData = 24,
> sizeof(ItemIdData) = 4, sizeof(ItemPointerData) = 6, and
> sizeof(BTPageOpaqueData) = 16. Assuming MAXIMUM_ALIGNOF == 8, I
> believe that makes BTMaxItemSize come out to 2704
On Wed, Jun 8, 2022 at 5:55 PM Peter Geoghegan wrote:
> > That's a problem, because if in that scenario you allow three 2704
> > byte items that don't need a heap TID and later you find you need to
> > add a heap TID to one of those items, the result will be bigger than
> > 2704 bytes, and then yo
Hi hackers,
Recently when looking at the "System Catalogs" Tables of Contents [1],
I was wondering why are those headings "Overview" and "System Views"
at the same section level as the catalogs/views within them.
~~~
e.g.1. Current:
Chapter 53. "System Catalogs"
==
53.1. Overview
53.2. pg_a
On Thu, Jun 9, 2022 at 5:42 AM Tom Lane wrote:
> I'm sure that Apple are indeed updating the UTF8 data behind
> their proprietary i18n APIs, but the libc APIs are mostly getting benign
> neglect.
As for how exactly they might be doing that, I don't know, but a bit
of light googling tells me that
> On Jun 8, 2022, at 2:42 PM, Greg Stark wrote:
>
> Thinking of plpgsql here, we already run the raw parser on all sql
> when the function is defined. We could somehow check whether the
> raw_parser found any non-schema-qualified references. This looks like
> it would be awkward but doable. Th
New emoji are getting added with some frequency, it’s a thing lately…
New Unicode chars use existing but unassigned code points. All code points are
able to be encoded, claimed or unclaimed.
Someone on old glibc or ICU can still store the new characters. As long as
there’s an input field. You w
Hi hackers,
(Resending because my previous post was missing the subject - sorry for noise)
Recently when looking at the "System Catalogs" Tables of Contents [1],
I was wondering why are those headings "Overview" and "System Views"
at the same section level as the catalogs/views within them.
~~~
On Wed, Jun 8, 2022 at 4:18 PM Robert Haas wrote:
> I wasn't originally setting out to modify BTPageOpaqueData at all,
> just borrow some special space. See the "storing an explicit nonce"
> discussion and patch set. But when this regression failure turned up I
> said to myself, hmm, I think this
On Tue, Jun 7, 2022 at 5:45 PM Robert Haas wrote:
> Perhaps that is
> ill-founded, but I don't think "should be serialized" is necessarily
> something that everybody is going to have the same view on, or even
> know what it means.
Using this thread as an example, once it was decided that the para
Peter Smith writes:
> e.g.2 What I thought it should look like:
> Chapter 53. "System Catalogs and Views" <-- chapter name change
> ==
> 53.1. System Catalogs <-- heading name change
> 53.1.1. pg_aggregate
> 53.1.2. pg_am
> 53.1.3. pg_amop
> 53.1.4. pg_amproc
Then the catalog descriptions w
On Thu, Jun 9, 2022 at 10:00 AM Tom Lane wrote:
>
> Peter Smith writes:
> > e.g.2 What I thought it should look like:
>
> > Chapter 53. "System Catalogs and Views" <-- chapter name change
> > ==
> > 53.1. System Catalogs <-- heading name change
> > 53.1.1. pg_aggregate
> > 53.1.2. pg_am
> >
On Wed, 2022-06-08 at 19:06 +0900, Etsuro Fujita wrote:
> On Wed, Jun 8, 2022 at 2:51 PM Kyotaro Horiguchi
> wrote:
> > At Wed, 08 Jun 2022 07:05:09 +0200, Laurenz Albe
> > wrote in
> > > diff --git a/doc/src/sgml/postgres-fdw.sgml
> > > b/doc/src/sgml/postgres-fdw.sgml
> > > index b43d0aecba.
On Wed, Jun 08, 2022 at 04:13:37PM -0500, Justin Pryzby wrote:
> On Wed, Jun 08, 2022 at 10:55:29AM +0900, Michael Paquier wrote:
>> And applied, to take care of this open item.
>
> Shouldn't this wait for the buildfarm to be updated again ?
The TAP logic is able to find any logs by itself on fai
Hi,
Due to the issue with potential data corruption when running `CREATE
INDEX CONCURRENTLY` / `REINDEX CONCURRENTLY` on PostgreSQL 14[1], the
release team has decided to make an out-of-cycle release available for
PostgreSQL 14 on June 16, 2022.
This release will be numbered 14.4. This relea
On Tue, Jun 07, 2022 at 12:18:52PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Point, fixed in the attached v2. I've also added a test that truncation
> and disabling works.
The tests are structured so as all the queries are run first, then the
full set of logs is slurped and scanned. With things li
On Wed, May 18, 2022 at 09:55:07AM +0900, Michael Paquier wrote:
> On Tue, May 17, 2022 at 04:58:11PM +0900, Michael Paquier wrote:
>> Adding Robert in CC, as this has been added with bd807be. I have
>> added an open item for now.
>
> With the individual in CC, that's even better.
Three weeks la
On Mon, May 16, 2022 at 1:28 AM Peter Eisentraut
wrote:
> Inspired by [0], I looked to convert more macros to inline functions.
> The attached patches are organized "bottom up" in terms of their API
> layering; some of the later ones depend on some of the earlier ones.
Big +1 from me.
I converte
On Mon, May 30, 2022 at 03:59:52PM +0900, Michael Paquier wrote:
> Okay, I am outnumbered, and that would mean bumping MIN_WINNT to
> 0x0A00. So, ready to move to this version at full speed for 16? We
> still have a couple of weeks ahead before the next dev cycle begins,
> so feel free to comment
Hi,
Currently CREATE_REPLICATION_SLOT/pg_create_logical_replication_slot waits
unboundedly if there are any in-progress write transactions [1]. The wait
is for a reason actually i.e. for building an initial snapshot, but waiting
unboundedly isn't good for usability of the command/function and when
On Thu, Jun 9, 2022 at 3:55 PM Michael Paquier wrote:
> On Mon, May 30, 2022 at 03:59:52PM +0900, Michael Paquier wrote:
> > Okay, I am outnumbered, and that would mean bumping MIN_WINNT to
> > 0x0A00. So, ready to move to this version at full speed for 16? We
> > still have a couple of weeks ah
On Tue, Jun 07, 2022 at 02:22:28PM -0700, Jacob Champion wrote:
> v2 rebases over latest, removes the alternate spellings of "password",
> and implements OR operations with a comma-separated list. For example:
>
> - require_auth=cert means that the server must ask for, and the client
> must provid
> On Jun 8, 2022, at 03:19, Thomas Munro wrote:
>
> On Wed, Jun 8, 2022 at 12:23 PM Peter Geoghegan wrote:
>> ISTM that there are two mostly-distinct questions here:
>>
>> 1. How do we link to multiple versions of ICU at the same time, in a
>> way that is going to work smoothly on mainstream
Hi,
Currently postgres doesn't allow dropping a replication slot that's active
[1]. This can make certain operations more time-consuming or stuck in
production environments. These operations are - disable async/sync standbys
and disable logical replication that require the postgres running on
stan
On Wed, Jun 8, 2022 at 10:24 PM Jeremy Schneider
wrote:
> Even if PG supports two versions of ICU, how does someone actually go about
> removing every dependency on the old version and replacing it with the new?
They simply REINDEX, without changing anything. The details are still
fuzzy, but at
On Thu, Jun 09, 2022 at 04:55:45PM +1200, Thomas Munro wrote:
> The Cygwin stuff in installation.sgml also mentions NT, 2000, XP, but
> it's not clear from the phrasing if it meant "and later" or "and
> earlier", so I'm not sure if it needs adjusting or removing...
Right. We could just remove the
Bharath Rupireddy writes:
> How about we provide a function to force-drop a replication slot?
Isn't this akin to filing off the safety interlock on the loaded revolver
you keep in your hip pocket? IMO the entire point of replication slots
is to not make it easy to lose data.
On Wed, Jun 8, 2022 at 10:39 PM Peter Geoghegan wrote:
> They simply REINDEX, without changing anything. The details are still
> fuzzy, but at least that's what I was thinking of.
As I said before, BCP47 format tags are incredibly forgiving by
design. So it should be reasonable to assume that any
On Thu, Jun 9, 2022 at 11:07 AM Bharath Rupireddy
wrote:
>
> Currently postgres doesn't allow dropping a replication slot that's active
> [1]. This can make certain operations more time-consuming or stuck in
> production environments. These operations are - disable async/sync standbys
> and dis
66 matches
Mail list logo
