Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.

2021-10-07 Thread Daniel Gustafsson
> On 7 Oct 2021, at 23:48, Tom Lane wrote: > Concretely, then, I propose the attached. LGTM. Good idea to change the section heading, Portability is a better title for this. -- Daniel Gustafsson https://vmware.com/

Time to upgrade buildfarm coverage for some EOL'd OSes?

2021-10-07 Thread Thomas Munro
Hi, I noticed that for NetBSD we only have one animal, and it's running EOL'd release 7. To give decent visibility of relevant portability problems it'd be nice to have one of the current supported releases[1] in there. CC'ing owner; any interest in updating this animal to 9.x? For FreeBSD the

Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.

2021-10-07 Thread Alvaro Herrera
On 2021-Oct-07, Tom Lane wrote: > +Portability > +--- > + > +Avoid using any bleeding-edge Perl features. We have buildfarm animals > +running Perl versions as old as 5.8.3, so your tests will be expected > +to pass on that. > + > +Also, do not use any non-core Perl modules except IPC::Ru

Re: Time to upgrade buildfarm coverage for some EOL'd OSes?

2021-10-07 Thread Tom Lane
Thomas Munro writes: > (Hmm, in hindsight, I don't know why we need "--with-bsd-auth" instead > of detecting it, but I don't plan to work on that...) As far as that goes, I thought we had a policy against auto-detecting user-visible features. From memory, the rationale goes like "if you want fea

Re: extended stats on partitioned tables

2021-10-07 Thread Justin Pryzby
On Thu, Oct 07, 2021 at 03:26:46PM -0500, Jaime Casanova wrote: > On Sun, Sep 26, 2021 at 03:25:50PM -0500, Justin Pryzby wrote: > > On Sat, Sep 25, 2021 at 05:31:52PM -0500, Justin Pryzby wrote: > > > It seems like your patch should also check "inh" in examine_variable and > > > statext_expression

Re: Map WAL segment files on PMEM as WAL buffers

2021-10-07 Thread Matthias van de Meent
On Wed, 30 Jun 2021 at 06:53, Takashi Menjo wrote: > > Rebased. Thanks for these patches! I recently took a dive into the WAL subsystem, and got to this patchset through the previous ones linked from [0]. This patchset seems straightforward to understand, so thanks! I've looked over the patches

Re: Time to upgrade buildfarm coverage for some EOL'd OSes?

2021-10-07 Thread Thomas Munro
On Fri, Oct 8, 2021 at 11:40 AM Tom Lane wrote: > Thomas Munro writes: > > (Hmm, in hindsight, I don't know why we need "--with-bsd-auth" instead > > of detecting it, but I don't plan to work on that...) > > As far as that goes, I thought we had a policy against auto-detecting > user-visible feat

Re: Question about client_connection_check_interval

2021-10-07 Thread Kyotaro Horiguchi
Hello. At Thu, 7 Oct 2021 03:07:33 +, "kuroda.hay...@fujitsu.com" wrote in > Dear Hackers, > > While reading source codes about timeouts and GUC and I found that > strange behavior about client_connection_check_interval. > > Currently we did not an assign_hook about client_connection_chec

Re: Question about client_connection_check_interval

2021-10-07 Thread Kyotaro Horiguchi
At Fri, 08 Oct 2021 09:56:32 +0900 (JST), Kyotaro Horiguchi wrote in > Hello. > > At Thu, 7 Oct 2021 03:07:33 +, "kuroda.hay...@fujitsu.com" > wrote in > > Dear Hackers, > > > > While reading source codes about timeouts and GUC and I found that > > strange behavior about client_connecti

Re: Role Self-Administration

2021-10-07 Thread Stephen Frost
Greetings, * Mark Dilger (mark.dil...@enterprisedb.com) wrote: > > On Oct 7, 2021, at 12:31 PM, Mark Dilger > > wrote: > > > > Let me see if I can find that again. > > 12.6 > > ::= > DROP ROLE > > Syntax Rules > 1) Let R be the role identified by the specified . > > General Rules > 1) Le

Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.

2021-10-07 Thread Noah Misch
On Thu, Oct 07, 2021 at 03:44:48PM -0400, Tom Lane wrote: > [ cc'ing Craig and Noah, as author/committer of the existing text ] > > Daniel Gustafsson writes: > > On 7 Oct 2021, at 21:02, Tom Lane wrote: > >> BTW, looking at that a second time, I wonder if that advice is > >> really of any use. >

Re: Lost logs with csvlog redirected to stderr under WIN32 service

2021-10-07 Thread Michael Paquier
On Thu, Oct 07, 2021 at 01:26:46PM +0900, Michael Paquier wrote: > On Wed, Oct 06, 2021 at 09:33:24PM -0500, Chris Bandy wrote: >>> + /* Write to CSV log, if enabled */ >>> + if ((Log_destination & LOG_DESTINATION_CSVLOG) != 0) >> >> This was originally "if (Log_destination & LOG_DESTINATION_C

Re: storing an explicit nonce

2021-10-07 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Oct 7, 2021 at 3:38 PM Stephen Frost wrote: > > While I certainly also appreciate that we want to get this as right as > > we possibly can from the start, I strongly suspect we'll have one of two > > reactions- either we'll be more

RE: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns

2021-10-07 Thread osumi.takami...@fujitsu.com
On Thursday, October 7, 2021 1:20 PM Masahiko Sawada wrote: > Regarding the patch details, I have two comments: > > --- > + if ((parsed->xinfo & XACT_XINFO_HAS_INVALS) && last_running) { > + /* make last_running->xids bsearch()able */ > + qsort(last_running->xids, > + last_r

Re: Add jsonlog log_destination for JSON server logs

2021-10-07 Thread Michael Paquier
On Tue, Oct 05, 2021 at 04:18:17PM +0900, Michael Paquier wrote: > 0002 and 0004 could be more polished and most of their pieces had > better be squashed together. 0003, though, would improve the case of > WIN32 where only csvlog is enabled so as log entries are properly > redirected to the event

Re: pg_dump does not dump tables created in information_schema schema

2021-10-07 Thread vignesh C
On Thu, Oct 7, 2021 at 9:30 PM Tom Lane wrote: > > "David G. Johnston" writes: > > On Thursday, October 7, 2021, vignesh C wrote: > >> Should tables be allowed to create in "information_schema" schema, if > >> yes should the tables/publications be dumped while dumping database > >> contents? > >

Re: storing an explicit nonce

2021-10-07 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Oct 7, 2021 at 12:57 PM Stephen Frost wrote: > > Yes, for integrity verification (also known as 'authenticated > > encryption') we'd definitely need to store a larger nonce value. In the > > very, very long term, I think it'd be g

Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.

2021-10-07 Thread Tom Lane
Noah Misch writes: > On Thu, Oct 07, 2021 at 03:44:48PM -0400, Tom Lane wrote: >>> (1) I'm distrustful of the idea that perl 5.8.x will compile >>> cleanly, or at all, on modern platforms. Certainly Postgres >>> releases of similar vintage won't. > perlbrew uses the patchperl system to build old

Re: Add client connection check during the execution of the query

2021-10-07 Thread Thomas Munro
On Sat, Jun 12, 2021 at 8:31 PM Zhihong Yu wrote: > +#ifdef POLLRDHUP > + if ((cur_event->events & WL_SOCKET_CLOSED) && > + (cur_pollfd->revents & (POLLRDHUP | errflags))) > > It seems the last condition above should be written as: > > ((cur_pollfd->revents & POLLRDHUP) | (

Re: [BUG] Unexpected action when publishing partition tables

2021-10-07 Thread Amit Kapila
On Thu, Oct 7, 2021 at 12:39 PM Amit Langote wrote: > > On Fri, Sep 17, 2021 at 7:38 PM Amit Kapila wrote: > > On Fri, Sep 17, 2021 at 11:36 AM houzj.f...@fujitsu.com > > wrote: > > > On Thursday, September 16, 2021 6:05 PM Amit Kapila > > > > > > > > On Tuesday, September 14, 2021 10:41 PM vi

Re: Add client connection check during the execution of the query

2021-10-07 Thread Zhihong Yu
On Thu, Oct 7, 2021 at 8:43 PM Thomas Munro wrote: > On Sat, Jun 12, 2021 at 8:31 PM Zhihong Yu wrote: > > +#ifdef POLLRDHUP > > + if ((cur_event->events & WL_SOCKET_CLOSED) && > > + (cur_pollfd->revents & (POLLRDHUP | errflags))) > > > > It seems the last condition above

Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.

2021-10-07 Thread Noah Misch
On Thu, Oct 07, 2021 at 11:39:11PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Thu, Oct 07, 2021 at 03:44:48PM -0400, Tom Lane wrote: > >>> (1) I'm distrustful of the idea that perl 5.8.x will compile > >>> cleanly, or at all, on modern platforms. Certainly Postgres > >>> releases of simil

GIN pending list cleanup during autoanalyze blocks cleanup by VACUUM

2021-10-07 Thread Peter Geoghegan
We generally only expect amvacuumcleanup() routines to be called during VACUUM. But some ginvacuumcleanup() calls are an exception to that general rule -- these are calls made during autoanalyze, where ginvacuumcleanup() does real pending list cleanup work (not just a no-op return). That'll only ha

Re: libpq compression

2021-10-07 Thread Daniil Zakhlystov
Hi, thanks for your fix! I am currently working on implementing the lz4 support for libpq compression. Looking forward to post an update soon.—Daniil ZakhlystovOn 2 Oct 2021, at 02:20, Daniel Gustafsson wrote:On 2 Sep 2021, at 00:29, Daniel Gustafsson wrote:On 29 Jul 2021, at 16:57, Daniil Zakhly

Re: storing an explicit nonce

2021-10-07 Thread Antonin Houska
Stephen Frost wrote: > Greetings, > > * Robert Haas (robertmh...@gmail.com) wrote: > > On Thu, Oct 7, 2021 at 3:38 PM Stephen Frost wrote: > > > While I certainly also appreciate that we want to get this as right as > > > we possibly can from the start, I strongly suspect we'll have one of two

<    1   2