On Thu, Oct 7, 2021 at 8:43 PM Thomas Munro <thomas.mu...@gmail.com> wrote:
> On Sat, Jun 12, 2021 at 8:31 PM Zhihong Yu <z...@yugabyte.com> wrote: > > +#ifdef POLLRDHUP > > + if ((cur_event->events & WL_SOCKET_CLOSED) && > > + (cur_pollfd->revents & (POLLRDHUP | errflags))) > > > > It seems the last condition above should be written as: > > > > ((cur_pollfd->revents & POLLRDHUP) | (cur_pollfd->revents & errflags)) > > Hi Zhihong, > > Why? Isn't (A & B) | (A & C) is the same as A & (B | C)? > Hi, My former comment was about 4 months old. The current way as expressed in the patch should be fine. Cheers
