Re: pg_upgrade does not upgrade pg_stat_statements properly

2021-07-29 Thread Julien Rouhaud
On Thu, Jul 29, 2021 at 02:14:56PM -0400, Jan Wieck wrote: > > I presume that pg_upgrade on a database with that extension installed would > silently succeed and have the pg_catalog as well as public (or wherever) > version of that function present. I'll have to run a pg_upgrade with it to be 100

Re: Reduce the number of special cases to build contrib modules on windows

2021-07-29 Thread David Rowley
On Thu, 29 Jul 2021 at 00:05, David Rowley wrote: > I pushed the v9 0001 and 0005 patch after adjusting the AddFile($self, > ...) to become $self->AddFile(...) I pushed all the patches, apart from the 0004 patch. One weird thing I noticed with the -D define patch (245de4845) and the LOWER_NODE a

RE: [postgres_fdw] add local pid to fallback_application_name

2021-07-29 Thread kuroda.hay...@fujitsu.com
Dear Tom, Thank you for replying! > I don't think this is a great idea as-is. People who need to do this > sort of thing will all have their own ideas of what they need to track > --- most obviously, it might be appropriate to include the originating > server's name, else you don't know what mac

Re: Skipping logical replication transactions on subscriber side

2021-07-29 Thread Amit Kapila
On Thu, Jul 29, 2021 at 11:18 AM Masahiko Sawada wrote: > > On Thu, Jul 29, 2021 at 2:04 PM Masahiko Sawada wrote: > > > > > Yeah, it seems to be introduced by commit 0926e96c493. I've attached > > > the patch for that. > > > > > > Also, I've attached the updated version patches. This version pat

Re: [HACKERS] logical decoding of two-phase transactions

2021-07-29 Thread Peter Smith
Please find attached the latest patch set v100* v99-0002 --> v100-0001 Differences: * Rebased to HEAD @ today (needed because some recent commits [1][2] broke v99) * Addresses v99 review comments from Amit [1]. [1] https://github.com/postgres/postgres/commit/201a76183e2056c2217129e12d68c

Re: [HACKERS] logical decoding of two-phase transactions

2021-07-29 Thread Peter Smith
On Thu, Jul 29, 2021 at 9:56 PM Amit Kapila wrote: > > On Tue, Jul 27, 2021 at 11:41 AM Peter Smith wrote: > > > > Please find attached the latest patch set v99* > > > > v98-0001 --> split into v99-0001 + v99-0002 > > > > Pushed the first refactoring patch after making few modifications as below.

Re: [BUG]Update Toast data failure in logical replication

2021-07-29 Thread Amit Kapila
On Mon, Jul 26, 2021 at 10:45 AM Dilip Kumar wrote: > > I was thinking more about this idea, but IMHO, unless we send the key > toasted tuple from the publisher how is the subscriber supposed to > fetch it. Because that is the key value for finding the tuple on the > subscriber side and if we hav

Re: when the startup process doesn't (logging startup delays)

2021-07-29 Thread Nitin Jadhav
> Thanks. Can you please have a look at what I suggested down toward the > bottom of > http://postgr.es/m/ca+tgmoap2wefsktmcgwt9lxuz7y99hnduyshpk7qnfuqb98...@mail.gmail.com > ? > > If we're going to go the route of combining the functions, I agree > that a Boolean is the way to go; I think we have

Re: [HACKERS] logical decoding of two-phase transactions

2021-07-29 Thread vignesh C
On Fri, Jul 30, 2021 at 9:32 AM Peter Smith wrote: > > Please find attached the latest patch set v100* > > v99-0002 --> v100-0001 > > Differences: > > * Rebased to HEAD @ today (needed because some recent commits [1][2] broke > v99) > The patch applies neatly, tests passes and documentation look

Re: Fix around conn_duration in pgbench

2021-07-29 Thread Yugo NAGATA
Hello Fujii-san, On Fri, 30 Jul 2021 02:01:08 +0900 Fujii Masao wrote: > > > On 2021/07/29 2:23, Fujii Masao wrote: > > > > > > On 2021/07/28 16:15, Yugo NAGATA wrote: > >>> I found another disconnect_all(). > >>> > >>> /* XXX should this be connection time? */ > >>> disconnect_all(s

Parallel Inserts (WAS: [bug?] Missed parallel safety checks..)

2021-07-29 Thread Amit Kapila
Note: Changing the subject as I felt the topic has diverted from the original reported case and also it might help others to pay attention. On Wed, Jul 28, 2021 at 8:22 AM houzj.f...@fujitsu.com wrote: > > > > Consider below ways to allow the user to specify the parallel-safety option: > > > > (a

Re: Fix around conn_duration in pgbench

2021-07-29 Thread Fujii Masao
On 2021/07/30 14:43, Yugo NAGATA wrote: This patch fixes three issues of connection time measurement: 1. The initial connection time is measured and stored into conn_duration but the result is never used. 2. The disconnection time are not measured even when -C is specified. 3. The disconn

Re: [HACKERS] logical decoding of two-phase transactions

2021-07-29 Thread Greg Nancarrow
On Fri, Jul 30, 2021 at 2:02 PM Peter Smith wrote: > > Please find attached the latest patch set v100* > > v99-0002 --> v100-0001 > A few minor comments: (1) doc/src/sgml/protocol.sgml In the following description, is the word "large" really needed? Also "the message ... for a ... message" soun

Use generation context to speed up tuplesorts

2021-07-29 Thread David Rowley
Hackers, While reviewing and benchmarking 91e9e89dc (Make nodeSort.c use Datum sorts for single column sorts), I noticed that we use a separate memory context to store tuple data and we just reset when we're done if the sort fits in memory, or we dump the tuples to disk in the same order they're a

RE: Added schema level support for publication.

2021-07-29 Thread houzj.f...@fujitsu.com
On July 28, 2021 6:44 PM vignesh C wrote: > Thanks for the patch, I have merged the changes. Attached v16 patch has the > fixes for the same. Thanks for the new version patches. Here are a few comments: 1) + /* Identify which schemas should be dropped */ + foreach(oldlc, oldschemaid

RE: Skipping logical replication transactions on subscriber side

2021-07-29 Thread houzj.f...@fujitsu.com
On July 29, 2021 1:48 PM Masahiko Sawada wrote: > > Sorry I've attached wrong ones. Reattached the correct version patches. Hi, I had some comments on the new version patches. 1) - relstate = (SubscriptionRelState *) palloc(sizeof(SubscriptionRelState)); - relstate->relid = subre

Re: Parallel Inserts (WAS: [bug?] Missed parallel safety checks..)

2021-07-29 Thread Greg Nancarrow
On Fri, Jul 30, 2021 at 4:02 PM Amit Kapila wrote: > > > Besides, I think we need a new default value about parallel dml safety. > > Maybe > > 'auto' or 'null'(different from safe/restricted/unsafe). Because, user is > > likely to alter the safety to the default value to get the automatic safety

<    1   2