On Mon, 21 Jun 2021 at 01:56, David Rowley wrote:
> # A new hashtable implementation
> Also, it would be good to hear what people think about solving the
> problem this way.
Because over on [1] I'm also trying to improve the performance of
smgropen(), I posted the patch for the new hash table ov
Sorry I have sent a duplicate email. I will first continue discussion
in the other thread and then submit it after we have a conclusion.
Thanks.
Peifeng
>As you note, this'd have to be restricted to superusers, which makes it
>seem like a pretty bad idea. We really don't want to be in a situation
>of pushing people to run day-to-day stuff as superuser. Yeah, having
>access to kerberos auth sounds good on the surface, but it seems like
>it would b
On 12/07/2021 02:34, Ranier Vilela wrote:
If it is not possible, know the upper limits, before the loop.
It is necessary to do this inside the loop.
@@ -49,10 +47,14 @@ _bt_restore_page(Page page, char *from, int len)
* To get the items back in the original order, we add them to the p
On Tue, Jul 06, 2021 at 05:07:04PM +0530, Bharath Rupireddy wrote:
> Thanks. Anyways, I removed WL_LATCH_SET for PreAuthDelay as
> well. PSA v4 patch.
For the moment, please note that I have marked the patch as committed
in the CF app. It may be better to start a new thread with the
remaining bit
Hi Peter,
Hi, I was wondering if/when a subset of cols is specified then does
> that mean it will be possible for the table to be replicated to a
> *smaller* table at the subscriber side?
>
e.g Can a table with 7 cols replicated to a table with 2 cols?
>
> table tab1(a,b,c,d,e,f,g) --> CREATE PUBL
On Mon, 12 Jul 2021 at 16:48, Greg Nancarrow wrote:
>
> On Mon, Jul 12, 2021 at 2:26 PM David Rowley wrote:
> >
> > > It seems strange to add a comment to explain why it's there. If we're
> > > going to the trouble of doing that, then we should just remove it and
> > > add a very small comment to
On Fri, Jul 9, 2021 at 12:12 PM Greg Nancarrow wrote:
>
> On Fri, Jul 9, 2021 at 1:28 PM houzj.f...@fujitsu.com
> wrote:
> >
> > Currently, postgres caches publication actions info in the
> > RelationData::rd_pubactions, but after applying the patch, it seems
> > rd_pubactions is not initialized
On 7/12/21 6:46 AM, Amit Kapila wrote:
On Mon, Jul 12, 2021 at 7:19 AM Alvaro Herrera wrote:
Hi
Andres complained about the safety of doing general expression
evaluation in pgoutput; that was first in
https://postgr.es/m/20210128022032.eq2qqc6zxkqn5...@alap3.anarazel.de
where he described
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 07:56, Michael Paquier
wrote:
> On Mon, Jul 12, 2021 at 11:10:24AM +0530, Dilip Kumar wrote:
>
> > On Thu, Jul 8, 2021 at 7:48 PM gkokola...@pm.me wrote:
> >
> > > We can, though I am not in favour of doing so. There is seemingly
On Thu, Jul 8, 2021 at 9:16 AM houzj.f...@fujitsu.com
wrote:
>
> On Wednesday, June 30, 2021 7:43 PM vignesh C wrote:
> > Thanks for reporting this issue, the attached v9 patch fixes this issue.
> > This also fixes the other issue you reported at [1].
>
> Hi,
>
> I had a look at the patch, pleas
On Mon, Jul 12, 2021 at 5:43 AM Peifeng Qiu wrote:
>
> >As you note, this'd have to be restricted to superusers, which makes it
> >seem like a pretty bad idea. We really don't want to be in a situation
> >of pushing people to run day-to-day stuff as superuser. Yeah, having
> >access to kerberos
On Mon, Jul 12, 2021 at 1:09 AM Euler Taveira wrote:
>
> I did another measure using as baseline the previous patch (v16).
>
> without cache (v16)
> ---
>
> mean: 1.46 us
> stddev: 2.13 us
> median: 1.39 us
> min-max:[0.69 .. 1456.69] us
>
On Fri, Jul 2, 2021 at 10:18 AM tanghy.f...@fujitsu.com
wrote:
>
> On Wednesday, June 30, 2021 7:43 PM vignesh C wrote:
> >
> > Thanks for reporting this issue, the attached v9 patch fixes this issue.
> > This also fixes the other issue you reported at [1].
>
> A comment on v9:
>
> src/bin/psql/
Hi Alvaro,
Thank you for comments.
The patch adds a function get_att_num_by_name; but we have a lsyscache.c
> function for that purpose, get_attnum. Maybe that one should be used
> instead?
>
> Thank you for pointing that out, I agree it makes sense to reuse the
existing function.
Changed it acc
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 08:42, Michael Paquier
wrote:
> On Fri, Jul 09, 2021 at 11:26:58AM +, Georgios wrote:
>
> > As suggested on a different thread [1], pg_receivewal can increase it's test
> >
> > coverage. There exists a non trivial amount of c
On Mon, Jul 12, 2021 at 11:33 AM wrote:
>
>
>
> ‐‐‐ Original Message ‐‐‐
>
> On Monday, July 12th, 2021 at 07:56, Michael Paquier
> wrote:
>
> > On Mon, Jul 12, 2021 at 11:10:24AM +0530, Dilip Kumar wrote:
> >
> > > On Thu, Jul 8, 2021 at 7:48 PM gkokola...@pm.me wrote:
> > >
> > > > We
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 11:42, wrote:
> ‐‐‐ Original Message ‐‐‐
>
> On Monday, July 12th, 2021 at 08:42, Michael Paquier mich...@paquier.xyz
> wrote:
>
> > On Fri, Jul 09, 2021 at 11:26:58AM +, Georgios wrote:
> >
> > > As suggested on a di
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 11:56, wrote:
> ‐‐‐ Original Message ‐‐‐
>
> On Monday, July 12th, 2021 at 11:42, gkokola...@pm.me wrote:
>
> > ‐‐‐ Original Message ‐‐‐
> >
> > On Monday, July 12th, 2021 at 08:42, Michael Paquier mich...@paquier.x
On Mon, Jul 12, 2021 at 3:15 PM Magnus Hagander wrote:
>
> On Mon, Jul 12, 2021 at 11:33 AM wrote:
> >
> >
> >
> > ‐‐‐ Original Message ‐‐‐
> >
> > On Monday, July 12th, 2021 at 07:56, Michael Paquier
> > wrote:
> >
> > > On Mon, Jul 12, 2021 at 11:10:24AM +0530, Dilip Kumar wrote:
> >
Le 12/07/2021 à 12:27, gkokola...@pm.me a écrit :
Shouldn't this be coded as a loop going through @gzip_wals?
>>> I would hope that there is only one gz file created. There is a line
>>>
>>> further up that tests exactly that.
>>>
>>> - is (scalar(@gzip_wals), 1, "one gzip compressed WA
On Mon, Jul 12, 2021 at 09:42:32AM +, gkokola...@pm.me wrote:
> This to my understanding means that gzip is expected to exist.
> If this is correct, then simply checking for the headers should
> suffice, since that is the only dependency for the files to be
> created.
You cannot expect this to
Hi,
thanks for the review and corrections.
On 11.07.2021 21:54, Soumyadeep Chakraborty wrote:
Hello,
This should have been added with [1].
Excerpt from the documentation:
"pg_stats is also designed to present the information in a more readable
format than the underlying catalog — at the cost
Hi,While I’m reading source codes related to vacuum, I found comments whichdon’t seem to fit the reality. I think the commit[1] just forgot to fix them.What do you think?[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=dc7420c2c9274a283779ec19718d2d16323640c0
Regards,-- Masahiro I
>But in this case, what dose Kerberos give over just using a password
>based solution? It adds complexity, but what's teh actual gain?
That's due to policy of some customers. They require all login to be kerberos
based and password-less. I suppose this way they don't need to maintain
passwords in
While looking into one of the pg_upgrade issue, I found it
challenging to find out the database that has the datallowconn set to
'false' that was throwing following error:
*"All non-template0 databases must allow connections, i.e. their
pg_database.datallowconn must be true"*
edb=# create dat
While looking at the other logrep patch [1] (column filtering) I noticed
Alvaro's comment regarding a new parsenode (PublicationTable) not having
read/out/equal/copy funcs. I'd bet the same thing applies here, so
perhaps see if the patch needs the same fix.
[1]
https://www.postgresql.org/message-i
On Mon, Jul 12, 2021 at 11:13 AM Masahiko Sawada wrote:
>
> On Mon, Jul 12, 2021 at 1:15 PM Amit Kapila wrote:
> >
> > On Mon, Jul 12, 2021 at 9:37 AM Alexey Lesovsky wrote:
> > >
> > > On Mon, Jul 12, 2021 at 8:36 AM Amit Kapila
> > > wrote:
> > >>
> > >> >
> > >> > Ok, looks nice. But I am c
On Mon, Jul 12, 2021 at 8:39 AM Amit Kapila wrote:
> On Mon, Jul 5, 2021 at 12:54 PM Masahiko Sawada
> wrote:
> >
> > On Fri, May 21, 2021 at 6:00 PM Ashutosh Bapat
> > wrote:
> > >
> > > It's there in CF. I am fine with PG-15. It will be good to patch the
> back-branches to have this extra dia
Hackers,
The Commitfest 2021-07 is now in progress. It is one of the biggest one.
Total number of patches of this commitfest is 342.
Needs review: 204.
Waiting on Author: 40.
Ready for Committer: 18.
Committed: 57.
Moved to next CF: 3.
Withdrawn: 15.
Rejected: 3.
Returned with Feedback: 2.
Total:
On Sun, 13 Jun 2021 at 03:07, David Rowley wrote:
>
> Please find attached my WIP patch. It's WIP due to what I mentioned
> in the above paragraph and also because I've not bothered to add JIT
> support for the new expression evaluation steps.
I've split this patch into two parts.
0001 Adds pla
On Mon, 2021-07-12 at 16:58 +0530, Jeevan Ladhe wrote:
> While looking into one of the pg_upgrade issue, I found it
> challenging to find out the database that has the datallowconn set to
> 'false' that was throwing following error:
>
> "All non-template0 databases must allow connections, i.e. the
On Mon, 5 Jul 2021 at 01:01, David Rowley wrote:
> I've spent a bit of time hacking at this and I've come up with the
> attached patch.
Matthias, any thoughts on my revised version of the patch?
David
+1 for the change. Patch looks good to me.
On Mon, Jul 12, 2021 at 4:59 PM Jeevan Ladhe
wrote:
> While looking into one of the pg_upgrade issue, I found it
>
> challenging to find out the database that has the datallowconn set to
>
> 'false' that was throwing following error:
>
>
> *"All non-tem
On Mon, 12 Jul 2021 at 14:06, David Rowley wrote:
>
> On Mon, 5 Jul 2021 at 01:01, David Rowley wrote:
> > I've spent a bit of time hacking at this and I've come up with the
> > attached patch.
>
> Matthias, any thoughts on my revised version of the patch?
Sorry for the delay. I think that cove
On Fri, Jun 11, 2021 at 1:18 PM Tom Lane wrote:
> Heikki Linnakangas writes:
> > On 09/04/2021 07:01, Thomas Munro wrote:
> >> This seems to work on Linux, macOS, FreeBSD and OpenBSD (and I assume
> >> any other BSD). Can anyone tell me if it works on illumos, AIX or
> >> HPUX, and if not, how t
On Mon, Jul 12, 2021 at 02:06:31PM +0200, Laurenz Albe wrote:
> On Mon, 2021-07-12 at 16:58 +0530, Jeevan Ladhe wrote:
> > While looking into one of the pg_upgrade issue, I found it
> > challenging to find out the database that has the datallowconn set to
> > 'false' that was throwing following err
On 7/8/21 9:26 PM, Robert Haas wrote:
Here at last is a new version.
Please refer this scenario ,where backup target using
--server-compression is closing the server
unexpectedly if we don't provide -no-manifest option
[tushar@localhost bin]$ ./pg_basebackup --server-compression=gzip4 -t
ser
On 7/12/21 10:32 AM, Rahila Syed wrote:
> Hi Peter,
>
> Hi, I was wondering if/when a subset of cols is specified then does
> that mean it will be possible for the table to be replicated to a
> *smaller* table at the subscriber side?
>
> e.g Can a table with 7 cols replicated
On Tue, Jun 8, 2021 at 10:50 PM Michael Paquier wrote:
>
> At first glance, this looked to me like breaking something just for
> sake of breaking it, but removing the rel argument could be helpful
> to simplify any external code calling it as there would be no need for
> this extra Relation. So t
On Mon, Jul 12, 2021 at 5:28 PM Ashutosh Bapat
wrote:
>
> On Mon, Jul 12, 2021 at 8:39 AM Amit Kapila wrote:
>>
>> I have noticed that
>> a nearby function LogicalIncreaseRestartDecodingForSlot() logs similar
>> information after releasing spinlock, so it is better to follow the
>> same here as w
On 7/12/21 11:38 AM, Rahila Syed wrote:
> Hi Alvaro,
>
> Thank you for comments.
>
> The patch adds a function get_att_num_by_name; but we have a lsyscache.c
> function for that purpose, get_attnum. Maybe that one should be used
> instead?
>
> Thank you for pointing that out, I ag
On 7/12/21 1:10 PM, Egor Rogov wrote:
> Hi,
>
> thanks for the review and corrections.
>
> On 11.07.2021 21:54, Soumyadeep Chakraborty wrote:
>> Hello,
>>
>> This should have been added with [1].
>>
>> Excerpt from the documentation:
>> "pg_stats is also designed to present the information in a m
On Wed, 7 Jul 2021 at 21:32, Ronan Dunklau wrote:
> In the meantime I fixed some formatting issues, please find attached a new
> patch.
I started to look at this.
First I wondered how often we might be able to apply this
optimisation, so I ran make check after adding some elog(NOTICE) calls
to o
Over on [1], Ronan is working on allowing Datum sorts for nodeSort.c
when we're just sorting a single Datum.
I was looking at his v4 patch and noticed that he'd modified
free_sort_tuple() to conditionally only free the sort tuple if it's
non-NULL. Without this change, the select.sql regression te
On Tue, 13 Jul 2021 at 00:14, Matthias van de Meent
wrote:
> Sorry for the delay. I think that covers the basics of what I was
> missing in these docs, and although it does not cover the recursive
> 'if the check is implied by constraints don't lock this partition',
> I'd say that your suggested
David Rowley writes:
> On Mon, 12 Jul 2021 at 03:22, Justin Pryzby wrote:
>> |This is useful if only a small percentage of rows is checked on
>> |the inner side and is controlled by > |linkend="guc-enable-resultcache"/>.
> You might be right there, but I'm not too sure if
Le lundi 12 juillet 2021, 15:11:17 CEST David Rowley a écrit :
> On Wed, 7 Jul 2021 at 21:32, Ronan Dunklau wrote:
> > In the meantime I fixed some formatting issues, please find attached a new
> > patch.
>
> I started to look at this.
Thank you ! I'm attaching a new version of the patch taking
On Mon, 12 Jul 2021 at 15:28, David Rowley wrote:
>
> On Tue, 13 Jul 2021 at 00:14, Matthias van de Meent
> wrote:
> > Sorry for the delay. I think that covers the basics of what I was
> > missing in these docs, and although it does not cover the recursive
> > 'if the check is implied by constra
On 2021-Jul-12, Tomas Vondra wrote:
> FWIW "make check" fails for me with this version, due to segfault in
> OpenTableLists. Apparenly there's some confusion - the code expects the
> list to contain PublicationTable nodes, and tries to extract the
> RangeVar from the elements. But the list actuall
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 13:00, Gilles Darold wrote:
> Le 12/07/2021 à 12:27, gkokola...@pm.me a écrit :
>
> > > > > Shouldn't this be coded as a loop going through @gzip_wals?
> > > > >
> > > > > I would hope that there is only one gz file created. There
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 13:04, Michael Paquier
wrote:
> On Mon, Jul 12, 2021 at 09:42:32AM +, gkokola...@pm.me wrote:
>
> > This to my understanding means that gzip is expected to exist.
> >
> > If this is correct, then simply checking for the header
Greetings.
Thanks for the project. I see the code in github has not been updated for
a long time, is it still in active development?
Thanks
--
Best Regards
Andy Fan (https://www.aliyun.com/)
On 2021/07/09 11:41, Bharath Rupireddy wrote:
PSA v6 patch.
Thanks for updating the patch!
+
+ Avoid Using non-negative Word in Error
Messages
+
+
+Do not use non-negative word in error messages as it looks
+ambiguous. Instead, use foo must be an integer value greater than
Hi,
As suggested in [1], starting a new thread for discussing $subject
separately. {pre, post}_auth_delay waiting logic currently uses
pg_usleep which can't detect postmaster death. So, there are chances
that some of the backends still stay in the system even when a
postmaster crashes (for whatev
David Rowley writes:
> It looks like this has likely never come up before because the only
> time we use tuplesort_set_bound() is in nodeSort.c and
> nodeIncrementalSort.c, none of those currently use datum sorts.
> However, I'm thinking this is still a bug that should be fixed
> separately from R
On Mon, Jul 12, 2021 at 4:29 AM Thomas Munro wrote:
>
> On Sun, Jul 11, 2021 at 1:18 AM vignesh C wrote:
> > On Wed, May 12, 2021 at 5:45 PM Pavel Stehule
> > wrote:
> > > looks so with your patch psql doesn't work on ms
>
> Here's a fix for Windows. The pqsignal() calls are #ifdef'd out. I
>
Em seg., 12 de jul. de 2021 às 05:20, Heikki Linnakangas
escreveu:
> On 12/07/2021 02:34, Ranier Vilela wrote:
> > If it is not possible, know the upper limits, before the loop.
> > It is necessary to do this inside the loop.
>
> > @@ -49,10 +47,14 @@ _bt_restore_page(Page page, char *from, int l
On Fri, Jul 9, 2021 at 1:42 AM Jacob Champion wrote:
>
> Hi Magnus,
>
> I'm only just starting to page this back into my head, so this is by no
> means a full review of the v7 changes -- just stuff I've noticed over
> the last day or so of poking around.
>
> On Tue, 2021-06-29 at 11:48 +0200, Magn
On Sun, Jul 11, 2021 at 3:23 PM Dean Rasheed wrote:
>
> On Sat, 10 Jul 2021 at 18:09, vignesh C wrote:
> >
> > I'm planning to handle conflicting errors separately after this
> > current work is done, once the patch is changed to have just the valid
> > scenarios(removing the scenarios you have p
On Mon, Jul 12, 2021 at 9:20 PM Fujii Masao wrote:
> +
> + Avoid Using non-negative Word in Error
> Messages
> +
> +
> +Do not use non-negative word in error messages as it looks
> +ambiguous. Instead, use foo must be an integer value greater than
> zero
> +or foo must be an
‐‐‐ Original Message ‐‐‐
On Monday, July 12th, 2021 at 17:07, wrote:
> ‐‐‐ Original Message ‐‐‐
>
> On Monday, July 12th, 2021 at 13:04, Michael Paquier mich...@paquier.xyz
> wrote:
>
> > On Mon, Jul 12, 2021 at 09:42:32AM +, gkokola...@pm.me wrote:
> >
> > > This to my un
[ moved from -bugs list for more visibility ]
I wrote:
> However, that root issue is converted from a relatively minor bug into
> a server crash because snprintf.c treats a NULL pointer passed to %s
> as a crash-worthy error. I have advocated for that behavior in the
> past, but I'm starting to w
Noah Misch writes:
> On Thu, Jul 08, 2021 at 04:34:55PM -0400, Tom Lane wrote:
>> Robert Haas writes:
>>> I like debug_discard_caches best.
>> I can live with that. Anyone strongly against it?
> I like it.
Hearing no votes against, here's a proposed patch for that.
(This is for HEAD; I expec
On 12.07.21 10:44, David Rowley wrote:
What I was trying to get to here was something that was more
reasonable that might make sense to commit. I'm just not certain
where Peter stands on this now that the latest patch is a net zero
when it comes to adding lines. Peter?
Your version looks bette
On 2021-Jun-23, houzj.f...@fujitsu.com wrote:
> For a multi-level partition, for example: table 'A' is partition of table
> 'B', and 'B' is also partition of table 'C'. After I 'ALTER TABLE C DETACH B',
> I thought partition constraint check of table 'C' does not matter anymore if
> INSERT INTO ta
On 06.07.21 22:34, Tom Lane wrote:
2. We'd really like to use preadv/pwritev where available.
A couple of things that I haven't seen made clear in this thread yet:
- Where is the availability boundary for preadv/pwritev on macOS?
- What is the impact of having vs. not having these functions?
I wrote:
> I don't think the new structuring will pose any challenges for rebasing
0002, either. This might need some experimentation, though:
>
> + * Subroutine of pg_utf8_verifystr() to check on char. Returns the
length of the
> + * character at *s in bytes, or 0 on invalid input or premature en
On Mon, Jul 12, 2021, at 8:44 AM, Tomas Vondra wrote:
> While looking at the other logrep patch [1] (column filtering) I noticed
> Alvaro's comment regarding a new parsenode (PublicationTable) not having
> read/out/equal/copy funcs. I'd bet the same thing applies here, so
> perhaps see if the patch
On 22.04.21 11:23, Julien Rouhaud wrote:
The statistics gathered by the module are made available via a
view named pg_stat_statements. This view
- contains one row for each distinct database ID, user ID and query
- ID (up to the maximum number of distinct statements that the module
po 12. 7. 2021 v 18:12 odesílatel vignesh C napsal:
> On Mon, Jul 12, 2021 at 4:29 AM Thomas Munro
> wrote:
> >
> > On Sun, Jul 11, 2021 at 1:18 AM vignesh C wrote:
> > > On Wed, May 12, 2021 at 5:45 PM Pavel Stehule
> wrote:
> > > > looks so with your patch psql doesn't work on ms
> >
> > Her
On 6/30/21 1:43 AM, Josef Šimánek wrote:
> st 30. 6. 2021 v 1:20 odesílatel Tomas Vondra
> napsal:
>>
>>
>>
>> On 6/30/21 12:53 AM, Josef Šimánek wrote:
>>> st 30. 6. 2021 v 0:31 odesílatel Josef Šimánek
>>> napsal:
Hello!
Tomáš Vondra has shared a few ideas to improve BRIN i
On 2021-Jul-12, ikeda...@oss.nttdata.com wrote:
> While I’m reading source codes related to vacuum, I found comments which
> don’t seem to fit the reality. I think the commit[1] just forgot to fix them.
> What do you think?
>
> [1]
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h
On 2021-Jul-12, Tomas Vondra wrote:
> 2) Do we actually need to calculate and store hotblockingattrs
> separately in RelationGetIndexAttrBitmap? It seems to me it's either
> NULL (with amhotblocking=false) or equal to indexattrs. So why not to
> just get rid of hotblockingattr and rd_hotblockingat
On 7/12/21 10:37 PM, Alvaro Herrera wrote:
> On 2021-Jul-12, Tomas Vondra wrote:
>
>> 2) Do we actually need to calculate and store hotblockingattrs
>> separately in RelationGetIndexAttrBitmap? It seems to me it's either
>> NULL (with amhotblocking=false) or equal to indexattrs. So why not to
>
On Tue, Jul 13, 2021 at 7:39 AM Peter Eisentraut
wrote:
> On 06.07.21 22:34, Tom Lane wrote:
> > 2. We'd really like to use preadv/pwritev where available.
>
> A couple of things that I haven't seen made clear in this thread yet:
>
> - Where is the availability boundary for preadv/pwritev on macOS
po 12. 7. 2021 v 22:31 odesílatel Tomas Vondra
napsal:
>
> On 6/30/21 1:43 AM, Josef Šimánek wrote:
> > st 30. 6. 2021 v 1:20 odesílatel Tomas Vondra
> > napsal:
> >>
> >>
> >>
> >> On 6/30/21 12:53 AM, Josef Šimánek wrote:
> >>> st 30. 6. 2021 v 0:31 odesílatel Josef Šimánek
> >>> napsal:
> >>
On 7/12/21 10:45 PM, Josef Šimánek wrote:
> po 12. 7. 2021 v 22:31 odesílatel Tomas Vondra
> napsal:
>>
>> On 6/30/21 1:43 AM, Josef Šimánek wrote:
>>> st 30. 6. 2021 v 1:20 odesílatel Tomas Vondra
>>> napsal:
On 6/30/21 12:53 AM, Josef Šimánek wrote:
> st 30. 6. 2021 v
On 2021-Jul-12, Tomas Vondra wrote:
> Well, one of us is confused and it might be me ;-)
:-)
> The point is that BRIN is the only index type with amhotblocking=false,
> so it would return NULL (and thus it does not block HOT). All other
> indexes AMs have amblocking=true and so should return rd_
On Mon, 12 Jul 2021 at 13:14, wrote:
>
> Hi,
>
> While I’m reading source codes related to vacuum, I found comments which
> don’t seem to fit the reality. I think the commit[1] just forgot to fix
them.
> What do you think?
Hmm, yes, those are indeed some leftovers.
Some comments on the suggested
On 7/12/21 10:55 PM, Alvaro Herrera wrote:
> On 2021-Jul-12, Tomas Vondra wrote:
>
>> Well, one of us is confused and it might be me ;-)
>
> :-)
>
>> The point is that BRIN is the only index type with amhotblocking=false,
>> so it would return NULL (and thus it does not block HOT). All other
>>
On 2021-Jul-12, Josef Šimánek wrote:
> > 2) Do we actually need to calculate and store hotblockingattrs
> > separately in RelationGetIndexAttrBitmap? It seems to me it's either
> > NULL (with amhotblocking=false) or equal to indexattrs. So why not to
> > just get rid of hotblockingattr and rd_hotb
Amul Sul writes:
> [ v5_Add-RelationGetSmgr-inline-function.patch ]
Pushed with minor cosmetic adjustments.
RelationCopyStorage() kind of gives me the willies.
It's not really an smgr-level function, but we call it
everywhere with smgr pointers that belong to relcache entries:
/* copy m
On 7/12/21 11:02 PM, Alvaro Herrera wrote:
> On 2021-Jul-12, Josef Šimánek wrote:
>
>>> 2) Do we actually need to calculate and store hotblockingattrs
>>> separately in RelationGetIndexAttrBitmap? It seems to me it's either
>>> NULL (with amhotblocking=false) or equal to indexattrs. So why not
Greetings,
* Magnus Hagander (mag...@hagander.net) wrote:
> On Mon, Jul 12, 2021 at 5:43 AM Peifeng Qiu wrote:
> > >As you note, this'd have to be restricted to superusers, which makes it
> > >seem like a pretty bad idea. We really don't want to be in a situation
> > >of pushing people to run da
Greetings,
* Bharath Rupireddy (bharath.rupireddyforpostg...@gmail.com) wrote:
> I've always had a hard time distinguishing various types of
> processes/terms used in postgres. I look at the source code every time
> to understand them, yet I don't feel satisfied with my understanding.
> I request
Thomas Munro writes:
> Clearly there is a more general question though, which is "should we
> buy into Apple's ABI management system or not", and I don't have a
> strong opinion on that.
Well, I definitely don't wish to clutter our core code with any
explicit dependencies on MACOSX_DEPLOYMENT_TAR
> On 10 Jul 2021, at 17:47, Tomas Vondra wrote:
> So if it was up to me, I'd go back to the original format or something close
> it. So something like this:
>
> [+-] OBJECT_TYPE_PATTERN OBJECT_NAME_PATTERN
That still leaves the parsing with quoting and escaping that needs to be done
less trivi
On 7/13/21 12:08 AM, Daniel Gustafsson wrote:
On 10 Jul 2021, at 17:47, Tomas Vondra wrote:
So if it was up to me, I'd go back to the original format or something close
it. So something like this:
[+-] OBJECT_TYPE_PATTERN OBJECT_NAME_PATTERN
That still leaves the parsing with quoting and
On 2021-Jul-13, Tomas Vondra wrote:
> I'm not going to fight against some sort of versioning, but I think keeping
> the scope as narrow as possible would make it unnecessary. That is, let's
> stick to the original goal to allow passing filtering rules that would not
> fit on the command-line, and
On 2021-Jul-12, Tomas Vondra wrote:
> I'm not sure how to verify no external code depends on that flag. I have
> no idea if there's a plausible use case for it, though.
But we don't *have* to, do we?
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"Tiene valor a
po 12. 7. 2021 v 23:15 odesílatel Tomas Vondra
napsal:
>
>
>
> On 7/12/21 11:02 PM, Alvaro Herrera wrote:
> > On 2021-Jul-12, Josef Šimánek wrote:
> >
> >>> 2) Do we actually need to calculate and store hotblockingattrs
> >>> separately in RelationGetIndexAttrBitmap? It seems to me it's either
> >
Em seg., 12 de jul. de 2021 às 09:04, David Rowley
escreveu:
> On Sun, 13 Jun 2021 at 03:07, David Rowley wrote:
> >
> > Please find attached my WIP patch. It's WIP due to what I mentioned
> > in the above paragraph and also because I've not bothered to add JIT
> > support for the new expressio
Alvaro Herrera writes:
> [1] your proposal of "[+-] OBJTYPE OBJIDENT" plus empty lines allowed
> plus lines starting with # are comments, seems plenty. Any line not
> following that format would cause an error to be thrown.
I'd like to see some kind of keyword on each line, so that we co
Autoconf's AC_CHECK_DECLS always defines HAVE_DECL_whatever
as 1 or 0, but some of the entries in msvc/Solution.pm show
such symbols as "undef" instead. Shouldn't we fix it as
per attached? This is probably only cosmetic at the moment,
but it could bite us someday if someone wrote a complex
condi
On Sun, 2021-07-11 at 13:16 +0900, Michael Paquier wrote:
> On Fri, Jul 09, 2021 at 11:31:48PM +, Jacob Champion wrote:
> > On Thu, 2021-07-08 at 16:27 +0900, Michael Paquier wrote:
> > > + * outputlen: The length (0 or higher) of the client response
> > > buffer,
> > > + *
On Tue, 13 Jul 2021 at 01:38, Tom Lane wrote:
>
> David Rowley writes:
> > On Mon, 12 Jul 2021 at 03:22, Justin Pryzby wrote:
> >> |This is useful if only a small percentage of rows is checked on
> >> |the inner side and is controlled by >> |linkend="guc-enable-resultcac
On Tue, Jul 13, 2021 at 8:20 AM Pavel Stehule wrote:
> po 12. 7. 2021 v 18:12 odesílatel vignesh C napsal:
>> Thanks for fixing the comments, CFbot also passes for the same. I have
>> changed the status back to "Ready for Committer".
>
> I tested this version with the last release and with a deve
On 2021-Jul-12, Alvaro Herrera wrote:
> On 2021-Jul-12, ikeda...@oss.nttdata.com wrote:
>
> > While I’m reading source codes related to vacuum, I found comments which
> > don’t seem to fit the reality. I think the commit[1] just forgot to fix
> > them.
> > What do you think?
> >
> > [1]
> > ht
On Fri, Jul 09, 2021 at 04:50:28PM +0900, Kyotaro Horiguchi wrote:
> At Fri, 9 Jul 2021 10:29:07 +0900, Michael Paquier
> wrote in
>> Er, wait. We've actually allowed negative values for pg_ctl
>> --timeout or the subcommand kill!?
>
> --timeout accepts values less than 1, which values cause th
1 - 100 of 132 matches
Mail list logo
