On 2021-Jul-13, Tomas Vondra wrote: > I'm not going to fight against some sort of versioning, but I think keeping > the scope as narrow as possible would make it unnecessary. That is, let's > stick to the original goal to allow passing filtering rules that would not > fit on the command-line, and maybe let's make it a bit more flexible to > support other object types etc. > > IMHO the filtering rules are simple enough to not really need elaborate > versioning, and if a more advanced rule is proposed in the future it can be > supported in the existing format (extra field, ...).
I don't understand why is versioning needed for this file. Surely we can just define some line-based grammar that's accepted by the current pg_dump[1] and that would satisfy the current need as well as allowing for extending the grammar in the future; even JSON or Windows-INI format (ugh?) if that's necessary to tailor the output file in some other way not covered by that. [1] your proposal of "[+-] OBJTYPE OBJIDENT" plus empty lines allowed plus lines starting with # are comments, seems plenty. Any line not following that format would cause an error to be thrown. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/