Re: Asynchronous Append on postgres_fdw nodes.

2021-01-02 Thread Etsuro Fujita
On Sun, Dec 20, 2020 at 5:15 PM Etsuro Fujita wrote: > On Thu, Nov 26, 2020 at 10:28 AM movead...@highgo.ca > wrote: > > Issue one: > > Get a Assert error at 'Assert(bms_is_member(i, node->as_needrequest));' in > > ExecAppendAsyncRequest() function when I use more than two foreign table > > on di

Re: Proposed patch for key management

2021-01-02 Thread Fabien COELHO
Hello Stephen, I'm unsure about what is the "common use case". ISTM that having the postgres process holding the master key looks like a "no" for me in any use case with actual security concern: as the database must be remotely accessible, a reasonable security assumption is that a pg account c

Re: Spurious "apparent wraparound" via SimpleLruTruncate() rounding

2021-01-02 Thread Noah Misch
On Sat, Jan 02, 2021 at 12:31:45PM +0500, Andrey Borodin wrote: > Do I understand correctly that this is bugfix that needs to be back-patched? The slru-truncate-modulo patch fixes a bug. The slru-truncate-t-insurance patch does not. Neither _needs_ to be back-patched, though I'm proposing to bac

Re: faster ETL / bulk data load for heap tables

2021-01-02 Thread Luc Vlaming
On 02-01-2021 08:36, Amit Kapila wrote: On Fri, Jan 1, 2021 at 7:37 PM Luc Vlaming wrote: Hi, In an effort to speed up bulk data loading/transforming I noticed that considerable time is spent in the relation extension lock. We already do extend the relation in bulk when there is a contenti

Re: faster ETL / bulk data load for heap tables

2021-01-02 Thread Luc Vlaming
On 01-01-2021 19:55, Zhihong Yu wrote: Hi, Luc: Happy New Year. Looking at BufferAllocExtend() in v1-0002-WIP-buffer-alloc-specialized-for-relation-extensi.patch. it seems there is duplicate code with the existing BufferAlloc(). It would be good if some refactoring is done by extracting comm

Re: Proposed patch for key management

2021-01-02 Thread Alastair Turner
Hi Fabien On Sat, 2 Jan 2021 at 09:50, Fabien COELHO wrote: > ... > ISTM that pg at the core level should (only) directly provide: > > (1) a per-file encryption scheme, with loadable (hook-replaceable > functions??) to manage pages, maybe: > >encrypt(page_id, *key, *clear_page, *encrypted_pag

Re: [HACKERS] [PATCH] Generic type subscripting

2021-01-02 Thread Dmitry Dolgov
> On Thu, Dec 31, 2020 at 08:21:55PM +0100, Pavel Stehule wrote: > čt 31. 12. 2020 v 15:27 odesílatel Dmitry Dolgov <9erthali...@gmail.com> > napsal: > > the tests passed and filling gaps works well > > but creating empty objects doesn't work > > create table foo(a jsonb); > > insert into foo value

RE: [Patch] Optimize dropping of relation buffers using dlist

2021-01-02 Thread k.jami...@fujitsu.com
On Wednesday, December 30, 2020 8:58 PM, Amit Kapila wrote: > On Wed, Dec 30, 2020 at 11:28 AM Tang, Haiying > wrote: > > > > Hi Amit, > > > > In last > > > mail(https://www.postgresql.org/message-id/66851e198f6b41eda59e625718 > 2 > > 564b6%40G08CNEXMBPEKD05.g08.fujitsu.local), > > I've sent you t

Re: Move --data-checksums to common options in initdb --help

2021-01-02 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Fri, Jan 01, 2021 at 08:34:34PM +0100, Michael Banck wrote: > > I think enough people use data checksums these days that it warrants to > > be moved into the "normal part", like in the attached. > > +1. Let's see first what others th

Why latestRemovedXid|cuteoff_xid are always sent?

2021-01-02 Thread Michail Nikolaev
Hello, hackers. Working on some stuff, I realized I do not understand why latestRemovedXid|cuteoff_xid (in different types of WAL records) are sent every time they appear on the primary side. latestRemovedXid|cuteoff_xid is used to call ResolveRecoveryConflictWithSnapshot and cancel conflicting b

Re: archive status ".ready" files may be created too early

2021-01-02 Thread Andrey Borodin
Hi! I was looking to review something in CF. This seems like a thread of some interest to me. Recently we had somewhat related incident. Do I understand correctly that this incident is related to the bug discussed in this thread? Primary instance was killed by OOM [ 2020-11-12 15:27:03.732 MSK

Re: Reloptions for table access methods

2021-01-02 Thread Jeff Davis
On Wed, 2020-12-30 at 21:23 +, Simon Riggs wrote: > But you cannot seriously argue that a one line patch that changes > user > visible behavior can be acceptable in Postgres core without tests or > docs or code comments. Hi Simon, Often, good documented APIs come about after a few extensions

Re: pgbench: option delaying queries till connections establishment?

2021-01-02 Thread Fabien COELHO
It looks like macOS doesn't have pthread barriers (via cfbot 2021, now with more operating systems): Indeed:-( I'll look into that. Just for fun, the attached 0002 patch is a quick prototype of a replacement for that stuff that seems to work OK on a Mac here. (I'm not sure if the Windows

Re: WIP: BRIN multi-range indexes

2021-01-02 Thread Tomas Vondra
Hi, On 1/2/21 7:42 AM, Thomas Munro wrote: > On Sun, Dec 20, 2020 at 1:16 PM Tomas Vondra > wrote: >> Attached is an updated version of the patch series, rebased on current >> master, and results for benchmark comparing the various bloom variants. > > Perhaps src/include/utils/inet.h needs to in

Re: Why latestRemovedXid|cuteoff_xid are always sent?

2021-01-02 Thread Peter Geoghegan
On Sat, Jan 2, 2021 at 8:00 AM Michail Nikolaev wrote: > Working on some stuff, I realized I do not understand why > latestRemovedXid|cuteoff_xid (in different types of WAL records) are > sent every time they appear on the primary side. > > latestRemovedXid|cuteoff_xid is used to call > ResolveRec

Re: doc review for v14

2021-01-02 Thread Michael Paquier
On Tue, Dec 29, 2020 at 06:22:43PM +0900, Michael Paquier wrote: > Yes, I have done an extra effort on those fixes where needed. On top > of that, I have included catalogs.sgml, pgstatstatements.sgml, > explain.sgml, pg_verifybackup.sgml and wal.sgml in 13. Justin, I got to look at the libxml2 pa

Re: doc review for v14

2021-01-02 Thread Justin Pryzby
On Sun, Jan 03, 2021 at 03:10:54PM +0900, Michael Paquier wrote: > On Tue, Dec 29, 2020 at 06:22:43PM +0900, Michael Paquier wrote: > > Yes, I have done an extra effort on those fixes where needed. On top > > of that, I have included catalogs.sgml, pgstatstatements.sgml, > > explain.sgml, pg_verif