Hi, On 1/2/21 7:42 AM, Thomas Munro wrote: > On Sun, Dec 20, 2020 at 1:16 PM Tomas Vondra > <tomas.von...@enterprisedb.com> wrote: >> Attached is an updated version of the patch series, rebased on current >> master, and results for benchmark comparing the various bloom variants. > > Perhaps src/include/utils/inet.h needs to include <sys/socket.h>, > because FreeBSD says: > > brin_minmax_multi.c:1693:24: error: use of undeclared identifier 'AF_INET' > if (ip_family(ipa) == PGSQL_AF_INET) > ^ > ../../../../src/include/utils/inet.h:39:24: note: expanded from macro > 'PGSQL_AF_INET' > #define PGSQL_AF_INET (AF_INET + 0) > ^
Not sure. The other files using PGSQL_AF_INET just include sys/socket.h directly, so maybe this should just do the same thing ... regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
