On 12.01.2020 4:51, Tomas Vondra wrote:
On Fri, Jan 10, 2020 at 11:47:42AM +0300, Konstantin Knizhnik wrote:
On 09.01.2020 19:48, Tomas Vondra wrote:
The most complex and challenged task is to support GTT for all kind
of indexes. Unfortunately I can not proposed some good universal
solu
On 2020-01-13 08:29, Andy Fan wrote:
During one of my works for logical rewrite, I want to check if the expr
is a given Expr.
so the simplest way is:
if (expr->opno == 418 && nodeTag(linitial(expr->args)) == T_xxx &&
nodeTag(lsecond(expr->args)) == T_ )
{
..
}
if we write code like a
On Mon, Jan 13, 2020 at 12:51 PM Antonin Houska wrote:
>
> This diff fixes what I consider a typo.
>
LGTM. I'll push this in some time.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
On Mon, Jan 13, 2020 at 12:40:20AM +0100, Daniel Gustafsson wrote:
> Thanks for clarifying. PFA tiny patch for this.
Thanks, pushed.
--
Michael
signature.asc
Description: PGP signature
Hello
> I just thought they were concerned
> that the variable name skip_index might be confusing because we skip
> if skip_index is NOT true.
Right.
>> > - bool skip_index = (get_indstats(lps->lvshared, i) == NULL ||
>> > - skip_parallel_vacuum_index(Irel[i], lps->lvshared));
>> > + bool can
Hi hackers,
I want to propose to you an old patch for Postgres 11, off-site developed
by Oliver Ford,
but I have permission from him to publish it and to continue it's
development,
that allow distinct aggregates, like select sum(distinct nums) within a
window function.
I have rebased it for curre
On Mon, Jan 13, 2020 at 4:09 PM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2020-01-13 08:29, Andy Fan wrote:
> > During one of my works for logical rewrite, I want to check if the expr
> > is a given Expr.
> >
> > so the simplest way is:
> > if (expr->opno == 418 && nodeTag(
Hi all,
While reviewing some code in namespace.c, I have bumped into the
following issue introduced by 246a6c8:
diff --git a/src/backend/catalog/namespace.c
b/src/backend/catalog/namespace.c
index c82f9fc4b5..e70243a008 100644
--- a/src/backend/catalog/namespace.c
+++ b/src/backend/catalog/namespa
On Thu, Jan 9, 2020 at 12:09 PM Amit Kapila wrote:
>
> On Thu, Jan 9, 2020 at 10:30 AM Dilip Kumar wrote:
> >
> > On Thu, Jan 9, 2020 at 9:35 AM Amit Kapila wrote:
> > >
> > > On Wed, Jan 8, 2020 at 1:12 PM Dilip Kumar wrote:
> > > >
> > > > I have observed one more design issue.
> > > >
> > >
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:tested, passed
Thank you!
Looks good to me. I have no further comments. I'll mar
On Thu, Jan 9, 2020 at 4:03 PM Amit Kapila wrote:
>
> On Thu, Jan 9, 2020 at 10:41 AM Masahiko Sawada
> wrote:
> >
> > On Wed, 8 Jan 2020 at 22:16, Amit Kapila wrote:
> > >
> > >
> > > What do you think of the attached? Sawada-san, kindly verify the
> > > changes and let me know your opinion.
>
On Mon, Jan 13, 2020 at 2:08 PM Amit Kapila wrote:
>
> On Mon, Jan 13, 2020 at 12:51 PM Antonin Houska wrote:
> >
> > This diff fixes what I consider a typo.
> >
>
> LGTM. I'll push this in some time.
>
Pushed.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
On Fri, Jan 10, 2020 at 9:43 PM Alvaro Herrera
wrote:
> On 2020-Jan-09, Alvaro Herrera wrote:
>
> > I looked at this a little while and was bothered by the perl changes; it
> > seems out of place to have RecursiveCopy be thinking about tablespaces,
> > which is way out of its league. So I rewrot
On Mon, Jan 13, 2020 at 7:57 AM Tom Lane wrote:
>
> Hmm ... after a bit of research I agree that these functions are not
> a portability hazard. They are present at least as far back as flex
> 2.5.33 which is as old as we've got in the buildfarm.
>
> However, I'm less excited about them from a pe
On 2020-01-10 14:41, Robert Haas wrote:
This rule very nearly matches the current behavior: it explains why
temp table operations are allowed, and why ALTER SYSTEM is allowed,
and why REINDEX etc. are allowed. However, there's a notable
exception: PREPARE, COMMIT PREPARED, and ROLLBACK PREPARED a
On Sat, Jan 11, 2020 at 5:06 PM Tomas Vondra
wrote:
>
> Thanks. I did a quick review of this patch, and I think it's almost RFC.
>
>
Thanks for reviewing.
> - In func.sgml, it seems we've lost this bit:
>
>
> TM does not include trailing blanks.
> to_timestamp and to_dat
On Mon, Jan 13, 2020 at 06:37:03PM +0900, Michael Paquier wrote:
> Hi all,
>
> While reviewing some code in namespace.c, I have bumped into the
> following issue introduced by 246a6c8:
> diff --git a/src/backend/catalog/namespace.c
> b/src/backend/catalog/namespace.c
> index c82f9fc4b5..e70243a008
On Thu, Sep 26, 2019 at 7:17 PM Luis Carril wrote:
>
>
> I don't disagree with adding FOREIGN, though.
>
> Your patch is failing the pg_dump TAP tests. Please use
> configure --enable-tap-tests, fix the problems, then resubmit.
>
> Fixed, I've attached a new version.
Will it be possible to add a
On 2020-01-11 17:47, Magnus Hagander wrote:
On Sat, Jan 11, 2020 at 5:44 PM Julien Rouhaud wrote:
On Sat, Jan 11, 2020 at 08:21:11AM +0100, Peter Eisentraut wrote:
On 2020-01-06 21:00, Magnus Hagander wrote:
+0.5 to avoid calling OidInputFunctionCall()
Or just directly using atol() instead
On Mon, Jan 13, 2020 at 1:49 PM Peter Eisentraut
wrote:
>
> On 2020-01-11 17:47, Magnus Hagander wrote:
> > On Sat, Jan 11, 2020 at 5:44 PM Julien Rouhaud wrote:
> >>
> >> On Sat, Jan 11, 2020 at 08:21:11AM +0100, Peter Eisentraut wrote:
> >>> On 2020-01-06 21:00, Magnus Hagander wrote:
> > +
On Mon, Jan 13, 2020 at 01:09:01PM +0100, Julien Rouhaud wrote:
> But that means an extraneous call to BackendIdGetProc() in that
> case, it seems better to avoid it if we already have the information.
Note that you cannot make a direct comparison of the result from
GetTempNamespaceBackendId() wit
On Sat, Jan 11, 2020 at 02:12:15AM +0900, Fujii Masao wrote:
> I'm not sure if returning false with WARNING only in some error cases
> is really good idea or not. At least for me, it's more intuitive to
> return true on success and emit an ERROR otherwise. I'd like to hear
> more opinions about thi
On Mon, Jan 13, 2020 at 10:14:52PM +0900, Michael Paquier wrote:
> On Mon, Jan 13, 2020 at 01:09:01PM +0100, Julien Rouhaud wrote:
> > But that means an extraneous call to BackendIdGetProc() in that
> > case, it seems better to avoid it if we already have the information.
>
> Note that you cannot m
Krasiyan Andreev writes:
> I want to propose to you an old patch for Postgres 11, off-site developed
> by Oliver Ford,
> but I have permission from him to publish it and to continue it's
> development,
> that allow distinct aggregates, like select sum(distinct nums) within a
> window function.
I
vignesh C writes:
> On Thu, Sep 26, 2019 at 7:17 PM Luis Carril wrote:
>>> Your patch is failing the pg_dump TAP tests. Please use
>>> configure --enable-tap-tests, fix the problems, then resubmit.
>> Fixed, I've attached a new version.
> Will it be possible to add a test case for this, can we
On Mon, Jan 13, 2020 at 2:46 PM Michael Paquier wrote:
>
> On Sat, Jan 11, 2020 at 02:12:15AM +0900, Fujii Masao wrote:
> > I'm not sure if returning false with WARNING only in some error cases
> > is really good idea or not. At least for me, it's more intuitive to
> > return true on success and e
Tom Lane schrieb am 13.01.2020 um 15:19:
> what it is is attaching DISTINCT to a window function itself.
> I'd still ask whether it's well-defined though, or even minimally
> sensible. Window functions are generally supposed to produce one
> row per input row --- how does that square with the imp
The v2 patch is attached.
This adds two dedicated lists on the RelOptInfo to preserve lesser paths
if extension required to retain the path-node to be removed in usual manner.
These lesser paths are kept in the separated list, so it never expand the length
of pathlist and partial_pathlist. That wa
I understand yours note about datatype-specific operations, so I need to
think more generic about it.
About yours additional note, I think that it is not possible to get easy
the same result with appropriate use of window framing options,
because "exclude ties" will not exclude "current row" itself
On 13/01/2020 15:19, Tom Lane wrote:
> Krasiyan Andreev writes:
>> I want to propose to you an old patch for Postgres 11, off-site developed
>> by Oliver Ford,
>> but I have permission from him to publish it and to continue it's
>> development,
>> that allow distinct aggregates, like select sum(di
On Mon, Jan 13, 2020 at 11:08:40AM +0300, Konstantin Knizhnik wrote:
On 12.01.2020 4:51, Tomas Vondra wrote:
On Fri, Jan 10, 2020 at 11:47:42AM +0300, Konstantin Knizhnik wrote:
On 09.01.2020 19:48, Tomas Vondra wrote:
The most complex and challenged task is to support GTT for all
kind o
On 2020-01-06 07:06, Tom Lane wrote:
Hence, the attached revision only forces quoting in a SQL COPY
command, or if the user already typed a quote.
Yes, that seems better. Users tend to not like if tab completion messes
with what they have already typed unless strictly necessary.
The file na
On Fri, 10 Jan 2020 at 15:51, Sergei Kornilov wrote:
>
> Hi
> Thank you for update! I looked again
>
> (vacuum_indexes_leader)
> + /* Skip the indexes that can be processed by parallel workers
> */
> + if (!skip_index)
> + continue;
>
> Does the v
Greetings,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Stephen Frost writes:
> > To be clear, I was advocating for a NEW DB-level privilege ('INSTALL' or
> > 'CREATE EXTENSION' if we could make that work), so that we have it be
> > distinct from CREATE (which, today, really means 'CREATE SCHEMA').
>
Greetings,
* Laurenz Albe (laurenz.a...@cybertec.at) wrote:
> On Fri, 2020-01-10 at 09:29 -0500, Tom Lane wrote:
> > > ALTER SYSTEM is read only in my mind.
> >
> > I'm still having trouble with this conclusion. I think it can only
> > be justified by a very narrow reading of "reflected in pg_du
On Mon, Jan 13, 2020 at 5:57 AM Peter Eisentraut
wrote:
> On 2020-01-10 14:41, Robert Haas wrote:
> > This rule very nearly matches the current behavior: it explains why
> > temp table operations are allowed, and why ALTER SYSTEM is allowed,
> > and why REINDEX etc. are allowed. However, there's a
On Mon, 2020-01-13 at 13:56 -0500, Stephen Frost wrote:
> > I think that having ALTER SYSTEM commands in pg_dumpall output
> > would be a problem. It would cause all kinds of problems whenever
> > parameters change. Thinking of the transition "checkpoint_segments"
> > -> "max_wal_size", you'd hav
Greetings,
* Laurenz Albe (laurenz.a...@cybertec.at) wrote:
> On Mon, 2020-01-13 at 13:56 -0500, Stephen Frost wrote:
> > > I think that having ALTER SYSTEM commands in pg_dumpall output
> > > would be a problem. It would cause all kinds of problems whenever
> > > parameters change. Thinking of
On Mon, Jan 13, 2020 at 05:32:53PM +0100, Tomas Vondra wrote:
> On Mon, Jan 13, 2020 at 11:08:40AM +0300, Konstantin Knizhnik wrote:
> >
> >"if any code tried to access the statistics directly from the table,
> >rather than via the caches".
> >
> >Currently optimizer is accessing statistic though
John Naylor writes:
> [ v11 patch ]
I pushed this with some small cosmetic adjustments.
One non-cosmetic adjustment I experimented with was to change
str_udeescape() to overwrite the source string in-place, since
we know that's modifiable storage and de-escaping can't make
the string longer. I
Peter Eisentraut writes:
> The file name completion portion of this patch seems to work quite well now.
Thanks for testing!
> I have found a weird behavior with identifier quoting, which is not the
> subject of this patch, but it appears to be affected by it.
> The good thing is that the new c
Stephen Frost writes:
> * Tom Lane (t...@sss.pgh.pa.us) wrote:
>> In the meantime, though, this idea as stated doesn't do anything except
>> let a DB owner grant install privileges to someone else. I'm not even
>> convinced that we want that, or that anyone needs it (I can recall zero
>> such req
On 31.12.2019 01:40, Peter Geoghegan wrote:
On Mon, Dec 30, 2019 at 9:45 AM Robert Haas wrote:
For example, float and numeric types are "never bitwise equal", while array,
text, and other container types are "maybe bitwise equal". An array of
integers
or text with C collation can be treated as
Greetings,
* Tom Lane (t...@sss.pgh.pa.us) wrote:
> Stephen Frost writes:
> > * Tom Lane (t...@sss.pgh.pa.us) wrote:
> >> In the meantime, though, this idea as stated doesn't do anything except
> >> let a DB owner grant install privileges to someone else. I'm not even
> >> convinced that we want
On Mon, Jan 13, 2020 at 09:12:38PM +0100, Julien Rouhaud wrote:
On Mon, Jan 13, 2020 at 05:32:53PM +0100, Tomas Vondra wrote:
On Mon, Jan 13, 2020 at 11:08:40AM +0300, Konstantin Knizhnik wrote:
>
>"if any code tried to access the statistics directly from the table,
>rather than via the caches".
On 2020-Jan-11, Tomas Vondra wrote:
> Hi,
>
> On Thu, Sep 26, 2019 at 01:47:28PM +, Luis Carril wrote:
> >
> > I don't disagree with adding FOREIGN, though.
> >
> > Your patch is failing the pg_dump TAP tests. Please use
> > configure --enable-tap-tests, fix the problems, then resubmit.
>
On Mon, Jan 13, 2020 at 02:56:13PM +0100, Julien Rouhaud wrote:
> Well, since isTempNamespaceInUse is for now only called by autovacuum, and
> shouldn't change soon, this really feels premature optimzation, so your
> original approach looks better.
Yes, I'd rather keep this routine in its simplest
On 2020-Jan-07, Mithun Cy wrote:
> I have a test where a user creates a temp table and then disconnect,
> concurrently we try to do DROP OWNED BY CASCADE on the same user. Seems
> this causes race condition between temptable deletion during disconnection
> (@RemoveTempRelations(myTempNamespace)) a
On Mon, Jan 13, 2020 at 12:49 PM Anastasia Lubennikova
wrote:
> In attachment you can find the WIP patch that adds support function for
> btree opclasses.
Cool. Thanks!
> Current version of the patch adds:
>
> 1) new syntax, which allow to provide support function:
>
> CREATE OPERATOR CLASS int4
Hi,
Now that I've committed [1] which allows us to use multiple extended
statistics per table, I'd like to start a thread discussing a couple of
additional improvements for extended statistics. I've considered
starting a separate patch for each, but that would be messy as those
changes will touch
Hi,
On 2020-01-11 22:32:45 -0500, Tom Lane wrote:
> I wrote:
> > I saw at this point that the remaining top spots were
> > enlargeStringInfo and appendBinaryStringInfo, so I experimented
> > with inlining them (again, see patch below). That *did* move
> > the needle: down to 72691 ms, or 20% bett
I threatened to do this in another thread [1], so here it is.
This patch removes the restriction that the server encoding must
be UTF-8 in order to write any Unicode escape with a value outside
the ASCII range. Instead, we'll allow the notation and convert to
the server encoding if that's possibl
On Sat, Jan 11, 2020 at 4:25 AM Tomas Vondra
wrote:
> Understood. Is that a reason to not commit of this patch now, though?
It could use some polishing. Are you interested in committing it?
--
Peter Geoghegan
On Fri, Jan 10, 2020 at 1:36 PM Peter Geoghegan wrote:
> * HEIKKI: Do we only generate one posting list in one WAL record? I
> would assume it's better to deduplicate everything on the page, since
> we're modifying it anyway.
Still thinking about this one.
> * HEIKKI: Does xl_btree_vacuum WAL re
On Mon, Jan 13, 2020 at 07:45:06PM -0300, Alvaro Herrera wrote:
> This seems fiddly to handle better; maybe you'd have to have a new
> PERFORM_DELETION_* flag that says to ignore "missing" objects; so when
> you go from shdepDropOwned, you pass that flag all the way down to
> doDeletion(), so the o
Alvaro Herrera writes:
> On 2020-Jan-07, Mithun Cy wrote:
>> I have a test where a user creates a temp table and then disconnect,
>> concurrently we try to do DROP OWNED BY CASCADE on the same user. Seems
>> this causes race condition between temptable deletion during disconnection
>> (@RemoveTemp
On Mon, Jan 13, 2020 at 7:52 PM Tom Lane wrote:
>
> vignesh C writes:
> > On Thu, Sep 26, 2019 at 7:17 PM Luis Carril wrote:
> >>> Your patch is failing the pg_dump TAP tests. Please use
> >>> configure --enable-tap-tests, fix the problems, then resubmit.
>
> >> Fixed, I've attached a new versi
On Fri, Nov 29, 2019 at 2:10 PM Luis Carril wrote:
>
> Luis,
>
> It seems you've got enough support for this concept, so let's move
> forward with this patch. There are some comments from Tom about the
> patch; would you like to send an updated version perhaps?
>
> Thanks
>
> Hi,
>
> I've attach
On Tue, Jan 14, 2020 at 4:12 AM Tom Lane wrote:
>
> John Naylor writes:
> > [ v11 patch ]
>
> I pushed this with some small cosmetic adjustments.
Thanks for your help hacking on the token filter.
--
John Naylorhttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, R
On Mon, Jan 13, 2020 at 03:49:40PM -0800, Peter Geoghegan wrote:
On Sat, Jan 11, 2020 at 4:25 AM Tomas Vondra
wrote:
Understood. Is that a reason to not commit of this patch now, though?
It could use some polishing. Are you interested in committing it?
Not really - as a CFM I was trying to
I wrote:
> Peter Eisentraut writes:
>> I have found a weird behavior with identifier quoting, which is not the
>> subject of this patch, but it appears to be affected by it.
> I'll think about how to improve this. Given that we're dequoting
> filenames explicitly anyway, maybe we don't need to
On Tue, Jan 14, 2020 at 10:02 AM Tom Lane wrote:
>
>
> Grepping for other direct uses of unicode_to_utf8(), I notice that
> there are a couple of places in the JSON code where we have a similar
> restriction that you can only write a Unicode escape in UTF8 server
> encoding. I'm not sure whether
Andrew Dunstan writes:
> On Tue, Jan 14, 2020 at 10:02 AM Tom Lane wrote:
>> Grepping for other direct uses of unicode_to_utf8(), I notice that
>> there are a couple of places in the JSON code where we have a similar
>> restriction that you can only write a Unicode escape in UTF8 server
>> encodi
Hi Daniel,
I agree with you if psql output doesn't indicate any error when the disk is
full, then it is obviously not nice. In some situations, people may end up lost
data permanently.
However, after I quickly applied your idea/patch to "commit
bf65f3c8871bcc95a3b4d5bcb5409d3df05c8273 (HEAD ->
Updated patch is attached. It contains more comments as well as commit message.
On Sun, Jan 12, 2020 at 12:10 AM Alexander Korotkov
wrote:
> On Sat, Jan 11, 2020 at 3:19 PM Julien Rouhaud wrote:
> > While at it, IIUC only excludeOnly key can have nrequired == 0 (if
> > that's the case, this cou
This is a new complete workable patch after a long time of struggling
with benchmarking.
At Tue, 19 Nov 2019 19:48:10 +0900 (JST), Kyotaro Horiguchi
wrote in
> I ran the run2.sh script attached, which runs catcachebench2(), which
> asks SearchSysCache3() for cached entries (almost) 24 times
Hi all,
(Daniel G. in CC.)
As discussed on the thread to be able to set the min/max SSL protocols
with libpq, when mixing incorrect bounds the user experience is not
that good:
https://www.postgresql.org/message-id/9cfa34ee-f670-419d-b92c-cb7943a27...@yesql.se
It happens that the error generated
On Sun, Jan 12, 2020 at 8:18 AM Amit Kapila wrote:
>
> On Sat, Jan 11, 2020 at 11:16 AM Tom Lane wrote:
> >
>
> > * The seeming bug in v10 suggests that we aren't testing large enough
> > logical-decoding cases, or at least aren't noticing leaks in that
> > area. I'm not sure what a good design
On Mon, 13 Jan 2020 at 12:50, Amit Kapila wrote:
>
> On Sat, Jan 11, 2020 at 7:48 PM Masahiko Sawada
> wrote:
> >
> > On Sat, 11 Jan 2020 at 13:18, Amit Kapila wrote:
> > >
> > > On Sat, Jan 11, 2020 at 9:23 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Fri, 10 Jan 2020 at 20:54, Mahendra
On Tue, 14 Jan 2020 at 03:20, Mahendra Singh Thalor wrote:
>
> On Fri, 10 Jan 2020 at 15:51, Sergei Kornilov wrote:
> >
> > Hi
> > Thank you for update! I looked again
> >
> > (vacuum_indexes_leader)
> > + /* Skip the indexes that can be processed by parallel
> > workers */
> > +
Hi Peter! Sorry for answering so long.
> 11 янв. 2020 г., в 7:49, Peter Geoghegan написал(а):
>
> I'm curious why Andrey's corruption problems were not detected by the
> cross-page amcheck test, though. We compare the first non-pivot tuple
> on the right sibling leaf page with the last one on th
On Mon, Jan 13, 2020 at 3:18 PM Dilip Kumar wrote:
>
> On Thu, Jan 9, 2020 at 12:09 PM Amit Kapila wrote:
> >
> > On Thu, Jan 9, 2020 at 10:30 AM Dilip Kumar wrote:
> > >
> > > On Thu, Jan 9, 2020 at 9:35 AM Amit Kapila
> > > wrote:
> > > >
> > > > > The problem is that when we
> > > > > get
On Mon, Jan 13, 2020 at 03:39:32PM +0100, Julien Rouhaud wrote:
> Actually, can't it create a security hazard, for instance if you call
> pg_file_sync() on a heap file and the calls errors out, since it's
> bypassing data_sync_retry?
Are you mistaking security with durability here? By default, th
On Tue, Jan 14, 2020 at 7:18 AM Michael Paquier wrote:
>
> On Mon, Jan 13, 2020 at 03:39:32PM +0100, Julien Rouhaud wrote:
> > Actually, can't it create a security hazard, for instance if you call
> > pg_file_sync() on a heap file and the calls errors out, since it's
> > bypassing data_sync_retry?
On Sat, 11 Jan 2020 at 18:52, Peter Eisentraut
wrote:
>
> On 2020-01-10 04:32, Masahiko Sawada wrote:
> > I agreed that these patches are useful on its own and 0001 patch and
>
> committed 0001
>
> > 0002 patch look good to me. For 0003 patch,
> >
> > + linkend="guc-primary-slot-name"/>. Oth
On Sat, 11 Jan 2020 09:27:58 +0900
nuko yokohama wrote:
> LIMIT clause without ORDER BY should be prohibited when creating
> incremental materialized views.
>
> In SQL, the result of a LIMIT clause without ORDER BY is undefined.
> If the LIMIT clause is allowed when creating an incremental mater
76 matches
Mail list logo
