Re: [PATCH] Sort policies and triggers by table name in pg_dump.

On Tue, Sep 24, 2019 at 08:48:33AM +0100, Benjie Gillam wrote: > Here we create two identically named triggers and two identically > named policies on tables foo and bar. If instead we ran these > statements in a different order (or if the object IDs were to wrap) > the order of the pg_dump would b

Re: [PATCH] Sort policies and triggers by table name in pg_dump.

> Thanks. Perhaps you could add your patch to the next commit fest > then at https://commitfest.postgresql.org/25/? Thanks, submitted.

Re: Index Skip Scan

> On Wed, Sep 25, 2019 at 3:03 AM Kyotaro Horiguchi > wrote: > > At Tue, 24 Sep 2019 09:06:27 -0300, Alvaro Herrera > wrote in <20190924120627.GA12454@alvherre.pgsql> > > On 2019-Sep-24, Kyotaro Horiguchi wrote: > > > > > Sorry, it's not a boolean. A tristate value. From the definition > > > (B

Re: Batch insert in CTAS/MatView code

On Mon, Sep 9, 2019 at 4:02 PM Paul Guo wrote: > > So in theory > we should not worry about additional tuple copy overhead now, and then I tried the patch without setting > multi-insert threshold as attached. > I reviewed your patch today. It looks good overall. My concern is that the ExecFetch

PostgreSQL 12 RC1 Press Release Draft

Hi, Attached is a draft for the PostgreSQL 12 RC1 press release. Please let me know if you find any errors or notable omissions. I'd also like to take this opportunity as a chance to say thank you to everyone for your hard work to get PostgreSQL 12 to this point. I'm personally very excited for w

Re: PostgreSQL 12 RC1 Press Release Draft

The "Upgrading to PostgreSQL 12 RC 1" references v11 rather than v12: "To upgrade to PostgreSQL 11 RC 1 from Beta 4 or an earlier version of PostgreSQL 11, ..." Regards, -- Sehrope Sarkuni Founder & CEO | JackDB, Inc. | https://www.jackdb.com/

Re: row filtering for logical replication

Em seg, 23 de set de 2019 às 01:59, movead li escreveu: > > I find several problems as below when I test the patches: > First of all, thanks for your review. > 1. There be some regression problem after apply 0001.patch~0005.patch >The regression problem is solved in 0006.patch > Which regress

Re: PostgreSQL 12 RC1 Press Release Draft

On 9/25/19 6:50 AM, Sehrope Sarkuni wrote: > The "Upgrading to PostgreSQL 12 RC 1" references v11 rather than v12: > > "To upgrade to PostgreSQL 11 RC 1 from Beta 4 or an earlier version of > PostgreSQL 11, ..." Thanks! Fixed attached, Jonathan PostgreSQL 12 RC 1 Released ===

Re: Zedstore - compressed in-core columnar storage

Hi Alexandra, On Tue, Sep 17, 2019 at 4:45 PM Ashutosh Sharma wrote: > > On Thu, Aug 29, 2019 at 5:39 PM Heikki Linnakangas wrote: > > > > On 29/08/2019 14:30, Ashutosh Sharma wrote: > > > > > > On Wed, Aug 28, 2019 at 5:30 AM Alexandra Wang > > > wrote: > > Further, t

Re: Cache lookup errors with functions manipulation object addresses

On 2019-Sep-25, Michael Paquier wrote: > On Tue, Sep 24, 2019 at 03:25:08PM +0900, Kyotaro Horiguchi wrote: > > In 0003, empty string and NULL are not digtinguishable in psql > > text output. It'd be better that the regression test checks that > > the return is actually NULL using "is NULL" or "\p

Re: PostgreSQL 12 RC1 Press Release Draft

On 2019-09-25 13:08, Jonathan S. Katz wrote: On 9/25/19 6:50 AM, Sehrope Sarkuni wrote: The "Upgrading to PostgreSQL 12 RC 1" references v11 rather than v12: "To upgrade to PostgreSQL 11 RC 1 from Beta 4 or an earlier version of PostgreSQL 11, ..." A small typo (or processing hickup): 'patte

Re: Cache lookup errors with functions manipulation object addresses

On 2019-Sep-24, Michael Paquier wrote: > + * - FORMAT_TYPE_FORCE_NULL > + * if the type OID is invalid or unknown, return NULL > instead of ??? > + * or such I think FORCE_NULL is a strange name for this flag (and its two siblings); I think something like FORM

Re: backup manifests

On Sat, Sep 21, 2019 at 12:25 AM Robert Haas wrote: > Some comments: Manifest file will be in plain text format even if compression is specified, should we compress it? May be this is intended, just raised the point to make sure that it is intended. +static void +ReceiveBackupManifestChunk(size_t

Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions

On Tue, Sep 3, 2019 at 4:30 AM Alvaro Herrera wrote: > > In the interest of moving things forward, how far are we from making > 0001 committable? If I understand correctly, the rest of this patchset > depends on https://commitfest.postgresql.org/24/944/ which seems to be > moving at a glacial pac

Proposal for syntax to support creation of partition tables when creating parent table

Hi Hackers, I want to propose an extension to CREATE TABLE syntax to allow the creation of partition tables along with its parent table using a single statement. In this proposal, I am proposing to specify the list of partitioned tables after the PARTITION BY clause. CREATE TABLE table_name (..)

Re: JSONPATH documentation

On 9/25/19 12:08 AM, Peter Eisentraut wrote: On 2019-09-23 00:03, Tom Lane wrote: While we're whining about this, I find it very off-putting that the jsonpath stuff was inserted in the JSON functions section ahead of the actual JSON functions. I think it should have gone after them, because it

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

24.09.2019 3:13, Peter Geoghegan wrote: On Wed, Sep 18, 2019 at 7:25 PM Peter Geoghegan wrote: I attach version 16. This revision merges your recent work on WAL logging with my recent work on simplifying _bt_dedup_one_page(). See my e-mail from earlier today for details. I attach version 17. T

Re: Proposal for syntax to support creation of partition tables when creating parent table

Hello Muhammad, I think that it may be better to have a partition spec which describes not the list of partitions, but what is wanted, letting postgres to do some more work. See this thread: https://www.postgresql.org/message-id/alpine.DEB.2.21.1907150711080.22273@lancre I want to propos

Re: Proposal for syntax to support creation of partition tables when creating parent table

Muhammad Usama writes: > I want to propose an extension to CREATE TABLE syntax to allow the creation > of partition tables along with its parent table using a single statement. TBH, I think this isn't a particularly good idea. It seems very reminiscent of the variant of CREATE SCHEMA that lets y

Re: PATCH: standby crashed when replay block which truncated in standby but failed to truncate in master node

On Tue, Sep 24, 2019 at 10:41 AM Michael Paquier wrote: > > On Mon, Sep 23, 2019 at 01:45:14PM +0200, Tomas Vondra wrote: > > On Mon, Sep 23, 2019 at 03:48:50PM +0800, Thunder wrote: > >> Is this an issue? > >> Can we fix like this? > >> Thanks! > >> > > > > I do think it is a valid issue. No opin

Re: PostgreSQL 12 RC1 Press Release Draft

On 9/25/19 8:21 AM, Erikjan Rijkers wrote: > On 2019-09-25 13:08, Jonathan S. Katz wrote: >> On 9/25/19 6:50 AM, Sehrope Sarkuni wrote: >>> The "Upgrading to PostgreSQL 12 RC 1" references v11 rather than v12: >>> >>> "To upgrade to PostgreSQL 11 RC 1 from Beta 4 or an earlier version of >>> Postgr

Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)

CC Alexey for reasons that become clear below. On 2019-Sep-25, Paul Guo wrote: > > Question about 0003. If we specify --skip-clean-shutdown and the cluter > > was not cleanly shut down, shouldn't we error out instead of trying to > > press on? > > pg_rewind would error out in this case, see san

Re: DROP SUBSCRIPTION with no slot

> On 25 Sep 2019, at 01:22, Jeff Janes wrote: > > There is no HINT in the error message itself, but there is in the > documentation, see note at end of > https://www.postgresql.org/docs/current/sql-dropsubscription.html > . I

Re: DROP SUBSCRIPTION with no slot

On Wed, 25 Sep 2019 at 13:55, Žiga Kranjec wrote: > > Ah. I missed that bit in the documentation! > > Perhaps a publication should remember, whether it actually created a > replication slot and only try to remove it, if it did. Although that > probably wouldn't help much in your case. > What abo

Re: Proposal for syntax to support creation of partition tables when creating parent table

On Wed, Sep 25, 2019 at 8:53 PM Tom Lane wrote: > Muhammad Usama writes: > > I want to propose an extension to CREATE TABLE syntax to allow the > creation > > of partition tables along with its parent table using a single statement. > > TBH, I think this isn't a particularly good idea. It seems

Re: [PATCH][PROPOSAL] Add enum releation option type

On 2019-Sep-17, Alvaro Herrera wrote: > I decided I didn't dislike that patch all that much anyway, so I cleaned > it up a little bit and here's v8. > > The add_enum_reloption stuff is still broken. Please fix it and > resubmit. I'm marking this Waiting on Author now. I finished this and pushe

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

On Wed, Sep 25, 2019 at 8:05 AM Anastasia Lubennikova wrote: > Attached is v18. In this version bt_dedup_one_page() is refactored so that: > - no temp page is used, all updates are applied to the original page. > - each posting tuple wal logged separately. > This also allowed to simplify btree_xlo

Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)

On Wed, 2019-09-25 at 14:48 -0300, Alvaro Herrera wrote: > Another thing in 0002 is that you're adding a "-R" switch to > pg_rewind, but we have another patch in the commitfest using the same > switch for a different purpose. Maybe you guys need to get to an > agreement over who uses the letter :-

Re: Control your disk usage in PG: Introduction to Disk Quota Extension

This patch no longer applies. Can you please rebase? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Support for jsonpath .datetime() method

On Mon, Sep 23, 2019 at 10:05 PM Alexander Korotkov wrote: > I've reordered the patchset. I moved the most debatable patch, which > introduces and RR and changes parsing of YYY, YY and Y to the > end. I think we have enough of time in this release cycle to decide > whether we want this. > >

Re: add a MAC check for TRUNCATE

Hello On 2019-Sep-09, Yuli Khodorkovskiy wrote: > I have included an updated version of the sepgql patch. The > Truncate-Hook patch is unchanged from the last version. This patch no longer applies. Can you please rebase? Joe, do you plan on being committer for this patch? There seems to be su

Re: Allow to_date() and to_timestamp() to accept localized names

This patch no longer applies. Can you please rebase? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Don't codegen deform code for virtual tuples in expr eval for scan fetch

Hi, Thanks for working on this! On 2019-09-17 23:54:51 -0700, Soumyadeep Chakraborty wrote: > This is to address a TODO I found in the JIT expression evaluation > code (opcode = > EEOP_INNER_FETCHSOME/EEOP_OUTER_FETCHSOME/EEOP_SCAN_FETCHSOME): > > * TODO: skip nvalid check if slot is fixed and k

Re: Add FOREIGN to ALTER TABLE in pg_dump

On 2019-Jul-12, Luis Carril wrote: > Hello, > pg_dump creates plain ALTER TABLE statements even if the table is a > foreign table, which for someone reading the dump is confusing. > This also made a difference when applying the dump if there is any plugin > installed that hooks on Proces

Re: [Patch] Add a reset_computed_values function in pg_stat_statements

This patch seems to be failing the contrib build. Please fix. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [HACKERS] Cached plans and statement generalization

This patch fails the "rules" tests. Please fix. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Don't codegen deform code for virtual tuples in expr eval for scan fetch

Hi, On 2019-09-20 22:19:46 -0700, Soumyadeep Chakraborty wrote: > In my previous patch 0001, the resulting opblock consisted of a single > br instruction to it's successor opblock. Such a block represents > unnecessary overhead. Even though such a block would be optimized > away, what if optimizat

Re: WIP: BRIN multi-range indexes

This patch fails to apply (or the opclass params one, maybe). Please update. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Bloom index cost model seems to be wrong

It's not clear to me what the next action should be on this patch. I think Jeff got some feedback from Tom, but was that enough to expect a new version to be posted? That was in February; should we now (in late September) close this as Returned with Feedback? -- Álvaro Herreraht

Re: Built-in connection pooler

Travis complains that the SGML docs are broken. Please fix. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: CVE-2017-7484-induced bugs, or, btree cmp functions are not leakproof?

Travis complains that this patch adds a new compile warning. Please fix. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Change atoi to strtol in same place

... can we have a new patch? Not only because there seems to have been some discussion points that have gone unaddressed (?), but also because Appveyor complains really badly about this one. https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.58672 -- Álvaro Herrera

Re: [HACKERS] Custom compression methods

The compile of this one has been broken for a long time. Is there a rebase happening? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [HACKERS] [PATCH] Generic type subscripting

This broke recently. Can you please rebase again? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Standby accepts recovery_target_timeline setting?

While testing against PG12 I noticed the documentation states that recovery targets are not valid when standby.signal is present. But surely the exception is recovery_target_timeline? My testing confirms that this works just as in prior versions with standy_mode=on. Documentation patch is attach

Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)

On 2019-09-25 20:48, Alvaro Herrera wrote: CC Alexey for reasons that become clear below. Another thing in 0002 is that you're adding a "-R" switch to pg_rewind, but we have another patch in the commitfest using the same switch for a different purpose. Maybe you guys need to get to an agreement

Re: Global shared meta cache

The last patch we got here (a prototype) was almost a year ago. There was substantial discussion about it, but no new version of the patch has been posted. Are we getting a proper patch soon, or did we give up on the approach entirely? -- Álvaro Herrerahttps://www.2ndQuadrant.co

Re: Global temporary tables

This broke recently. Can you please rebase? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [PATCH] ltree, lquery, and ltxtquery binary protocol support

Hello, can you please post an updated version of this patch? Note that Travis has a small complaint: gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precisi

Re: NOT IN subquery optimization

On 2019-Aug-02, Thomas Munro wrote: > Hi Zheng, Jim, > > With my Commitfest doozer hat on, I have moved this entry to the > September 'fest. I noticed in passing that it needs to be adjusted > for the new pg_list.h API. It'd be good to get some feedback from > reviewers on these two competing p

Re: Optimize partial TOAST decompression

Hello, can you please update this patch? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [proposal] de-TOAST'ing using a iterator

> On Sep 23, 2019, at 9:45 AM, Alvaro Herrera wrote: > > Paul Ramsey, do you have opinions to share about this patch? I think > PostGIS might benefit from it. Thread starts here: I like the idea a great deal, but actually PostGIS is probably neutral on it: we generally want to retrieve thi

Re: benchmarking Flex practices

... it seems this patch needs attention, but I'm not sure from whom. The tests don't pass whenever the server encoding is not UTF8, so I suppose we should either have an alternate expected output file to account for that, or the tests should be removed. But anyway the code needs to be reviewed. -

Re: add a MAC check for TRUNCATE

On 9/25/19 3:56 PM, Alvaro Herrera wrote: > Hello > > On 2019-Sep-09, Yuli Khodorkovskiy wrote: > >> I have included an updated version of the sepgql patch. The >> Truncate-Hook patch is unchanged from the last version. > > This patch no longer applies. Can you please rebase? > > Joe, do you p

Re: Refactoring of connection with password prompt loop for frontends

This patch has been absolutely overlooked by reviewers. Euler, you're registered as a reviewer for it. Will you submit a review soon? :-) It does not currently apply, so if we get a rebase, that'd be good too. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Developmen

Re: heapam_index_build_range_scan's anyvisible

On 2019-Jul-30, Ashwin Agrawal wrote: > On Tue, Jul 16, 2019 at 10:22 AM Andres Freund wrote: > > Looks good to me. Planning to apply this unless somebody wants to argue > > against it soon? > > Andres, I didn't yet register this for next commitfest. If its going in > soon anyways will not do i

Re: Resume vacuum and autovacuum from interruption and cancellation

Apparently this patch now has a duplicate OID. Please do use random OIDs >8000 as suggested by the unused_oids script. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: SQL/JSON: functions

This has recently been broken -- please rebase. (JSON_TABLE likewise). -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Copy data to DSA area

Should now this be closed as Returned with Feedback, or are we really waiting on an updated patch in the short term? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: shared-memory based stats collector

On 2019-Sep-10, Kyotaro Horiguchi wrote: > At Tue, 3 Sep 2019 18:28:05 -0400, Alvaro Herrera > wrote in <20190903222805.GA13932@alvherre.pgsql> > > > Found a bug in initialization. StatsShememInit() was placed at a > > > wrong place and stats code on child processes accessed > > > uninitialized

Re: benchmarking Flex practices

Alvaro Herrera writes: > ... it seems this patch needs attention, but I'm not sure from whom. > The tests don't pass whenever the server encoding is not UTF8, so I > suppose we should either have an alternate expected output file to > account for that, or the tests should be removed. But anyway t

Re: Speed up transaction completion faster after many relations are accessed in a transaction

On 2019-Sep-03, Tsunakawa, Takayuki wrote: > From: Alvaro Herrera [mailto:alvhe...@2ndquadrant.com] > > Hmm ... is this patch rejected, or is somebody still trying to get it to > > committable state? David, you're listed as committer. > > I don't think it's rejected. It would be a pity (mottain

Re: DROP SUBSCRIPTION with no slot

Hi, On 25/09/2019 01:07, Jeff Janes wrote: On Tue, Sep 24, 2019 at 5:25 PM Peter Eisentraut > wrote: On 2019-09-24 16:31, Jeff Janes wrote: > I recently had to cut loose (pg_drop_replication_slot) a logical replica > that couldn't keep

Re: pglz performance

Hi, On 05/08/2019 09:26, Andres Freund wrote: Hi, On 2019-08-05 00:19:28 +0200, Petr Jelinek wrote: It carries that information inside the compressed value, like I said in the other reply, that's why the extra byte. I'm not convinced that that is a good plan - imo the reference to the compre

Re: add a MAC check for TRUNCATE

On Wed, Sep 25, 2019 at 3:57 PM Alvaro Herrera wrote: > > Hello > > On 2019-Sep-09, Yuli Khodorkovskiy wrote: > > > I have included an updated version of the sepgql patch. The > > Truncate-Hook patch is unchanged from the last version. > > This patch no longer applies. Can you please rebase? Hi

Re: add a MAC check for TRUNCATE

On 2019-Sep-25, Yuli Khodorkovskiy wrote: > Hi Alvaro, > > I have attached the updated patches which should rebase. Great, thanks. > Since all existing DAC checks should have MAC, should these patches be > considered a bug fix and therefore back patched? I don't know the answer to that. My im

Re: add a MAC check for TRUNCATE

Alvaro Herrera writes: > On 2019-Sep-25, Yuli Khodorkovskiy wrote: >> Since all existing DAC checks should have MAC, should these patches be >> considered a bug fix and therefore back patched? > I don't know the answer to that. My impression from earlier discussion > is that this was seen as a n

Re: row filtering for logical replication

Em qua, 25 de set de 2019 às 08:08, Euler Taveira escreveu: > > I'll send a patchset later today. > ... and it is attached. -- Euler Taveira Timbira - http://www.timbira.com.br/ PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento From b5d

Re: CVE-2017-7484-induced bugs, or, btree cmp functions are not leakproof?

On Thu, Sep 26, 2019 at 5:15 AM Alvaro Herrera wrote: > Travis complains that this patch adds a new compile warning. Please > fix. Thanks, updated patch attached. Regards, Amit v6-0001-Use-root-parent-s-permissions-when-reading-child-.patch Description: Binary data

Re: Re: row filtering for logical replication

>Which regression? Apply the 0001.patch~0005.patch and then do a 'make check', then there be a failed item. And when you apply the 0006.patch, the failed item disappeared. >There should be an error because you don't have a PK or REPLICA IDENTITY. No. I have done the 'ALTER TABLE cities REPLICA I

A comment fix in xlogreader.c

While rechecking another patch, I found that 709d003fbd forgot to edit a comment mentioning three members removed from XLogReaderState. See the attached. regards. -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/trans

Re: A comment fix in xlogreader.c

On Thu, Sep 26, 2019 at 11:08:09AM +0900, Kyotaro Horiguchi wrote: > While rechecking another patch, I found that 709d003fbd forgot to > edit a comment mentioning three members removed from > XLogReaderState. > @@ -103,8 +103,7 @@ XLogReaderAllocate(int wal_segment_size, const char *waldir, st

Re: pgbench - allow to create partitioned tables

On Tue, Sep 24, 2019 at 6:59 PM Fabien COELHO wrote: > > > For you or me, it might be okay as we have discussed this case, but it > > won't be apparent to others. This doesn't buy us much, so it is better > > to keep this code consistent with other places that check for > > partitions. > > Attach

Re: PostgreSQL12 and older versions of OpenSSL

On Tue, Sep 24, 2019 at 11:52:48PM +0200, Peter Eisentraut wrote: > That's not actually what this file looks like in the upstream release. > It looks like the packagers must have patched in the protocol codes for > TLS 1.1 and 1.2 themselves. Then they should also add the corresponding > SSL_OP_NO

Re: partition routing layering in nodeModifyTable.c

On Wed, Sep 4, 2019 at 10:45 AM Amit Langote wrote: > On Fri, Aug 9, 2019 at 10:51 AM Amit Langote wrote: > To avoid losing track of this, I've added this to November CF. > > https://commitfest.postgresql.org/25/2277/ > > Struggled a bit to give a title to the entry though. Noticed that one of t

Re: Don't codegen deform code for virtual tuples in expr eval for scan fetch

Hello Andres, Thank you very much for reviewing my patch! On Wed, Sep 25, 2019 at 1:02 PM Andres Freund wrote: > IOW, wherever ExecComputeSlotInfo() is called, we should only actually > push the expression step, when ExecComputeSlotInfo does not determine > that a) the slot is virtual, b) and fi

Re: Don't codegen deform code for virtual tuples in expr eval for scan fetch

Hi Andres, Thank you for your insight and the link offered just the context I needed! On Wed, Sep 25, 2019 at 1:06 PM Andres Freund wrote: > > I'm doubtful this is worth the complexity - and not that we already have > plenty other places with zero length blocks. Agreed. On Wed, Sep 25, 2019 a

Re: heapam_index_build_range_scan's anyvisible

On Wed, Sep 25, 2019 at 1:52 PM Alvaro Herrera wrote: > Sounds OK ... except that Travis points out that Ashwin forgot to patch > contrib: > > make[4]: Entering directory > '/home/travis/build/postgresql-cfbot/postgresql/contrib/amcheck' > gcc -Wall -Wmissing-prototypes -Wpointer-arith > -Wdeclar

Re: PostgreSQL12 and older versions of OpenSSL

On Tue, Sep 24, 2019 at 12:43:17PM -0400, Tom Lane wrote: > One thing I'm wondering is if it's safe to assume that TLS_MAX_VERSION > will be defined whenever these other symbols are. Looking in an > 0.9.8x install tree, that doesn't seem to define any of them; while > in 1.0.1e I see Yeah, I coul

Re: PostgreSQL12 and older versions of OpenSSL

Michael Paquier writes: > Now that I think about it, another method would be to rely on the fact > that a given version of OpenSSL does not support TLS 1.1 and 1.2. So > we could also just add checks based on OPENSSL_VERSION_NUMBER and be > done with it. No, that way madness lies. We *know* tha

Add comments for a postgres program in bootstrap mode

Hi, I have just started to read the PostgreSQL code and found a lack of comments for a postgres backend program in bootstrap mode. When I saw the --boot option implemented in src/backend/main/main.c at first time, I did not understand why the --boot option is not documented and what it is used for

Re: pgbench - allow to create partitioned tables

Okay, I think making the check consistent is a step forward. The latest patch is not compiling for me. Argh, shame on me! [...] We don't recommend to start messages with a capital letter. See "Upper Case vs. Lower Case" section in docs [1]. It is not that we have not used it anywhere els

Re: Cache lookup errors with functions manipulation object addresses

On Wed, Sep 25, 2019 at 09:21:03AM -0300, Alvaro Herrera wrote: > On 2019-Sep-24, Michael Paquier wrote: >> + * - FORMAT_TYPE_FORCE_NULL >> + *if the type OID is invalid or unknown, return NULL instead of ??? >> + *or such > > I think FORCE_NULL is a strange name for this flag (and its two

Re: PostgreSQL12 and older versions of OpenSSL

On Thu, Sep 26, 2019 at 02:03:12AM -0400, Tom Lane wrote: > What I'm concerned about at the moment is Peter's comment upthread > that what we seem to be dealing with here is a broken vendor patch, > not any officially-released OpenSSL version at all. Is it our job > to work around that situation,