Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > ... it seems this patch needs attention, but I'm not sure from whom. > The tests don't pass whenever the server encoding is not UTF8, so I > suppose we should either have an alternate expected output file to > account for that, or the tests should be removed. But anyway the code > needs to be reviewed.
Yeah, I'm overdue to review it, but other things have taken precedence. The unportable test is not a problem at this point, since the patch isn't finished anyway. I'm not sure yet whether it'd be worth preserving that test case in the final version. regards, tom lane