Re: Reporting script runtimes in pg_regress

On 10/02/2019 22:55, Tom Lane wrote: > Daniel Gustafsson writes: >>> On 10 Feb 2019, at 04:50, Tom Lane wrote: >>> Does anyone else feel that this is interesting/useful data? > >> Absolutely, +1 on this. In Greenplum we print the runtime of the script and >> the runtime of the diff, both of whi

Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

Hi! On 09.02.2019 14:31, Andrey Borodin wrote: Here's a typo in postgreslq.conf + fprintf(stderr, _("%s: option -r/--use-postgresql-conf is specified, but postgreslq.conf is absent in the target directory\n"), Fixed, thanks. I do not attach new version of the patch for j

Re: [PROPOSAL]a new data type 'bytea' for ECPG

Matsumura-san, > I remove it and attach a new patch. Please review it. > I feel sorry for asking you to reveiw without contribution. Don't worry. There is one thing that I don't understand right now. YOu change ecpg_store_input() to handle the bytea data type, yet you also change ECPGset_desc() t

Re: ON SELECT rule on a table without columns

On Sat, Feb 9, 2019 at 12:20 AM Ashutosh Sharma wrote: > > On Fri, Feb 8, 2019 at 11:32 PM Tom Lane wrote: > > > > Ashutosh Sharma writes: > > > Attached is the patch that allows us to create view on a table without > > > columns. I've also added some test-cases for it in create_view.sql. > > >

Re: ON SELECT rule on a table without columns

Hi, On 2019-02-11 15:39:03 +0530, Ashutosh Sharma wrote: > Andres, Tom, Please have a look into the attached patch and let me > know if I'm still missing something. Thank you. > --- a/src/test/regress/expected/create_view.out > +++ b/src/test/regress/expected/create_view.out > @@ -1706,9 +1706,16

Re: [HACKERS] Unportable implementation of background worker start

Hi, On 2017-04-26 11:42:38 -0400, Tom Lane wrote: > 3. Go ahead with converting the postmaster to use WaitEventSet, a la > the draft patch I posted earlier. I'd be happy to do this if we were > at the start of a devel cycle, but right now seems a bit late --- not > to mention that we really need

Re: Why don't we have a small reserved OID range for patch revisions?

On 2/8/19, Tom Lane wrote: > A script such as you suggest might be a good way to reduce the temptation > to get lazy at the last minute. Now that the catalog data is pretty > machine-readable, I suspect it wouldn't be very hard --- though I'm > not volunteering either. I'm envisioning something

Re: ON SELECT rule on a table without columns

Thanks Andres for the quick review. On Mon, Feb 11, 2019 at 3:52 PM Andres Freund wrote: > > Hi, > > On 2019-02-11 15:39:03 +0530, Ashutosh Sharma wrote: > > Andres, Tom, Please have a look into the attached patch and let me > > know if I'm still missing something. Thank you. > > > --- a/src/test

Re: [PATCH v20] GSSAPI encryption support

Greetings Robbie, * Robbie Harwood (rharw...@redhat.com) wrote: > Attached please find version 20 of the GSSAPI encryption support. This > has been rebased onto master (thanks Stephen for calling out ab69ea9). > Other changes since v19 from Stephen's review: > > - About 100 lines of new comments

Re: Add missing CREATE TABLE IF NOT EXISTS table_name AS EXECUTE query;

On Thu, Feb 07, 2019 at 10:31:35AM +0900, Michael Paquier wrote: > I'd like to get that addressed before working on the other item > reshuffling the CTAS relation creation. Let's wait for a couple of > days and see if folks have objections, and then revisit it at the > beginning of next week. CTA

Re: [WIP] CREATE SUBSCRIPTION with FOR TABLES clause (table filter)

Hi! Thanks for comments 1. fixed 2. in non-superuser we have to use authorization, and FOR table clause, i don't known how merge both files. 3. fixed 4. fixed and run pgindent 5. add some new cases in regression test Efimkin Evgeny diff --git a/doc/src/sgml/logical-replication.sgml b/doc

Re: Reporting script runtimes in pg_regress

Peter Eisentraut writes: > Now that I see this in action, it makes the actual test results harder > to identify flying by. I understand the desire to collect this timing > data, but that is a special use case and not relevant to the normal use > of the test suite, which is to see whether the test

Logical replication and restore from pg_basebackup

What is the scope of logical replication if I cannot make recovery from pg_basebackup? in this example: https://gist.github.com/vadv/e55fca418d6a14da71f01a95da493fae I get logically unsynchronized data at the subscriber and publisher, but I'm not told anything about it in the log. Do I understand

Re: pg11.1: dsa_area could not attach to segment

Hi > Here's confirmed steps to reproduce Wow, i confirm this testcase is reproducible for me. On my 4-core desktop i see "dsa_area could not attach to segment" error after minute or two. On current REL_11_STABLE branch with PANIC level i see this backtrace for failed parallel process: #0 __GI

Re: log bind parameter values on error

This piece in your patch probably doesn't belong: + elog(WARNING, "params->hasTextValues=%d, IsAbortedTransactionBlockState()=%d", + params->hasTextValues && IsAbortedTransactionBlockState()); -- Peter Eisentraut http://

Re: libpq compression

On 11.02.2019 2:36, Andreas Karlsson wrote: I will preface this with that I am not a security guy and that also do not know how the Zstd vompression works, so take any of what I say with a grain of salt. On 2/8/19 8:14 AM, Andres Freund wrote:> I think compression is pretty useful, and I'm

Re: libpq compression

I attach new version of the patch which support choice between different compression algorithms. Right now only zstd and zlib are supported. If postgres is configured with both of them, then zstd will be used. -- Konstantin Knizhnik Postgres Professional: http://www.postgrespro.com The Russian

Re: libpq compression

On Mon, Feb 11, 2019 at 05:56:24PM +0300, Konstantin Knizhnik wrote: > > Also such attack is possible only if session_id can be somehow "guessed". If > it is just big random number, then it is very unlikely that it can be hacked > in in this way. I am not arguing against compression, but this poi

Re: Logical replication and restore from pg_basebackup

At the start of the logical subscriber is not informed that it is connected to the logical replication slot with a non-consistent state. Whether I understood correctly that, postgresql deceives the user and data in logical replication cannot be trusted. 2019-02-11 17:22:20.103 MSK [71156] LOG: da

Re: libpq compression

On 2019-Feb-11, Andreas Karlsson wrote: > Imagine the following query which uses the session ID from the cookie to > check if the logged in user has access to a file. > > SELECT may_download_file(session_id => $1, path => $2); > > When the query with its parameters is compressed the compressed s

Re: libpq compression

On 2019-02-11 12:46:07 -0300, Alvaro Herrera wrote: > On 2019-Feb-11, Andreas Karlsson wrote: > > > Imagine the following query which uses the session ID from the cookie to > > check if the logged in user has access to a file. > > > > SELECT may_download_file(session_id => $1, path => $2); > > >

[PATCH] xlogreader: do not read a file block twice

Hello hackers, Grigory noticed that one of our utilities has very slow performance when xlogreader reads zlib archives. We found out that xlogreader sometimes reads a WAL file block twice. zlib has slow performance when you read an archive not in sequential order. I think reading a block twi

Re: libpq compression

On 11/02/2019 00:36, Andreas Karlsson wrote: >> threat model underlying the attacks on SSL really apply to postgres. > I think only because it is usually harder to intercept traffic between > the application server and the database than between the we bbrowser and > the web server. > > Imagine t

Re: [PATCH] xlogreader: do not read a file block twice

Hm, looks like it could speed up PostgreSQL recovery, but is it safe? On 02/11/2019 07:25 PM, Arthur Zakirov wrote: Hello hackers, Grigory noticed that one of our utilities has very slow performance when xlogreader reads zlib archives. We found out that xlogreader sometimes reads a WAL file

Re: WIP: Avoid creation of the free space map for small tables

On 2/9/19, Amit Kapila wrote: > On Tue, Feb 5, 2019 at 3:25 PM John Naylor > wrote: >> >> On Tue, Feb 5, 2019 at 4:04 AM Amit Kapila >> wrote: > This is certainly a good test w.r.t code coverage of new code, but I > have few comments: > 1. The size of records in test still depends on alignment (

Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance

Hi Andrew and Tom, I considered that option before writing my patch but I refrained for 2 reasons: - There is no consensus about how to name these functions. The standard 8000-2 goes with arsinh, arcosh and artanh, but you will find easily arcsinh, arccosh and arctanh or even argsinh, argcosh a

Re: Too rigorous assert in reorderbuffer.c

On 2019-Feb-07, Arseny Sher wrote: > Alvaro Herrera writes: > > Ah, okay. Does the test still fail when run without the code fix? > > Yes. The problem here is overriding cmax of catalog (pg_attribute in the > test) tuples, so it fails without any data at all. Makes sense. I thought the blank

Re: PG_RE_THROW is mandatory (was Re: jsonpath)

On 2019-Feb-07, Tom Lane wrote: > Alvaro Herrera writes: > > So, > > > "The error recovery code can either do PG_RE_THROW to propagate the > > error outwards, or do a (sub)transaction abort. Failure to do so may > > leave the system in an inconsistent state for further processing." > > WFM. T

Re: BUG #15548: Unaccent does not remove combining diacritical characters

On Sun, 10 Feb 2019 at 15:07, raam narayana wrote: > Hi, > > After the latest commit in master branch, I was trying to test the python > script. Ironically I still see that the output from the script is > completely different from the unaccent.rules file content. Am I missing > anything.My testin

Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)

I've pushed this now. I made one additional change, which was to fix things so that if both an INTERNAL and an EXTENSION dependency exist, the first loop will reliably complain about the EXTENSION dependency. It only takes one more if-test to do that now that we're postponing the error report till

Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)

On Mon, Feb 11, 2019 at 11:46 AM Tom Lane wrote: > I think we're done with this thread, though I still need to look at > the problem I complained of in <26527.1549572...@sss.pgh.pa.us>. Right, we're done with this thread now. Thanks again! -- Peter Geoghegan

Re: Fixing findDependentObjects()'s dependency on scan order (regressions in DROP diagnostic messages)

On 2019-Feb-11, Tom Lane wrote: > I've pushed this now. I made one additional change, which was to fix > things so that if both an INTERNAL and an EXTENSION dependency exist, > the first loop will reliably complain about the EXTENSION dependency. > It only takes one more if-test to do that now th

Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance

On 12/02/2019 06:44, Lætitia Avrot wrote: Hi Andrew and Tom, I considered that option before writing my patch but I refrained for 2 reasons: - There is no consensus about how to name these functions. The standard 8000-2 goes with arsinh, arcosh and artanh,   but you will find easily arcsinh,

Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance

Gavin Flower writes: > On 12/02/2019 06:44, Lætitia Avrot wrote: >> I considered that option before writing my patch but I refrained for 2 >> reasons: >> >> - There is no consensus about how to name these functions. The >> standard 8000-2 goes with arsinh, arcosh and artanh, >>   but you will f

Re: BUG #15548: Unaccent does not remove combining diacritical characters

Hi Hugh, I tested the script in python 2.7 and it works perfect. The problem is in python 3.7(and may be only in windows as you were not getting the issue) and I was getting the following error UnicodeEncodeError: 'charmap' codec can't encode character '\u0100' in position 0: character maps to

Re: Inadequate executor locking of indexes

On Mon, Feb 11, 2019 at 5:32 AM David Rowley wrote: > > On Mon, 11 Feb 2019 at 01:22, Julien Rouhaud wrote: > > The patch is quite straightforward, so I don't have general comments > > on it. However, I think that the idxlockmode initialization is > > problematic: you're using the statement's co

Re: Logical replication and restore from pg_basebackup

On Mon, Feb 11, 2019 at 05:39:49PM +0300, Dmitry Vasiliev wrote: > Do I understand correctly that logical replication and recovery from > pg_basebackup are incompatible things? When using physical streaming replication, it is mandatory to have nodes with a system ID matching, meaning that all node

Re: Make drop database safer

Thanks for the response and inputs. On Sat, Feb 9, 2019 at 4:51 AM Andres Freund wrote: > Hi, > > On 2019-02-08 16:36:13 -0800, Alexandra Wang wrote: > > Current sequence of operations for drop database (dropdb()) > > 1. Start Transaction > > 2. Make catalog changes > > 3. Drop database buffers

Re: pg11.1: dsa_area could not attach to segment

On Tue, Feb 12, 2019 at 1:51 AM Sergei Kornilov wrote: > > Here's confirmed steps to reproduce > > Wow, i confirm this testcase is reproducible for me. On my 4-core desktop i > see "dsa_area could not attach to segment" error after minute or two. Well that's something -- thanks for this report.

Re: pg11.1: dsa_area could not attach to segment

On Tue, Feb 12, 2019 at 10:57 AM Thomas Munro wrote: > bogus shm_open() EEXIST from the OS Strike that particular idea... it'd be the non-DSM_OP_CREATE case, and if the file was somehow bogusly not visible to us we'd get ENOENT and that'd raise an error, and we aren't seeing that. -- Thomas Mun

RE: Protect syscache from bloating with negative cache entries

From: Tomas Vondra > I'm not sure what you mean by "necessary" and "unnecessary" here. What > matters is how often an entry is accessed - if it's accessed often, it makes > sense > to keep it in the cache. Otherwise evict it. Entries not accessed for 5 > minutes are > clearly not accessed very o

Re: proposal: variadic argument support for least, greatest function

The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: not tested Spec compliant: not tested Documentation:not tested The argument for consistency with other functions that are variadic makes

RE: Protect syscache from bloating with negative cache entries

From: Kyotaro HORIGUCHI [mailto:horiguchi.kyot...@lab.ntt.co.jp] > Recuded frequency of dlist_move_tail by taking 1ms interval between two > succesive updates on the same entry let the degradation dissapear. > > patched : 13720 tps (+2%) What do you think contributed to this performance increase

Re: [PATCH v20] GSSAPI encryption support

Stephen Frost writes: > * Robbie Harwood (rharw...@redhat.com) wrote: > >> Attached please find version 20 of the GSSAPI encryption support. >> This has been rebased onto master (thanks Stephen for calling out >> ab69ea9). > > I've looked over this again and have been playing with it off-and-on >

Re: BUG #15629: Typo in Documentation

The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:tested, passed This is a simple documentation change for which I do not see any controve

Re: BUG #15629: Typo in Documentation

hmm, cf app has not seen <5c621f9f.3020...@anastigmatix.net> yet ... changing status back until that happens. The new status of this patch is: Needs review

Re: Reporting script runtimes in pg_regress

On 2019/02/11 23:30, Tom Lane wrote: > Peter Eisentraut writes: >> Now that I see this in action, it makes the actual test results harder >> to identify flying by. I understand the desire to collect this timing >> data, but that is a special use case and not relevant to the normal use >> of the t

Re: Connection slots reserved for replication

On Fri, Feb 08, 2019 at 09:37:40AM +0900, Michael Paquier wrote: > Thanks for the confirmation. I am not planning to finish wrapping > this one today anyway, and next week should be fine. And done. I have done an extra pass on it, reordering a bit parameters and comments, and removed the extra c

Re: [PATCH v20] GSSAPI encryption support

Greetings, * Robbie Harwood (rharw...@redhat.com) wrote: > Stephen Frost writes: > > * Robbie Harwood (rharw...@redhat.com) wrote: > >> Attached please find version 20 of the GSSAPI encryption support. > >> This has been rebased onto master (thanks Stephen for calling out > >> ab69ea9). > > > > I

Re: Protect syscache from bloating with negative cache entries

On 2/12/19 1:49 AM, Tsunakawa, Takayuki wrote: > From: Tomas Vondra >> I'm not sure what you mean by "necessary" and "unnecessary" here. What >> matters is how often an entry is accessed - if it's accessed often, it makes >> sense >> to keep it in the cache. Otherwise evict it. Entries not acc

Re: Reporting script runtimes in pg_regress

On Tue, Feb 12, 2019 at 10:29:40AM +0900, Amit Langote wrote: > On 2019/02/11 23:30, Tom Lane wrote: >> Peter Eisentraut writes: >>> Now that I see this in action, it makes the actual test results harder >>> to identify flying by. I understand the desire to collect this timing >>> data, but that

Re: pg11.1: dsa_area could not attach to segment

On Tue, Feb 12, 2019 at 10:57:51AM +1100, Thomas Munro wrote: > > On current REL_11_STABLE branch with PANIC level i see this backtrace for > > failed parallel process: > > > > #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 > > #1 0x7f3b36983535 in __GI_abort () at

Re: pg11.1: dsa_area could not attach to segment

On Mon, Feb 11, 2019 at 08:14:28PM -0600, Justin Pryzby wrote: > > Can we please see the stderr output of dsa_dump(area), added just > > before the PANIC? Can we see the value of "handle" when the error is > > raised, and the directory listing for /dev/shm (assuming Linux) after > > the crash (may

Re: monitoring CREATE INDEX [CONCURRENTLY]

Hi Rahila, Pavan, Thanks for the review. I incorporated some fixes per your comments. More fixes are needed still. That said, the patch in attachment gives good insight into how I think this should turn out. > > index_build > > --- > OK. > I think the main phases in which index_build f

Re: Connection slots reserved for replication

On Mon, 11 Feb 2019 at 18:39, Michael Paquier wrote: > And done. Michael, I think there's a small problem with the commit. The position of xlrec.max_wal_senders (line 117) should be below max_worker_processes. 112

Re: pg11.1: dsa_area could not attach to segment

On Tue, Feb 12, 2019 at 1:14 PM Justin Pryzby wrote: > On Tue, Feb 12, 2019 at 10:57:51AM +1100, Thomas Munro wrote: > > > On current REL_11_STABLE branch with PANIC level i see this backtrace for > > > failed parallel process: > > > > > > #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/

Re: Connection slots reserved for replication

On Mon, Feb 11, 2019 at 08:57:41PM -0700, Kevin Hale Boyes wrote: > I think there's a small problem with the commit. > The position of xlrec.max_wal_senders (line 117) should be below > max_worker_processes. Fixed, thanks! -- Michael signature.asc Description: PGP signature

Re: BUG #15548: Unaccent does not remove combining diacritical characters

On Tue, Feb 12, 2019 at 02:27:31AM +0530, Ramanarayana wrote: > I tested the script in python 2.7 and it works perfect. The problem is in > python 3.7(and may be only in windows as you were not getting the issue) > and I was getting the following error > > UnicodeEncodeError: 'charmap' codec can't

Re: [PATCH] xlogreader: do not read a file block twice

On Mon, Feb 11, 2019 at 07:32:59PM +0300, Grigory Smolkin wrote: > Hm, looks like it could speed up PostgreSQL recovery, but is it > safe? (Please avoid top-posting.) > On 02/11/2019 07:25 PM, Arthur Zakirov wrote: >> Grigory noticed that one of our utilities has very slow performance when >> xlo

RE: Protect syscache from bloating with negative cache entries

From: Tomas Vondra [mailto:tomas.von...@2ndquadrant.com] > > I meant that the time-based eviction is not very good, because it > > could cause less frequently entries to vanish even when memory is not > > short. Time-based eviction reminds me of Memcached, Redis, DNS, etc. > > that evicts long-liv

Re: Problems with plan estimates in postgres_fdw

(2019/02/08 21:35), Etsuro Fujita wrote: (2019/02/08 2:04), Antonin Houska wrote: * add_foreign_ordered_paths() Exprssion root->upper_targets[UPPERREL_FINAL] is used to access the target. I think create_ordered_paths() should actually set the target so that postgresGetForeignUpperPaths() can s

Re: pg11.1: dsa_area could not attach to segment

On Mon, Feb 11, 2019 at 08:43:14PM -0600, Justin Pryzby wrote: > I have a suspicion that this doesn't happen if > parallel_leader_participation=off. I think this is tentatively confirmed..I ran 20 loops for over 90 minutes with no crash when parallel_leader_participation=off. On enabling parallel

Re: pg11.1: dsa_area could not attach to segment

On Tue, Feb 12, 2019 at 4:01 PM Justin Pryzby wrote: > On Mon, Feb 11, 2019 at 08:43:14PM -0600, Justin Pryzby wrote: > > I have a suspicion that this doesn't happen if > > parallel_leader_participation=off. > > I think this is tentatively confirmed..I ran 20 loops for over 90 minutes with > no cr

Re: pg11.1: dsa_area could not attach to segment

On Tue, Feb 12, 2019 at 4:27 PM Thomas Munro wrote: > On Tue, Feb 12, 2019 at 4:01 PM Justin Pryzby wrote: > > On Mon, Feb 11, 2019 at 08:43:14PM -0600, Justin Pryzby wrote: > > > I have a suspicion that this doesn't happen if > > > parallel_leader_participation=off. > > > > I think this is tenta

Re: First-draft release notes for next week's releases

On Sat, Feb 09, 2019 at 02:26:03PM +0300, Alexander Kuzmenkov wrote: > El 9/2/19 a las 4:19, Tom Lane escribió: > > Please send comments/corrections by Sunday. > > +  tuple deletion WAL record (Stas Kelvish) > > -- a typo in his surname, should be Kelvich. You are right, the commit message i

Speed up transaction completion faster after many relations are accessed in a transaction

Hello, The attached patch speeds up transaction completion when any prior transaction accessed many relations in the same session. The transaction records its own acquired lock information in the LOCALLOCK structure (a pair of lock object and lock mode). It stores LOCALLOCKs in a hash table i

Re: restrict pg_stat_ssl to superuser?

On Thu, Feb 07, 2019 at 09:30:38AM +0100, Peter Eisentraut wrote: > If so, is there anything in that view that should be made available to > non-superusers? If not, then we could perhaps do this via a simple > permission change instead of going the route of blanking out individual > columns. Hm.

pg_basebackup ignores the existing data directory permissions

Hi Hackers, During the testing allow group access permissions on the standby database directory, one of my colleague found the issue, that pg_basebackup doesn't verify whether the existing data directory has the required permissions or not? This issue is not related allow group access permissions.

Re: [HACKERS][PATCH] Applying PMDK to WAL operations for persistent memory

Peter Eisentraut wrote: > I'm concerned with how this would affect the future maintenance of this > code. You are introducing a whole separate code path for PMDK beside > the normal file path (and it doesn't seem very well separated either). > Now everyone who wants to do some surgery in the WAL c

RE: Commit Fest 2019-01 is now closed

From: Chris Travers [mailto:chris.trav...@adjust.com] > On Fri, Feb 8, 2019 at 9:40 AM Tsunakawa, Takayuki > wrote: > I'm sorry if I repeat what someone proposed in the past, but it > would be nice if the CF app could show the number of modified lines (added > + deleted) for each patch, e.g.