I wrote:
> On 11/19/18, Amit Kapila wrote:
> [ abortive states ]
>> I think it might come from any other place between when you set it and
>> before it got cleared (like any intermediate buffer and pin related
>> API's).
>
> Okay, I will look into that.
LockBuffer(), visibilitymap_pin(), and Get
On 2018/11/20 16:50, Michael Paquier wrote:
> Testing the feature, \dP shows all partitioned relations, still does not
> show the relationship when multiple levels are used. Could it make
> sense to also show the direct parent of a partitioned table when
> verbose mode is used?
Yeah. I think it
I noticed some strangeness in the test coverage reporting. For example,
in
https://coverage.postgresql.org/src/backend/access/transam/xlog.c.gcov.html
in the function readRecoveryCommandFile(), most of the branches parsing
the individual recovery options (recovery_target_xid,
recovery_target_time,
Hello.
At Thu, 18 Oct 2018 00:05:15 +0200, Peter Eisentraut
wrote in
<398754d8-6bb5-c5cf-e7b8-22e5f0983...@2ndquadrant.com>
> During discussions of alternative SSL implementations, contrib/sslinfo
> is usually mentioned as something that something needs to be done about.
> I've looked into ada
Re: Tom Lane 2018-10-22 <80020.1540164...@sss.pgh.pa.us>
> * SIGQUIT is a fairly well-known way to get out of an application when all
> else fails. People who aren't familiar with psql's exit commands might
> find it pretty unfriendly of us to block this off.
Fwiw, pgadmin4 is one of those. ^C do
On 2018-11-14 21:02:41 -0800, Andres Freund wrote:
> Hi,
>
> On 2018-11-15 04:57:28 +, Noah Misch wrote:
> > On Wed, Nov 14, 2018 at 12:01:52AM -0800, Andres Freund wrote:
> > > - one pgbench test tested concurrent insertions into a table with
> > > oids, as some sort of stress test for lwlo
I wrote:
> On 11/14/18, Tom Lane wrote:
>> Alvaro Herrera writes:
>>> Maybe time to compile the ecpg test cases during "make check-world"?
>>
>> I'm dubious that the lexer is a significant part of that, though I could
>> be wrong ...
>
> If it were, it'd be much easier to try a Flex flag other t
Hi,
I do have a reproductible crash with mysql_fdw when executing a plpgsql
function. I'm running pg 11.1 with current mysql_fdw, but I had the same crash
with the pg 9.6 and mysql_fdw provided with ubuntu packages.
>From psql side :
server closed the connection unexpectedly
This proba
Hi,
On AIX, since with MMAP we have only 4K pages though we can have 64K pages with
SYSV, we'd like to experiment with SYSV rather than MMAP and measure the impact
to the performance.
Looking at file: src/include/storage/dsm_impl.h , it seemed to me that
replacing the line:
#define DEFAULT_
Yes, I am available to finish this patch.
I’m sorry that I hadn’t updated patch for new commitfest and I grateful
to you for doing it and fixing some issues.
I would like to clarify which commands lack the output of the schema
names? Because I tried to display them for all objects that have a
s
On 2018-Nov-20, s.cherkas...@postgrespro.ru wrote:
> Yes, I am available to finish this patch.
> I’m sorry that I hadn’t updated patch for new commitfest and I grateful to
> you for doing it and fixing some issues.
> I would like to clarify which commands lack the output of the schema names?
> Bec
Hi
út 20. 11. 2018 v 11:09 odesílatel <066ce...@free.fr> napsal:
> Hi,
>
> I do have a reproductible crash with mysql_fdw when executing a plpgsql
> function. I'm running pg 11.1 with current mysql_fdw, but I had the same
> crash with the pg 9.6 and mysql_fdw provided with ubuntu packages.
>
> Fr
В письме от 15 ноября 2018 18:26:43 пользователь Nikita Glukhov написал:
> Attached 2nd version of the patches. Nothing has changed since March,
> this is just a rebased version.
>
> CREATE INDEX syntax and parameters storage method still need discussion.
I've played around a bit with you patch a
On Thu, Nov 15, 2018 at 7:36 PM Masahiko Sawada wrote:
>
> On Mon, Oct 29, 2018 at 6:03 PM Masahiko Sawada wrote:
> >
> > On Mon, Oct 29, 2018 at 10:16 AM Masahiko Sawada
> > wrote:
> > >
> > > On Wed, Oct 24, 2018 at 9:06 AM Masahiko Sawada
> > > wrote:
> > > >
> > > > On Tue, Oct 23, 2018 a
On Tue, Nov 20, 2018 at 11:11 PM REIX, Tony wrote:
> On AIX, since with MMAP we have only 4K pages though we can have 64K pages
> with SYSV, we'd like to experiment with SYSV rather than MMAP and measure the
> impact to the performance.
>
> Looking at file: src/include/storage/dsm_impl.h , it se
Tom>Yes, we need either session open or reconnect it approach to find out
Tom>the whether server is read-write or read-only.
Just in case, pgjdbc has that feature for quite a while, and the behavior
there is to keep the connection until it fails or application decides to
close it.
pgjdbc uses thr
On Tue, 20 Nov 2018 at 06:23, Vladimir Sitnikov
wrote:
> Tom>Yes, we need either session open or reconnect it approach to find out
> Tom>the whether server is read-write or read-only.
>
> Just in case, pgjdbc has that feature for quite a while, and the behavior
> there is to keep the connection u
On 2018-Nov-20, Peter Eisentraut wrote:
> I noticed some strangeness in the test coverage reporting. For example,
> in
> https://coverage.postgresql.org/src/backend/access/transam/xlog.c.gcov.html
> in the function readRecoveryCommandFile(), most of the branches parsing
> the individual recovery
On 16/11/2018 17:28, Jean-Christophe Arnu wrote:
> On the other hand, there's a consensus not to go further than the
> initial patch.
I have committed your original patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Se
Le mar. 20 nov. 2018 à 13:34, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> a écrit :
> On 16/11/2018 17:28, Jean-Christophe Arnu wrote:
> > On the other hand, there's a consensus not to go further than the
> > initial patch.
>
> I have committed your original patch.
>
> Great, thank you Pe
On Tue, Nov 20, 2018 at 1:42 PM John Naylor wrote:
>
> I wrote:
>
> > On 11/19/18, Amit Kapila wrote:
> > [ abortive states ]
> >> I think it might come from any other place between when you set it and
> >> before it got cleared (like any intermediate buffer and pin related
> >> API's).
> >
> > O
On Tue, Nov 20, 2018 at 5:11 AM REIX, Tony wrote:
> On AIX, since with MMAP we have only 4K pages though we can have 64K pages
> with SYSV, we'd like to experiment with SYSV rather than MMAP and measure the
> impact to the performance.
Are you trying to move the main shared memory segment or th
Thanks for the test.
We are wondering how ANALYZE mitigated regression from query "1.sql" and
"4.sql".
We followed this procedure but still observe performance regression:
1) run ANALYZE on used table_name
analyze pg_catalog.pg_ts_parser;
analyze information_schema.column_options;
Ok, I fixed this.
On 2018-11-20 13:41, Alvaro Herrera wrote:
On 2018-Nov-20, s.cherkas...@postgrespro.ru wrote:
Yes, I am available to finish this patch.
I’m sorry that I hadn’t updated patch for new commitfest and I
grateful to
you for doing it and fixing some issues.
I would like to clarif
On Tue, Nov 20, 2018 at 10:08 PM Jung, Jinho wrote:
> We are wondering how ANALYZE mitigated regression from query "1.sql" and
> "4.sql".
>
> We followed this procedure but still observe performance regression:
> 1) run ANALYZE on used table_name
> analyze pg_catalog.pg_ts_parser;
> analy
Hi Robert,
We are trying to understand why pgbench on AIX is slower compared to
Linux/Power on the same HW/Disks.
So, we have yet no idea about what may be the root cause and what should be
changed.
So, changing: dynamic_shared_memory_type = sysvseems to help.
And maybe changing the
Hello Alvaro,
Thanks for the review and improvements.
Attached v4 is a rebase after 409231919443984635b7ae9b7e2e261ab984eb1e
Attached v5. I thought that separating the part that executes the
command was an obvious readability improvement.
Hmm. It is somehow, but the aim of the refactoring
On 2018-Nov-20, s.cherkas...@postgrespro.ru wrote:
> Ok, I fixed this.
Cool. I'm not sure this is a good idea: "c.relname::pg_catalog.regclass"
I would use c.oid::pg_catalog.regclass instead.
But before getting into those details, I think we should discuss the
user interface that this patch is
Hi,
>When gdb will be active, then use command c, and then run query in session.
>gdb should to catch segfault.
Thank you very much. It's been helpfull.
BTW behaviour is strange. When I'm executing following, I do have always a SEGV
:
psql (11.1)
Type "help" for help.
herve=# CREATE OR R
On Sat, Nov 17, 2018 at 5:12 PM Amit Kapila wrote:
>
> On Fri, Nov 16, 2018 at 9:46 AM Dilip Kumar wrote:
> >
> > On Thu, Nov 15, 2018 at 12:14 PM Dilip Kumar wrote:
> > >
> > Updated patch (merged latest code from the zheap main branch [1]).
> >
>
> Review comments:
> --
On 2018-Nov-20, Fabien COELHO wrote:
> Hmm. It is somehow, but the aim of the refactoring is to make *ALL* state
> transitions to happen in doCustom's switch (st->state) and nowhere else,
> which is defeated by creating the separate function.
>
> Although it improves readability at one level, it
On 11/20/18 3:06 PM, 066ce...@free.fr wrote:
Hi,
When gdb will be active, then use command c, and then run query in session. gdb
should to catch segfault.
Thank you very much. It's been helpfull.
BTW behaviour is strange. When I'm executing following, I do have always a SEGV
:
psql (11.1)
Hello,
On 20.11.2018 16:08, s.cherkas...@postgrespro.ru wrote:
Ok, I fixed this.
I looked at the patch. It is in good shape. It compiles and tests are
passed.
I have few a questions related with throwing errors. They might be silly :)
\dAp as well as \dA command throw an error if a server'
On 11/20/18, Andres Freund wrote:
> I'm
> sure we'll find some things to adapt around the margins, but imo the
> patch as a whole looks pretty reasonable.
bki.sgml is now a bit out of date. I've attached a draft fix.
-John Naylor
diff --git a/doc/src/sgml/bki.sgml b/doc/src/sgml/bki.sgml
index 0
On Tue, Nov 20, 2018 at 8:36 AM REIX, Tony wrote:
> We are trying to understand why pgbench on AIX is slower compared to
> Linux/Power on the same HW/Disks.
>
> So, we have yet no idea about what may be the root cause and what should be
> changed.
>
> So, changing: dynamic_shared_memory_type
On Sun, Oct 21, 2018 at 7:21 PM Tom Lane wrote:
> * SIGQUIT is a fairly well-known way to get out of an application when all
> else fails. People who aren't familiar with psql's exit commands might
> find it pretty unfriendly of us to block this off.
Also, sometimes psql gets into a state where
066ce...@free.fr writes:
> What is confusing, is that if I do the same with a pl/pgsql function (see
> below) I can run it 5 times, and the 6th exec hit the same SEGV...
That probably reflects switching from a custom plan to a generic plan
on the sixth execution.
regards,
I didn't quite understand this hunk. Why does it remove the
is_latencies conditional? (The preceding comment shown here should be
updated obviously if this change is correct, but I'm not sure it is.)
Pgbench runs benches a collects performance data about it.
I simplified the code to alway
Alvaro Herrera writes:
> On 2018-Nov-20, Peter Eisentraut wrote:
>> I noticed some strangeness in the test coverage reporting.
> Not sure what to make of this.
What platform and compiler do you run the coverage build on?
(I'm remembering that gcov was pretty nearly entirely broken on
Fedora awh
Robert Haas writes:
> Also, sometimes psql gets into a state where it doesn't respond to ^C,
> but ^\ still kills it. I don't know why that happens, but I've seen
> it repeatedly.
Surely a bug ... please poke into it next time you see it.
regards, tom lane
Hi Robert,
YES ! Reading this file, your suggestion should work ! Thx !
I've rebuilt and run the basic tests. We'll relaunch our tests asap.
Cordialement,
Tony Reix
tony.r...@atos.net
ATOS / Bull SAS
ATOS Expert
IBM Coop Architect & Technical Leader
Office : +33 (0) 4 76 29 72 67
1 rue de Pr
On 2018-Nov-20, Tom Lane wrote:
> Alvaro Herrera writes:
> > On 2018-Nov-20, Peter Eisentraut wrote:
> >> I noticed some strangeness in the test coverage reporting.
>
> > Not sure what to make of this.
>
> What platform and compiler do you run the coverage build on?
>
> (I'm remembering that g
On Mon, Nov 19, 2018 at 3:53 AM 范孝剑(康贤) wrote:
> Hello,
> Can I skip function ResolveRecoveryConflictWithSnapshot if setting
> hot_standby_feedback=on all the time?
> As I know, function ResolveRecoveryConflictWithSnapshot is used for
> resolving conflicts once master cleans dead tuples. But if
On Sun, Oct 14, 2018 at 6:35 PM Tom Lane wrote:
> Andres Freund writes:
> > Does anybody have engineering / architecture level comments about this
> > proposal?
>
> FWIW, I'm -1 on making OIDs be not-magic for SELECT purposes. Yeah, it's
> a wart we wouldn't have if we designed the system today,
Greetings,
* Robert Haas (robertmh...@gmail.com) wrote:
> On Sun, Oct 14, 2018 at 6:35 PM Tom Lane wrote:
> > Andres Freund writes:
> > > Does anybody have engineering / architecture level comments about this
> > > proposal?
> >
> > FWIW, I'm -1 on making OIDs be not-magic for SELECT purposes.
В письме от 10 ноября 2018 09:14:19 пользователь Michael Paquier написал:
> > Nice cleanup. Also, I like the ability to enable/control more types of
> > tests easily from the Makefile. What are the next steps for this
> > patch?
>
> Thanks. It seems to me that a complete review is still in order
On Tue, Nov 20, 2018 at 7:59 PM Tomas Vondra
wrote:
>
> On 11/20/18 3:06 PM, 066ce...@free.fr wrote:
> > Hi,
> >
> >> When gdb will be active, then use command c, and then run query in
> >> session. gdb should to catch segfault.
> >
> > Thank you very much. It's been helpfull.
> >
> > BTW behavio
On Fri, Nov 9, 2018 at 2:02 AM Masahiko Sawada
wrote:
> On Thu, Nov 8, 2018 at 9:30 PM Kyotaro HORIGUCHI
> wrote:
> >
> > Hello.
> >
> > At Wed, 7 Nov 2018 19:31:00 +0900, Masahiko Sawada <
> sawada.m...@gmail.com> wrote in evkgm-56...@mail.gmail.com>
> > > On Tue, Nov 6, 2018 at 9:16 PM Kyotar
On Sun, Nov 4, 2018 at 1:28 AM Michael Paquier wrote:
> On Fri, Nov 02, 2018 at 09:15:36PM +0100, Dmitry Dolgov wrote:
> > Just to make sure, if a duplicated entry will be removed, the patch
> itself
> > will stay or not? I'm asking, because both entries have the same patch
> > referenced, and th
Greetings,
* Magnus Hagander (mag...@hagander.net) wrote:
> On Fri, Nov 9, 2018 at 2:02 AM Masahiko Sawada
> wrote:
> > On the other hand, If we always reserve max_wal_senders slots
> > available slots for normal backend will get decreased in the next
> > release, which require for users to re-co
Magnus Hagander writes:
> I'm trying to figure out where this thread left off :) My understanding of
> the consensus is we don't actually want/need a change in the app, but are
> instead OK with the admin just handling it a somewhat ugly way in the few
> cases where it's necessary?
The original c
On 2018-Nov-20, Tom Lane wrote:
> I think there is a use-case for "Withdrawn", it's more polite than
> "Rejected" ;-). But it's not a very high-priority request.
Certainly not higher than having the dropdown for entry author/reviewer
be sorted alphabetically ... *wink* *wink*
--
Álvaro Herrera
On Fri, Nov 16, 2018 at 5:38 PM Thomas Munro
wrote:
> Or to put it another way, you can't be given a lower sequence number
> than another process that has already written, because that other
> process must have been given a sequence number before it wrote.
OK, that makes sense.
--
Robert Haas
E
Hi,
On 2018-11-20 11:25:22 -0500, Stephen Frost wrote:
> Greetings,
>
> * Robert Haas (robertmh...@gmail.com) wrote:
> > On Sun, Oct 14, 2018 at 6:35 PM Tom Lane wrote:
> > > Andres Freund writes:
> > > > Does anybody have engineering / architecture level comments about this
> > > > proposal?
>
Hi,
On 2018-11-20 21:49:27 +0700, John Naylor wrote:
> On 11/20/18, Andres Freund wrote:
> > I'm
> > sure we'll find some things to adapt around the margins, but imo the
> > patch as a whole looks pretty reasonable.
>
> bki.sgml is now a bit out of date. I've attached a draft fix.
Thanks!
Gree
On Wed, Nov 21, 2018 at 4:37 AM REIX, Tony wrote:
> YES ! Reading this file, your suggestion should work ! Thx !
>
> I've rebuilt and run the basic tests. We'll relaunch our tests asap.
I would be surprised if that makes a difference:
anonymous-mmap-then-fork and SysV shm are just two different w
Hi,
On 2018-11-21 09:00:58 +1300, Thomas Munro wrote:
> On Wed, Nov 21, 2018 at 4:37 AM REIX, Tony wrote:
> > YES ! Reading this file, your suggestion should work ! Thx !
> >
> > I've rebuilt and run the basic tests. We'll relaunch our tests asap.
>
> I would be surprised if that makes a differe
Given that you have addressed all of my feedback and that it's a pretty
low-risk change, I will change the status to "ready for committer".
There are a couple of minor follow-up clarifications inline that relate
mostly
to the questions that I asked in previous emails.
I did have one other questio
On 04/11/2018 04:24, Steve Singer wrote:
> The feature seems useful a lot of application servers are implementing
> minimal TLS protocol versions.
> I don't see a way to restrict libpq to only connect with certain protocol
> versions. Maybe that is a separate patch but it would make this feature
On 20/11/2018 09:31, Kyotaro HORIGUCHI wrote:
> Comparing the two codes in pgstatfuncs.c and sslinfo.c, It seems
> that ssl_client_serial() can be largely simplified using
> be_tls_get_peer_serial(). X509_NAME_to_text() can be simplified
> using X509_NAME_to_cstring(). But this would be another pat
On Wed, Nov 21, 2018 at 9:07 AM Andres Freund wrote:
> On 2018-11-21 09:00:58 +1300, Thomas Munro wrote:
> > On Wed, Nov 21, 2018 at 4:37 AM REIX, Tony wrote:
> > > YES ! Reading this file, your suggestion should work ! Thx !
> > >
> > > I've rebuilt and run the basic tests. We'll relaunch our te
On 2018-Nov-20, Fabien COELHO wrote:
>
> > I didn't quite understand this hunk. Why does it remove the
> > is_latencies conditional? (The preceding comment shown here should be
> > updated obviously if this change is correct, but I'm not sure it is.)
>
> Pgbench runs benches a collects perform
On 2018-Nov-20, Fabien COELHO wrote:
> Hmm. It is somehow, but the aim of the refactoring is to make *ALL* state
> transitions to happen in doCustom's switch (st->state) and nowhere else,
> which is defeated by creating the separate function.
>
> Although it improves readability at one level, it
On Tue, 20 Nov 2018 at 01:47, Tomas Vondra wrote:
> The patch seems fine to me.
Thanks for looking at it.
> It's a bit unfortunate that we simply disable the optimization on
> partitioned tables instead of fixing it somehow, but I guess it's better
> than nothing and no one has a very good idea
(Returning from leave)
On Tue, 20 Nov 2018 at 03:19, Alvaro Herrera wrote:
> Pushed now, thanks.
Many thanks for pushing.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On Fri, 16 Nov 2018 at 11:23, Peter Eisentraut
wrote:
> committed
Thank you.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
On Tue, Nov 20, 2018 at 06:37:36AM +0500, Andrey Lepikhov wrote:
> On 20.11.2018 6:30, Michael Paquier wrote:
>> Yeah, this one is not entirely true now. What about the following
>> instead:
>> - /* Buffer for current ReadRecord result (expandable) */
>> + /*
>> +* Buffer for current ReadR
On Tue, Nov 20, 2018 at 03:30:38PM -0300, Alvaro Herrera wrote:
> On 2018-Nov-20, Tom Lane wrote:
> Certainly not higher than having the dropdown for entry author/reviewer
> be sorted alphabetically ... *wink* *wink*
More *wink* *wink*
--
Michael
signature.asc
Description: PGP signature
Hi,
On 2018-11-20 01:52:27 -0800, Andres Freund wrote:
> I'm pretty happy with the new state. Unless somebody announces they want
> to do a review soon-ish, I'm planning to commit this soon. It's a
> painful set to keep up2date, and it's blocking a few other patches. I'm
> sure we'll find some th
On Tue, Nov 20, 2018 at 07:30:39PM +0300, Nikolay Shaplov wrote:
> Is it ok, if I join the reviewing? I like test, especially TAP one, you know
> ;-)
>
> Since you are much more experienced in postgres then me, I'd try to
> understand how does the patch work, try to use if for writing more TAP
> t
On Wed, Nov 21, 2018 at 1:08 PM Andres Freund wrote:
> Let's see what I broke :/
Per rhinoceros, contrib/sepgsql. This patch fixes the build for me
(on Debian with libselinux1-dev installed), though I don't know how to
test that it works and make check does nothing useful in there.
--
Thomas M
Thanks for looking at this.
On Thu, 15 Nov 2018 at 13:35, Tom Lane wrote:
> * I don't like inserting this as Appendix B, because that means
> renumbering appendixes that have had their same names for a *long*
> time; for instance the release notes have been Appendix E since
> we adopted the moder
Hi Jim Doty san,
Thank you for review! I'm sorry my late reply...
> Initial Pass
>
>
> + Patch applies
> + Patch builds
> + Patch behaves as described in the thread
Thank you for your check.
> When I set a path for `PGLOGDIR` that didn't exist or was not write-able,
> the patch wri
Hi,
On 2018-11-21 14:32:23 +1300, Thomas Munro wrote:
> On Wed, Nov 21, 2018 at 1:08 PM Andres Freund wrote:
> > Let's see what I broke :/
>
> Per rhinoceros, contrib/sepgsql. This patch fixes the build for me
> (on Debian with libselinux1-dev installed)
Thanks. I pushed your fix.
> though I
Hi,
I saw this failure:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2018-11-21%2000%3A51%3A32
I think there may be more than one thing going wrong there, but one
things I noticed was this:
2018-11-20 21:49:50.935 EST [9700:18] LOG: could not rename temporary
statistics
On Wed, Nov 21, 2018 at 5:43 PM Thomas Munro
wrote:
> Googling led me to some recently posted clues on SO and elsewhere
> about a flag FILE_RENAME_FLAG_POSIX_SEMANTICS which can be used with
> SetFileInformationByHandle(), that wasn't mentioned in the earlier
> -hackers threads. I tried it on App
Hello,
Recently I encountered a panic (assert failure) on a cassert enabled build
of Greenplum database (an MPP database based on postgres). The based
postgresql version is 9.4 stable (9.4.19). The panic is not complex. Please
see below for more details. This issue seems to be a bug in postgresql
On 2018/09/26 11:20, amul sul wrote:
Hi all,
Commit[1] has added 64-bit hash functions for core data types and in the same
discussion thread[2] Robert Haas suggested to have the similar extended hash
function for hstore and citext data type. Attaching patch proposes the same.
Regards,
Amul
1]
On Wed, Nov 21, 2018 at 10:34 AM Hironobu SUZUKI wrote:
>
> On 2018/09/26 11:20, amul sul wrote:
> > Hi all,
> >
> > Commit[1] has added 64-bit hash functions for core data types and in the
> > same
> > discussion thread[2] Robert Haas suggested to have the similar extended hash
> > function for
On 2018/11/01 0:29, Euler Taveira wrote:
Em qua, 28 de fev de 2018 às 20:03, Euler Taveira
escreveu:
The attached patches add support for filtering rows in the publisher.
I rebased the patch. I added row filtering for initial
synchronization, pg_dump support and psql support. 0001 removes unu
On Tue, Nov 20, 2018 at 12:07:12PM +0100, Peter Eisentraut wrote:
> I went over the patch and did a bunch of small refinements. I have also
> updated the documentation more extensively. The attached patch is
> committable to me.
Thanks for putting energy into that.
> Recovery is now initiated b
On Wed, Nov 21, 2018 at 12:54:30PM +0800, Paul Guo wrote:
> The panic reason is that since there is just one wal sender and
> WalSndCtl->walsnds[0].state is WALSNDSTATE_STOPPING so syncWalSnd will be
> NULL and that causes assert failure. Latest postgresql code removes the
> Assert code but the rel
On Wed, Nov 21, 2018 at 12:50 AM Alvaro Herrera
wrote:
>
> I noticed some strangeness in the test coverage reporting. For example,
> in
> https://coverage.postgresql.org/src/backend/access/transam/xlog.c.gcov.html
> in the function readRecoveryCommandFile(), most of the branches parsing
> the ind
Hi
just rebase
Regards
Pavel
schema-variables-20181121-01.patch.gz
Description: application/gzip
Hi,
>Seems some basic mistake I think it should as below
>(*param_types)[i] = exprType(param_expr);
>
>After this it works
Seems to work fine from my side.
Thank you very much, it'd painful for me to find the bug, I've been too far
away from C coding for a too long time :-(
--
Hervé LEFEBVRE
85 matches
Mail list logo
