On 2018-Nov-20, s.cherkas...@postgrespro.ru wrote:

> Ok, I fixed this.

Cool.  I'm not sure this is a good idea: "c.relname::pg_catalog.regclass"
I would use c.oid::pg_catalog.regclass instead.

But before getting into those details, I think we should discuss the
user interface that this patch is offering:

\dip [am pattern]
  lists index properties (according to doc patch)
  * OK, but why do we need an AM pattern?  ... reads regress output  ...
    oh, actually it's an index name pattern, not an AM pattern. Please fix docs.

\dicp [idx pattern] [column pattern]
  list index column properties
  * I think the column pattern part is pointless.

\dA{f,p,fo,fp,oc}
  Please explain what these are.

I think this is two patches -- one being the \dip/\dicp part, the other
the \dA additions.  Let's deal with them separately?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Reply via email to