Re: Fix some error handling for read() and errno

On Sat, Jun 23, 2018 at 08:48:03AM +0900, Michael Paquier wrote: > That's exactly why I have started this thread so as both problems are > addressed separately: > https://www.postgresql.org/message-id/20180622061535.gd5...@paquier.xyz > And back-patching the errno patch while only bothering about m

Re: [bug fix] ECPG: freeing memory for pgtypes crashes on Windows

Hello. Thank you for commiting this, Thomas. At Mon, 18 Jun 2018 07:25:13 +, "Tsunakawa, Takayuki" wrote in <0A3221C70F24FB45833433255569204D1FA1BCD9@G01JPEXMBYT05> > > > I want some remedy for older releases. Our customer worked around this > > problem by getting a libpq connection in the

RE: [bug fix] ECPG: freeing memory for pgtypes crashes on Windows

From: Kyotaro HORIGUCHI [mailto:horiguchi.kyot...@lab.ntt.co.jp] > However I also don't see a problem to back-patch it, I don't see > a problem on such difference between versions. Thank you, Horiguchi-san and Robert. > .. Is there any means to find the library version on the > installed environ

Re: [bug fix] ECPG: freeing memory for pgtypes crashes on Windows

At Mon, 25 Jun 2018 08:16:10 +, "Tsunakawa, Takayuki" wrote in <0A3221C70F24FB45833433255569204D1FA241F9@G01JPEXMBYT05> > From: Kyotaro HORIGUCHI [mailto:horiguchi.kyot...@lab.ntt.co.jp] > > However I also don't see a problem to back-patch it, I don't see > > a problem on such difference bet

Re: Incorrect fsync handling in pg_basebackup's tar_finish

On Mon, Jun 25, 2018 at 4:43 AM, Michael Paquier wrote: > Hi all, > > I was just looking at the code of pg_basebackup, and noticed that we > don't actually check if the two last empty blocks of any tar file > produced are correctly fsync'd or not: > @@ -957,7 +957,10 @@ tar_finish(void) > > /* s

Re: pg_verify_checksums review

Hello, There is a similar utility that I wrote that does offline checksum verification as well. https://github.com/google/pg_page_verification This utility includes a verbose option as well as scanning multiple subsequent segment files. Alexis -- Sent from: http://www.postgresql-archive.org/

Re: PATCH: backtraces for error messages

On 25 June 2018 at 14:21, Kyotaro HORIGUCHI wrote: > Hi. > > At Mon, 25 Jun 2018 09:32:36 +0800, Craig Ringer > wrote in gmail.com> > > On 21 June 2018 at 19:09, Kyotaro HORIGUCHI < > horiguchi.kyot...@lab.ntt.co.jp > > > wrote: > > > > I think this for assertion failure is no problem but I'm n

Re: libpq compression

On 18.06.2018 23:34, Robbie Harwood wrote: ### Documentation! You're going to need it. There needs to be enough around for other people to implement the protocol (or if you prefer, enough for us to debug the protocol as it exists). In conjunction with that, please add information on how to

Re: Concurrency bug in UPDATE of partition-key

On 23 June 2018 at 15:46, Amit Kapila wrote: > On Fri, Jun 22, 2018 at 10:25 PM, Amit Khandekar > wrote: >> On 20 June 2018 at 18:54, Amit Kapila wrote: >>> On Tue, Jun 19, 2018 at 9:33 PM, Amit Khandekar >>> wrote: >>> >>> 2. >>> ExecBRDeleteTriggers(..) >>> { >>> .. >>> + /* If requested, p

Re: bug with expression index on partition

On 2018/06/23 6:51, Alvaro Herrera wrote: > On 2018-Jun-21, Amit Langote wrote: > >> explain (costs off) select p from p order by p; >> QUERY PLAN >> --- >> Merge Append >>Sort Key: ((p1.*)::p) >>-> Index Scan using p1_p_idx on p1 >>-

Re: Concurrency bug in UPDATE of partition-key

On Mon, Jun 25, 2018 at 3:06 PM, Amit Khandekar wrote: > On 23 June 2018 at 15:46, Amit Kapila wrote: >>> >> >> Why do you need to update when newslot is NULL? Already *epqslot is >> initialized as NULL in the caller (ExecUpdate). I think we only want >> to update it when trigtuple is not null.

Re: Loaded footgun open_datasync on Windows

On Wed, Jun 20, 2018 at 7:36 PM, Laurenz Albe wrote: > Kuntal Ghosh wrote: > [pg_test_fsync doesn't use pgwin32_open and hence doesn't respect O_DSYNC] >> On Wed, Jun 6, 2018 at 2:39 PM, Amit Kapila wrote: >> > On Wed, Jun 6, 2018 at 10:18 AM, Michael Paquier >> > wrote: >> > > On Wed, Jun 06,

Auto-partitioning in PostgreSQL 10

Hello, I was trying to do auto partitioning in PostgreSQL 10. First of all, I created 2 tables t_dossier_bac_history_insert_table and t_dossier_bac_history_sensor_collections. And then, I created a trigger which would execute a function (which would create my partitions) before inputting data in

Re: Incorrect fsync handling in pg_basebackup's tar_finish

On Mon, Jun 25, 2018 at 2:27 PM, Magnus Hagander wrote: > > > On Mon, Jun 25, 2018 at 4:43 AM, Michael Paquier > wrote: >> >> Hi all, >> >> I was just looking at the code of pg_basebackup, and noticed that we >> don't actually check if the two last empty blocks of any tar file >> produced are cor

Re: PATCH: backtraces for error messages

On Sat, Jun 23, 2018 at 8:22 AM, Craig Ringer wrote: > On 22 June 2018 at 23:26, Korry Douglas > wrote: > >> A few misc comments: >> >> In general, +1. >> >> It might be nice to move the stack trace code into a separate function >> (not static to elog.c) - I have often found it useful to attach

Re: Auto-partitioning in PostgreSQL 10

> On Jun 25, 2018, at 3:00 AM, zafiirah jumeen wrote: > > Hello, > > I was trying to do auto partitioning in PostgreSQL 10. > First of all, I created 2 tables t_dossier_bac_history_insert_table and > t_dossier_bac_history_sensor_collections. > And then, I created a trigger which would execut

Re: Incorrect fsync handling in pg_basebackup's tar_finish

On Mon, Jun 25, 2018 at 05:48:54PM +0530, Kuntal Ghosh wrote: > In the same note, in tar_close(), we fsync on close. We're not > checking the status of fsync there. Should we introduce the same check > there as well? Yes, there is a second one. I just looked at walmethods.c and I did not spot any

Regarding the correct and best way to fetching a tablename in contrib module

Hi folks , I have developed a new data type in PostgreSQL. The handler associated with this data type is written in C language. This handler encrypts the column data. I need help on figuring out how to get the table name when my handler code is called during CRUD and Alter table operations. let m

Re: comma to delimit fractional seconds

p.s.  I've noticed that the error msg for badly formed time strings always says the same thing "at character 13"  no matter how long the time string is. nevermind, user error

Re: Incorrect fsync handling in pg_basebackup's tar_finish

On Mon, Jun 25, 2018 at 6:47 PM, Michael Paquier wrote: > Yes, there is a second one. I just looked at walmethods.c and I did not > spot any other issues. What do you think about the updated version > attached? > -- I've also verified the same. The patch looks good to me. -- Thanks & Regards,

Regarding the correct and best way to fetching a tablename in contrib module

Hi , I have developed a new data type in PostgreSQL. The handler associated with this data type is written in C language. This handler encrypts the column data. I need help on figuring out how to get the table name when my handler code is called during CRUD and Alter table operations. let me ela

Re: Constraint documentation

Thanks! I'll correct the patch ASAP including your modifications. Le sam. 23 juin 2018 à 19:15, Fabien COELHO a écrit : > > Hello lætitia, > > My 0.02 € to try to simplify the suggested documentation. > > > Check constraint were not > > are not > > > designed to enforce business rules across tab

Re: Removing obsolete comment block at the top of nbtsort.c.

On 2018-Jun-24, Peter Geoghegan wrote: > nbtsort.c has a comment block from the Berkeley days that reads: > > * This code is moderately slow (~10% slower) compared to the regular > * btree (insertion) build code on sorted or well-clustered data. On > * random data, however, the insertion build

Re: Using JSONB directly from application

On 06/24/2018 12:42 PM, Tomas Vondra wrote: Sending raw JSONB to Postgres might also be interesting, but I'd start with receiving. Would implementing raw_jsonb be as trivial as it sounds?  What about usages like SELECT raw_jsonb(col3->'foo'); does the subobject returned by '->' share struct

Re: Removing unneeded self joins

David, I tried to implement your suggestions, here are the patches. The first patch mostly moves some code around without changing functionality. It modifies innerrel_is_unique to not only cache the fact that the relation is unique, but also cache the index that guarantees uniqueness. The se

Some pgq table rewrite incompatibility with logical decoding?

I am hoping someone here can shed some light on this issue - I apologize if this isn't the right place to ask this but I'm almost some of you all were involving in pgq's dev and might be able to answer this. We are actually running 2 replication technologies on a few of our dbs, skytools and pglog

Re: Constraint documentation

Hello, Ok, I corrected the patch as suggested. I hope I did it right. Have a nice day, Lætitia Le lun. 25 juin 2018 à 16:02, Lætitia Avrot a écrit : > Thanks! > I'll correct the patch ASAP including your modifications. > > Le sam. 23 juin 2018 à 19:15, Fabien COELHO a > écrit : > >> >> Hello

Re: [PATCH] Include application_name in "connection authorized" log message

Le 21/06/2018 à 16:21, Don Seiler a écrit : On Wed, Jun 20, 2018 at 2:45 PM, Stephen Frost > wrote: diff --git a/src/include/libpq/libpq-be.h b/src/include/libpq/libpq-be.h index 7698cd1f88..088ef346a8 100644 --- a/src/include/libpq/libpq-be.h +++

Re: Loaded footgun open_datasync on Windows

Kuntal Ghosh wrote: > > If I use the three-argument version throughout, which should be no problem, > > PostgreSQL builds just fine with MSVC. > > > > I don't have enough experience on MSVC/Windows to comment on the same. > > > How about checking what the buildfarm thinks about the attached? >

Re: MERGE SQL Statement for PG11

The status of this is quite unclear to me: - There are two email threads and the most recent email is in the original one (https://www.postgresql.org/message-id/flat/canp8+jkitbsrb7otgt9cy2i1obfot36z0xmraqc+xrz8qb0...@mail.gmail.com/); I think the status should be set to "Waiting for Author" but

Re: Some pgq table rewrite incompatibility with logical decoding?

Hi, On 2018-06-25 10:37:18 -0500, Jeremy Finzel wrote: > I am hoping someone here can shed some light on this issue - I apologize if > this isn't the right place to ask this but I'm almost some of you all were > involving in pgq's dev and might be able to answer this. > > We are actually running

Re: MERGE SQL statement for PG12

On 2018-Jun-19, Pavan Deolasee wrote: > Hello, > > I would like to resubmit the MERGE patch for PG12. The past discussions > about the patch can be found here [1] [2]. Hello. A very minor thing, please see commit 15a8f8caad14 and the discussion that led to it. Thanks -- Álvaro Herrera

Re: Some pgq table rewrite incompatibility with logical decoding?

On Mon, Jun 25, 2018 at 12:41 PM, Andres Freund wrote: > Hi, > > On 2018-06-25 10:37:18 -0500, Jeremy Finzel wrote: > > I am hoping someone here can shed some light on this issue - I apologize > if > > this isn't the right place to ask this but I'm almost some of you all > were > > involving in p

Re: [WIP] [B-Tree] Retail IndexTuple deletion

On 23.06.2018 01:14, Peter Geoghegan wrote: On Fri, Jun 22, 2018 at 12:43 PM, Peter Geoghegan wrote: On Fri, Jun 22, 2018 at 4:24 AM, Andrey V. Lepikhov wrote: According to your feedback, i develop second version of the patch. In this version: 1. High-level functions index_beginscan(), ind

Re: Constraint documentation

On 25/06/18 17:45, Lætitia Avrot wrote: > + > + > + Check constraint are not designed to enforce business rules across > tables. > + Avoid using check constraints with function accessing other tables and "with functions" or "with a function". I prefer the former. > + use ins

Re: [PATCH] Include application_name in "connection authorized" log message

On Mon, Jun 25, 2018 at 10:50 AM, Gilles Darold wrote: > I would prefer the following output to conform to elog.c output: > > 2018-06-25 17:32:46.854 CEST [23265] LOG: connection authorized: > user=postgres database=postgres application=[unknown] > Hello Gilles, The different cases were for

Re: [PATCH] Include application_name in "connection authorized" log message

Greetings On Mon, Jun 25, 2018 at 15:57 Don Seiler wrote: > On Mon, Jun 25, 2018 at 10:50 AM, Gilles Darold > wrote: > >> I would prefer the following output to conform to elog.c output: >> >> 2018-06-25 17:32:46.854 CEST [23265] LOG: connection authorized: >> user=postgres database=postgr

Re: [PATCH] Include application_name in "connection authorized" log message

Le 25/06/2018 à 21:57, Don Seiler a écrit : On Mon, Jun 25, 2018 at 10:50 AM, Gilles Darold mailto:gilles.dar...@dalibo.com>> wrote: I would prefer the following output to conform to elog.c output:     2018-06-25 17:32:46.854 CEST [23265] LOG: connection authorized: user=postgres d

Re: [PATCH] Include application_name in "connection authorized" log message

Le 25/06/2018 à 22:32, Stephen Frost a écrit : Greetings On Mon, Jun 25, 2018 at 15:57 Don Seiler > wrote: On Mon, Jun 25, 2018 at 10:50 AM, Gilles Darold mailto:gilles.dar...@dalibo.com>> wrote: I would prefer the following output to conform to elog.c o

Re: Fix slot's xmin advancement and subxact's lost snapshots in decoding.

Hello Firstly -- this is top-notch detective work, kudos and thanks for the patch and test cases. (I verified that both fail before the code fix.) Here's a v3. I applied a lot of makeup in order to try to understand what's going on. I *think* I have a grasp on the original code and your bugfix

Re: Psql patch to show access methods info

On 22.06.2018 16:48, Sergey Cherkashin wrote: Hello! There are command in psql to list access methods, but there are no fast way to look detailed info about them. So here a patch with new commands: Hi! I've done a preliminary in-company review of this patch several times. Here is my review o

Re: Performance regression with PostgreSQL 11 and partitioning

On 2018-Jun-18, David Rowley wrote: > I've attached a patch which cleans up my earlier version and moves the > setup of the append_rel_array into its own function instead of > sneaking code into setup_simple_rel_arrays(). I've also now updated > the comment above find_childrel_appendrelinfo(), whi

Re: Scariest patch tournament, PostgreSQL 11 edition

Hackers, One month of beta testing has flown by, and enough bugs have already been reported that your view of what patches are scariest might have matured. You still have a few days before we close the contest at the end of the month. Let us know what patches you think are scariest: https://

Re: Constraint documentation

On 25/06/18 17:45, Lætitia Avrot wrote: > + > + > + Check constraint are not designed to enforce business rules across tables. > + Avoid using check constraints with function accessing other tables and Subject/verb agreement - either "A check constraint is ..." or "Check constraint

Re: Scariest patch tournament, PostgreSQL 11 edition

On Mon, Jun 25, 2018 at 6:52 PM, Alvaro Herrera wrote: > Hackers, > > One month of beta testing has flown by, and enough bugs have already > been reported that your view of what patches are scariest might have > matured. You still have a few days before we close the contest at the > end of the m

Re: Performance regression with PostgreSQL 11 and partitioning

Alvaro Herrera writes: > On 2018-Jun-18, David Rowley wrote: >> I've attached a patch which cleans up my earlier version and moves the >> setup of the append_rel_array into its own function instead of >> sneaking code into setup_simple_rel_arrays(). I've also now updated >> the comment above find_

Re: Incorrect fsync handling in pg_basebackup's tar_finish

On Mon, Jun 25, 2018 at 07:21:27PM +0530, Kuntal Ghosh wrote: > I've also verified the same. The patch looks good to me. Thanks for confirming. I have pushed the fix down to 10. -- Michael signature.asc Description: PGP signature

automatic restore point

Hi, I'm a newbie to the hackers but I'd like to propose the "automatic restore point" feature. This feature automatically create backup label just before making a huge change to DB. It's useful when this change is accidental case. The following is a description of "automatic restore point". 【Ba

Re: automatic restore point

On Mon, Jun 25, 2018 at 6:17 PM, Yotsunaga, Naoki < yotsunaga.na...@jp.fujitsu.com> wrote: > ​​ > So what do you think about it? Do you think is it useful? > ​The cost/benefit ratio seems low...​ Also, when recovering with the current specification, tables other than the > returned table also re

Re: using expression syntax for partition bounds

Horiguchi-san, Thanks a lot for the review and sorry it took me a while to reply. Thought I'd refresh the patch as it's in the July CF. On 2018/04/24 18:08, Kyotaro HORIGUCHI wrote: > Thanks. I have almost missed this. > > At Mon, 23 Apr 2018 11:44:14 +0900, Amit Langote wrote: >> On 2018/04/23

Re: PATCH: backtraces for error messages

Hello. Thaks for discussing. At Mon, 25 Jun 2018 17:08:41 +0800, Craig Ringer wrote in > On 25 June 2018 at 14:21, Kyotaro HORIGUCHI > > I think it's pretty strongly desirable for PANIC. > > > > Ah, I forgot about that. I agree to that. The cost to collect the > > information is not a problem

Re: automatic restore point

On 25 June 2018 at 21:33, David G. Johnston wrote: > On Mon, Jun 25, 2018 at 6:17 PM, Yotsunaga, Naoki < > yotsunaga.na...@jp.fujitsu.com> wrote: > >> ​​ >> So what do you think about it? Do you think is it useful? >> > ​ > I'd rather spend effort making the initial execution of said commands les

Re: Few cosmetic suggestions for commit 16828d5c (Fast Alter Table Add Column...)

On Fri, Jun 15, 2018 at 9:46 AM, Amit Kapila wrote: > On Fri, Jun 15, 2018 at 12:54 AM, Andrew Dunstan > wrote: >> >> On 06/14/2018 02:01 PM, Alvaro Herrera wrote: >>> >>> We used to use prefixes for common struct members names to help >>> disambiguate across members that would otherwise have ide

Re: automatic restore point

Why not use auto commit off in the session or .psqlrc file or begin and then use rollback? \set AUTOCOMMIT off What would be nice is if a syntax error didn’t abort the transaction when auto commit is off — being a bad typist.

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

Hello. At Fri, 15 Jun 2018 11:19:21 +0530, Ashutosh Bapat wrote in > On Tue, Jun 12, 2018 at 8:49 AM, Kyotaro HORIGUCHI > wrote: > > Thanks for the discussion. > > > > At Thu, 7 Jun 2018 19:16:57 +0530, Ashutosh Bapat > > wrote in > > > >> What's the problem that you faced? > > > > The re

Re: automatic restore point

On Tue, Jun 26, 2018 at 12:04:59AM -0400, Rui DeSousa wrote: > Why not use auto commit off in the session or .psqlrc file or begin and then > use rollback? \set AUTOCOMMIT off > > What would be nice is if a syntax error didn’t abort the transaction when > auto commit is off — being a bad typist

Re: automatic restore point

> On Jun 26, 2018, at 12:37 AM, Justin Pryzby wrote: > > I think you'll get that behavior with ON_ERROR_ROLLBACK. > Awesome. Thanks!

Re: Problem while updating a foreign table pointing to a partitioned table on foreign server

On Tue, Jun 26, 2018 at 9:59 AM, Kyotaro HORIGUCHI wrote: > >> But good thing is because of join and aggregate >> push-down we already have ability to push arbitrary kinds of nodes >> down to the foreign server through the targetlist. We should be able >> to leverage that capability. It looks like

partition tree inspection functions

Hi. As discussed a little while back [1] and also recently mentioned [2], here is a patch that adds a set of functions to inspect the details of a partition tree. There are three functions: pg_partition_parent(regclass) returns regclass pg_partition_root_parent(regclass) returns regclass pg_part

Re: automatic restore point

On Mon, Jun 25, 2018 at 11:01:06PM -0400, Isaac Morland wrote: > I think an optional setting making DELETE and UPDATE without a WHERE clause > illegal would be handy. Obviously this would have to be optional for > backward compatibility. Perhaps even just a GUC setting, with the intent > being that

Re: automatic restore point

On Tue, Jun 26, 2018 at 01:17:31AM +, Yotsunaga, Naoki wrote: > The following is a description of "automatic restore point". > 【Background】 > When DBA's operation failure, for example DBA accidently drop table, > the database is restored from the file system backup and recovered by > using ti

Re: Concurrency bug in UPDATE of partition-key

On 25 June 2018 at 17:20, Amit Kapila wrote: > On Mon, Jun 25, 2018 at 3:06 PM, Amit Khandekar > wrote: >> On 23 June 2018 at 15:46, Amit Kapila wrote: >>> >>> Why do you need to update when newslot is NULL? Already *epqslot is >>> initialized as NULL in the caller (ExecUpdate). I think w

Re: Loaded footgun open_datasync on Windows

On Mon, Jun 25, 2018 at 06:10:21PM +0200, Laurenz Albe wrote: > I have added it to the July commitfest. Have you looked at the possibility of removing the log file constraints in pg_upgrade with the change you are doing here so as things would be more consistent with non-Windows platforms, simplif

Re: Regarding the correct and best way to fetching a tablename in contrib module

On Mon, Jun 25, 2018 at 07:06:06PM +0530, Gaurav Mishra wrote: > here what i expect as a output : > > create extension table_name-extract; > > select extract_tablename(); > > table-name datatype-name > new_table name new > new_table1 name1 new1 > > extract_tablename : this function should giv

"Access privileges" is missing after pg_dumpall

Hi, I have taken pg_dumpall in pg-master and after restoring the dump I am not able to see the "Access privileges" as below: Same is reproducible in back branches as well, is this fine ? CREATE ROLE user1 PASSWORD 'user1' SUPERUSER LOGIN; CREATE DATABASE db1 OWNER=user1; GRANT ALL ON DATABASE db

Global shared meta cache

Hi, hackers! My customer created hundreds of thousands of partition tables and tried to select data from hundreds of applications, which resulted in enormous consumption of memory because it consumed # of backend multiplied by # of local memory (ex. 100 backends X 1GB = 100GB). Relation caches a