Hi Andres,
> First off: This patch has way too many different types of changes as
> part of one huge commit. This needs to be split into several
> pieces. First the cleanups (e.g. the fields -> flag changes), then the
> individual infrastructure pieces (like the twophase.c changes, best
> split in
On Sat, Feb 10, 2018 at 7:19 AM, Tomas Vondra
wrote:
> Hi,
>
> On 02/07/2018 10:24 AM, Pavan Deolasee wrote:
> >
>
>if (startWAL < GetXactWALBytes())
>ereport(ERROR,
>(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> errmsg("cannot write to dat
On Fri, Feb 9, 2018 at 8:06 PM, Robert Haas wrote:
>
>
> On that basis, of the options I listed in
> http://postgr.es/m/CA+TgmoZDL-caukHkWet7sr7sqr0-e2T91+
> devhqen5sfqsm...@mail.gmail.com
> I like #1 least.
>
> I also dislike #4 from that list for the reasons stated there. For
> example, if yo
On Fri, Feb 2, 2018 at 9:07 PM, Robert Haas wrote:
> On Thu, Feb 1, 2018 at 7:21 PM, Simon Riggs wrote:
> > Yes, it would be about 99% of the time.
> >
> > But you have it backwards - we are not assuming that case. That is the
> > only case that has risk - the one where an old WAL record starts
Hello,
On Fri, Feb 09, 2018 at 04:31:14PM +0100, Dmitry Dolgov wrote:
> I went through this thread, and want to summarize a bit:
>
> From what I see this patch addresses most important concerns that were
> mentioned in the thread, i.e. to make `to_timestamp` less confusing and be
> close to Oracl
Hi,
I am getting "ERROR: unexpected expression in subquery output" and
"ERROR: variable not found in subplan target lists" errors, for "FOR
UPDATE" with postgres_fdw. (when set enable_partition_wise_join to true);
Attached patch have queries which are throwing mentioned error on running
make ch
On Fri, Feb 09, 2018 at 05:06:35PM +0900, Kyotaro HORIGUCHI wrote:
> I happend to find that server crashes during regtest when
> DSM_NONE is enforced. The attached patch fixes that.
>
> The cause is the fact that _bt_spools_heapscan runs
> _bt_begin_parallel() even if dynamic_shared_memory_type is
On Fri, Feb 09, 2018 at 05:08:23PM +0900, Kyotaro HORIGUCHI wrote:
> > postgres: max_wal_senders must be less than max_connections
>
> I think that we can safely increase the fallback value to 20 with
> which regtests are known not to fail. I believe that is
> preferable than explicitly reducing m
On 2/11/18 23:14, Andres Freund wrote:
> On 2018-02-11 22:19:30 -0500, Tom Lane wrote:
>> Not sure what to do about it at this point. We could move that field to
>> the end for 10.3, leaving 10.2 as the only ABI-incompatible minor release,
>> but I don't know that that really makes things any bett
Pavel Stehule wrote:
> > I guess -C/--csv could be used, like there already is -H/--html.
> >
>
> I prefer just long option only. Maybe in future we can use short "C" for
> something else better. There is only few free short commands.
Looking at parse_psql_options(), currently psql has 3
On 2/10/18 19:46, Michael Paquier wrote:
> On Fri, Feb 09, 2018 at 08:44:38PM -0500, Peter Eisentraut wrote:
>> Hmm. I think the ldap test suite should be changed to use
>> $node->restart instead of $node->reload, so we can be sure that the
>> various pg_hba.conf lines are actually accepted. It a
Pavel Stehule wrote:
> some like "\pset format csv , header_off
If we did that, we'd need to reconsider the interactions
of this with \t on|off and \pset footer on|off
and how to keep things consistent with the unaligned
format.
I feel like it's not worth the trouble.
We can still add thi
2018-02-12 15:33 GMT+01:00 Daniel Verite :
> Pavel Stehule wrote:
>
> > some like "\pset format csv , header_off
>
> If we did that, we'd need to reconsider the interactions
> of this with \t on|off and \pset footer on|off
> and how to keep things consistent with the unaligned
> format.
>
Thanks for patching. Your points #1, #2 and #4 are OK with me. I'm
thinking about point #3, concerning when-to-dump policy for stats
objects:
Tom Lane wrote:
> 3. pg_dump decides whether to dump a stats object on the basis of whether
> its underlying table is going to be dumped. While that's n
Alvaro Herrera writes:
> Tom Lane wrote:
>> I propose that we should just treat extended stats objects like other
>> generic database objects --- which, in practice, means "dump if the
>> containing schema is getting dumped". We don't exclude views or matviews
>> on the basis of whether their und
Hi,
On 2018-02-12 13:36:16 +0530, Nikhil Sontakke wrote:
> Hi Andres,
>
> > First off: This patch has way too many different types of changes as
> > part of one huge commit. This needs to be split into several
> > pieces. First the cleanups (e.g. the fields -> flag changes), then the
> > individu
On Mon, Feb 12, 2018 at 10:07 AM, Alvaro Herrera
wrote:
> The followup question is what to do for multi-table stats objects. I
> think the options are that it should be dumped if:
>
> 1. any of its tables are dumped
> 2. *all* its tables are dumped
> 3. the schema containing the stats object is d
On 02/11/2018 10:06 PM, Thomas Munro wrote:
> On Mon, Feb 12, 2018 at 12:24 PM, Andrew Dunstan
> wrote:
>> On Mon, Feb 12, 2018 at 9:10 AM, Tom Lane wrote:
>>> Andrew Kane writes:
A better option could be a new "dynamic enum" type, which would have
similar storage requirements as an en
On 2/9/18 09:42, Tom Lane wrote:
> Meh. It doesn't look significantly different to me than the restriction
> that you can't have sub-selects in CHECK expressions, index expressions,
> etc. Obviously we need a clean failure like you get for those cases.
> But otherwise it's an OK restriction that
2018-02-12 18:17 GMT+01:00 Peter Eisentraut <
peter.eisentr...@2ndquadrant.com>:
> On 2/9/18 09:42, Tom Lane wrote:
> > Meh. It doesn't look significantly different to me than the restriction
> > that you can't have sub-selects in CHECK expressions, index expressions,
> > etc. Obviously we need
On Fri, Feb 9, 2018 at 12:06 AM, Kyotaro HORIGUCHI
wrote:
> I happend to find that server crashes during regtest when
> DSM_NONE is enforced. The attached patch fixes that.
>
> The cause is the fact that _bt_spools_heapscan runs
> _bt_begin_parallel() even if dynamic_shared_memory_type is
> DSM_NO
On Mon, Feb 12, 2018 at 8:41 AM, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2/11/18 23:14, Andres Freund wrote:
> > On 2018-02-11 22:19:30 -0500, Tom Lane wrote:
> >> Not sure what to do about it at this point. We could move that field to
> >> the end for 10.3, leaving 10.2
I simplified the patch and for now just allowed one server. Please find the
attached patches, and the commit message.
Thanks,
Satya
-Original Message-
From: Robert Haas
Sent: Monday, November 6, 2017 5:56 AM
To: Craig Ringer
Cc: Satyanarayana Narlapuram ;
PostgreSQL-development
Subj
On Mon, Feb 12, 2018 at 01:04:40PM -0500, Mat Arye wrote:
> On Mon, Feb 12, 2018 at 8:41 AM, Peter Eisentraut <
> peter.eisentr...@2ndquadrant.com> wrote:
>
> > On 2/11/18 23:14, Andres Freund wrote:
> > > On 2018-02-11 22:19:30 -0500, Tom Lane wrote:
> > >> Not sure what to do about it at this po
On 2/1/18 11:33, Pavel Stehule wrote:
> postgres=# \sf test
> ERROR: cache lookup failed for type 0
Here is a patch set that adds procedure support to \ef and \sf.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2/11/18 01:10, Tom Lane wrote:
>> This brings the amount of objects stored in pg_proc to four. Perhaps it
>> would be time to bring more clarity in pg_proc by introducing a prokind
>> column for functions, aggregates, window functions and procedures?
>
> Yeah. I was under the impression that
On Mon, Feb 12, 2018 at 12:26 PM, Peter Geoghegan wrote:
> I think that your patch does the right thing.
> plan_create_index_workers() is supposed to take care of parallel
> safety, and this is a parallel safety issue.
Committed the patch.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.co
Peter Eisentraut writes:
> On 2/11/18 01:10, Tom Lane wrote:
>> Yeah. I was under the impression that Peter was looking into that ...
>> [ digs... ] see
>> https://www.postgresql.org/message-id/80ee1f5c-fa9d-7285-ed07-cff53d4f4...@2ndquadrant.com
> Yeah that's still pending, but there wasn't a w
On Sun, Feb 11, 2018 at 6:52 PM, Thomas Munro
wrote:
> As far as I can see, all the volatile qualifiers in shm_mq.c have been
> redundant since ec9037df263.
That's the commit that added shm_mq.c. ITYM 0709b7ee as you said in
the commit message
--
Robert Haas
EnterpriseDB: http://www.enterp
Peter Eisentraut writes:
> On 2/1/18 11:33, Pavel Stehule wrote:
>> postgres=# \sf test
>> ERROR: cache lookup failed for type 0
> Here is a patch set that adds procedure support to \ef and \sf.
I've not read in detail, but it looks reasonable offhand, modulo
that I still don't like prorettype
On Tue, Feb 13, 2018 at 9:09 AM, Robert Haas wrote:
> On Sun, Feb 11, 2018 at 6:52 PM, Thomas Munro
> wrote:
>> As far as I can see, all the volatile qualifiers in shm_mq.c have been
>> redundant since ec9037df263.
>
> That's the commit that added shm_mq.c. ITYM 0709b7ee as you said in
> the com
Hello,
Thanks, Peter, Jesper, Amit, for reviewing the patch. Replying to
all review comments at once:
Jesper Pedersen wrote:
> Maybe add a test case to indexing.sql that highlights that hash indexes
> doesn't support UNIQUE; although not unique to partitioned indexes.
I'm not sure about this.
So, should we rename the *.sgml files to *.xml, since they are actually
now XML files?
Advantages: better automatic editor integration, better automatic syntax
highlighting (e.g., on GitHub), less confusion in general in the future
And maybe while we're at it, truncate the directory structure
doc
On 2/6/18 12:06, Andres Freund wrote:
> On 2018-02-06 12:01:08 -0500, Peter Eisentraut wrote:
>> On 2/1/18 20:35, Andres Freund wrote:
>>> On February 1, 2018 11:13:06 PM GMT+01:00, Peter Eisentraut
>>> wrote:
Here is a patch to implement that idea. Do you have a way to test it
repeatedl
Peter Eisentraut writes:
> So, should we rename the *.sgml files to *.xml, since they are actually
> now XML files?
At that point, back-patching documentation fixes would become effectively
impossible except through manual intervention in the patching process.
I don't want to go there. The recen
Pavel Stehule writes:
> 2018-02-09 12:02 GMT+01:00 Marko Tiikkaja :
>> This is quite short-sighted. The better way to do this is to complain if
>> the number of expressions is different from the number of target variables
>> (and the target variable is not a record-ish type). There's been at lea
Michael Paquier wrote:
> On Fri, Jan 12, 2018 at 11:01:59AM +0900, Michael Paquier wrote:
> > Thanks Mr. Robot and Thomas for the reminder. Attached is an updated
> > patch set taking care of those warnings, 0002 and 0004 being impacted.
>
> The last patch set has rotten enough for git am to compl
Andres Freund wrote:
> Ugh. I personally would say that's because that commit did stuff that we
> normally trie hard not to do. While ColumnDef at least isn't serialized
> into catalogs, we normally trie hard to break struct layout. Peter,
> shouldn't that field at the very least have been added a
On Mon, Feb 12, 2018 at 04:19:48PM -0500, Tom Lane wrote:
> Peter Eisentraut writes:
> > So, should we rename the *.sgml files to *.xml, since they are actually
> > now XML files?
>
> At that point, back-patching documentation fixes would become effectively
> impossible except through manual inte
On Sat, Feb 10, 2018 at 2:02 PM, Thomas Munro
wrote:
> I agree that it would be nice if the build farm (and my unofficial
> patch tester for that matter) could automatically test the LDAP stuff
> when running on a suitable system, but I think it would need to be
> based not just on ifeq ($(with_l
David Fetter writes:
> On Mon, Feb 12, 2018 at 04:19:48PM -0500, Tom Lane wrote:
>> As I've remarked before, the issue would disappear if we were to
>> back-patch the XML-ization of the documentation. So I'd be fine
>> with this if we did it uniformly in the supported branches. Otherwise
>> I th
On 2/8/18 10:54, amul sul wrote:
> Not really, like ExecUpdate for an update of partition key if delete is failed
> then the further insert will be skipped, but you are correct, it might be more
> tricky than I can think -- there is no guarantee that the next insert
> operation
> which replication
> On Feb 10, 2018, at 7:46 PM, Andrew Kane wrote:
>
> Hi,
>
> I'm hoping to get feedback on an idea for a new data type to allow for
> efficient storage of text values while keeping reads and writes
> user-friendly. Suppose you want to store categorical data like current city
> for users. Th
I wrote:
> I think the issue basically arises from this concern in exec_move_row:
> * NOTE: this code used to demand row->nfields ==
> * HeapTupleHeaderGetNatts(tup->t_data), but that's wrong. The tuple
> * might have more fields than we expected if it's from an
> * inheritanc
Fujita-san,
Thanks for the review.
On 2018/02/09 21:20, Etsuro Fujita wrote:
>>> * Please add a brief decsription about partition_oids to the comments for
>>> this struct.
>>>
>>> @@ -91,6 +91,7 @@ typedef struct PartitionTupleRouting
>>> {
>>> PartitionDispatch *partition_dispatch_info;
>
Thanks everyone for the feedback. The current enum implementation requires
you to create a new type and add labels outside a transaction prior to an
insert.
-- on table creation
CREATE TYPE city AS ENUM ();
CREATE TABLE "users" ("city" city);
-- on insert
ALTER TYPE city ADD VALUE IF NOT EXISTS '
On Wed, Feb 7, 2018 at 7:02 PM, Peter Geoghegan wrote:
> On Wed, Feb 7, 2018 at 4:41 PM, Tom Lane wrote:
>> Peter Geoghegan writes:
>>> It would be nice to get an opinion on this mode_final() + tuplesort
>>> memory lifetime business from you, Tom.
>>
>> I'm fairly sure that that bit in mode_fina
Andrew Kane writes:
> Thanks everyone for the feedback. The current enum implementation requires
> you to create a new type and add labels outside a transaction prior to an
> insert.
Right ...
> Since enums have a fixed number of labels, this type of feature may be
> better off as a property you
On 2018/02/10 23:32, Amit Langote wrote:
> On Sat, Feb 10, 2018 at 10:09 PM, Alvaro Herrera
> wrote:
>> Amit Langote wrote:
>>> On 2018/01/19 23:55, Alvaro Herrera wrote:
Local partitioned indexes
>>
>>> I noticed that the declarative partitioning section in ddl.sgml hasn't
>>> been updated t
Hi,
Attached a patch for fixing $subject.
s/funcion/function/
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_typo_in_origin_c.patch
Description: Binary data
> On Feb 12, 2018, at 5:08 PM, Andrew Kane wrote:
>
> Thanks everyone for the feedback. The current enum implementation requires
> you to create a new type and add labels outside a transaction prior to an
> insert.
>
> -- on table creation
> CREATE TYPE city AS ENUM ();
> CREATE TABLE "users"
> On Feb 12, 2018, at 6:35 PM, Tom Lane wrote:
>
> Andrew Kane writes:
>> Thanks everyone for the feedback. The current enum implementation requires
>> you to create a new type and add labels outside a transaction prior to an
>> insert.
>
> Right ...
>
>> Since enums have a fixed number of la
I would like to see a global setting of some kind that specifies which
extra tests are allowed to be run. This could be a configure argument
or an environment/make variable. Rather than make it a list of tests,
specify which facilities you have available, e.g.,
PG_EXTRA_TEST_FACILTITIES='tcpip o
On Sun, Jan 28, 2018 at 7:28 AM, Amit Kapila wrote:
> On Thu, Jan 25, 2018 at 7:29 PM, Alexander Korotkov
> wrote:
>>> As Shubham seems to be running out of time, I thought of helping him
>>> by looking into the above-suggested idea. I think one way to lock a
>>> particular hash value is we can
On 2/12/18 21:58, Masahiko Sawada wrote:
> Attached a patch for fixing $subject.
>
> s/funcion/function/
fixed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Mon, Feb 12, 2018 at 06:38:36PM -0500, Tom Lane wrote:
> The most practical answer might be to wait a few years till all the live
> branches use XML, and then we can do the renaming in all branches
> trivially. Perhaps finishing the XML conversion in v10 would be cheap
> enough that it'd be wor
> My vote would be to backport the build changes to v10, which should be
> simple enough, and wait for 9.6 to be EOL'd before doing the rename.
Me too. However my concern is the tool chain. Maybe we should notice
packagers to prepare it?
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English:
They'd refer to separate enums.
I originally thought an enum was a good comparison for this feature, but
I'm no longer sure that it is. A text-based ordering would be desired
rather than the label index.
A better comparison may be a two-column lookup table:
-- create
CREATE TABLE cities (id bigs
On Mon, Feb 12, 2018 at 10:22:13PM -0500, Peter Eisentraut wrote:
> I would like to see a global setting of some kind that specifies which
> extra tests are allowed to be run. This could be a configure argument
> or an environment/make variable. Rather than make it a list of tests,
> specify whic
On Tue, Feb 13, 2018 at 12:58:22PM +0900, Tatsuo Ishii wrote:
>> My vote would be to backport the build changes to v10, which should be
>> simple enough, and wait for 9.6 to be EOL'd before doing the rename.
>
> Me too. However my concern is the tool chain. Maybe we should notice
> packagers to pr
It seems to me that heap_lock_updated_tuple_rec can lead to a buffer
refcount leak while locking an updated tuple by an aborted
transaction. In commit - 5c609a74, we have added the code to deal
with aborted transactions as below:
heap_lock_updated_tuple_rec()
{
..
if (PageIsAllVisible(BufferGetP
On Tue, Feb 13, 2018 at 5:25 AM, Peter Eisentraut
wrote:
> On 2/8/18 10:54, amul sul wrote:
>> Not really, like ExecUpdate for an update of partition key if delete is
>> failed
>> then the further insert will be skipped, but you are correct, it might be
>> more
>> tricky than I can think -- ther
On Wed, Feb 7, 2018 at 6:13 PM, amul sul wrote:
> On Tue, Feb 6, 2018 at 7:05 PM, amul sul wrote:
>> On Sun, Feb 4, 2018 at 10:47 AM, Amit Kapila wrote:
>>
>> Yes, you are correct standby stopped with a following error:
>>
>> FATAL: inconsistent page found, rel 1663/13260/16390, forknum 0, blk
Michael Paquier writes:
> On Tue, Feb 13, 2018 at 12:58:22PM +0900, Tatsuo Ishii wrote:
>>> My vote would be to backport the build changes to v10, which should be
>>> simple enough, and wait for 9.6 to be EOL'd before doing the rename.
>> Me too. However my concern is the tool chain. Maybe we sho
Hi,
On 2018-02-12 09:54:29 +1030, Andrew Dunstan wrote:
> The idea is to have an append-only list of labels
> which would not obey transactional semantics, and would thus help us
> avoid the pitfalls of enums - there wouldn't be any rollback of an
> addition.
FWIW, I think we can resolve the issu
On Tue, Feb 13, 2018 at 4:28 PM, Amit Kapila wrote:
> On Sun, Jan 28, 2018 at 7:28 AM, Amit Kapila wrote:
>> On Thu, Jan 25, 2018 at 7:29 PM, Alexander Korotkov
>> wrote:
As Shubham seems to be running out of time, I thought of helping him
by looking into the above-suggested idea. I t
On Tue, Feb 13, 2018 at 11:32 AM, Amit Kapila wrote:
> On Wed, Feb 7, 2018 at 6:13 PM, amul sul wrote:
>> On Tue, Feb 6, 2018 at 7:05 PM, amul sul wrote:
>>> On Sun, Feb 4, 2018 at 10:47 AM, Amit Kapila
>>> wrote:
>>>
>>> Yes, you are correct standby stopped with a following error:
>>>
>>> FA
On Fri, Feb 9, 2018 at 3:54 PM, Andrew Dunstan
wrote:
> On Mon, Feb 5, 2018 at 7:49 AM, Andrew Dunstan
> wrote:
>> On Mon, Feb 5, 2018 at 7:19 AM, Thomas Munro
>> wrote:
>>> On Fri, Jan 26, 2018 at 1:23 PM, Andrew Dunstan
>>> wrote:
Yeah, thanks. revised patch attached
>>>
>>> FYI the iden
68 matches
Mail list logo
