Re: explain analyze output with parallel workers - question about meaning of information for explain.depesz.com

On Sat, Dec 9, 2017 at 1:24 AM, Robert Haas wrote: > On Fri, Dec 8, 2017 at 5:11 AM, Amit Kapila wrote: >>> Okay, I have adjusted the patch accordingly. I have also added a >>> regression test which should produce the same result across different >>> runs, see if that looks okay to you, then it

Re: Typo in recent commit

On Sat, Dec 9, 2017 at 4:32 AM, Robins Tharakan wrote: > Hi, > > Looks like a minor typo in the recent commit. > > s/identify/identity/ > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h= > a2c6cf36608e10aa223fef49323b5feba344bfcf > > > Thanks, fixed for the report. -- Magn

Re: pgsql: Prohibit identity columns on typed tables and partitions

On Sat, Dec 9, 2017 at 8:43 AM, Michael Paquier wrote: > On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisentraut wrote: > > Prohibit identity columns on typed tables and partitions > > > > Those cases currently crash and supporting them is more work then > > originally thought, so we'll just prohibit t

Re: proposal: alternative psql commands quit and exit

Tom Lane wrote: > The typical interaction I'd foresee is more like > > postgres=> select 2+2 (user forgets semicolon) > postgres-> help > postgres-> quit > postgres-> exit A part of this is due to the default PROMPT2 being too similar to PROMPT1. The significance of '='

Re: Speeding up pg_upgrade

Bruce, * Bruce Momjian (br...@momjian.us) wrote: > On Fri, Dec 8, 2017 at 12:26:55PM -0500, Stephen Frost wrote: > > * Bruce Momjian (br...@momjian.us) wrote: > > > I think the big problem with two-stage pg_upgrade is that the user steps > > > are more complex, so what percentage of users are goi

Re: pgsql: Prohibit identity columns on typed tables and partitions

On 12/9/17 05:47, Magnus Hagander wrote: > > > On Sat, Dec 9, 2017 at 8:43 AM, Michael Paquier > mailto:michael.paqu...@gmail.com>> wrote: > > On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisentraut > wrote: > > Prohibit identity columns on typed tables and partitio

Re: pgsql: Prohibit identity columns on typed tables and partitions

On Sat, Dec 9, 2017 at 10:45 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 12/9/17 05:47, Magnus Hagander wrote: > > > > > > On Sat, Dec 9, 2017 at 8:43 AM, Michael Paquier > > mailto:michael.paqu...@gmail.com>> wrote: > > > > On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisent

Re: proposal: alternative psql commands quit and exit

On Sat, Dec 9, 2017 at 11:36 AM, Daniel Vérité" wrote: > > postgres=> select 2+2 >2-> help >3-> quit >4-> exit I like it! Maybe another proposal to change PROMPT2?

Re: proposal: alternative psql commands quit and exit

On Sat, Dec 9, 2017 at 1:27 AM, Rok Kralj wrote: > Most popular questions on every topic are the simplest ones. Imagine a > parallel universe where this patch is contained in the codebase - I argue > this question about exiting the repl still is the top one, albeit with less > votes. > > On Sat,

Re: proposal: alternative psql commands quit and exit

Everaldo Canuto wrote: > > > > postgres=> select 2+2 > >2-> help > >3-> quit > >4-> exit > > > I like it! Maybe another proposal to change PROMPT2? Thanks. Yes, I think it should be a different proposal. On closer inspection, mysql doesn't make a real effort to

Re: proposal: alternative psql commands quit and exit

On Fri, Dec 08, 2017 at 02:12:06PM -0500, Robert Haas wrote: > On Fri, Dec 8, 2017 at 10:28 AM, Szymon Lipiński wrote: > > Well, if I have a new program I usually read some documentation. It really > > helps people to exit vim as well :) > > Look, I love vim and use it constantly, but no reasonab

Re: User defined data types in Logical Replication

On 2017/12/08 13:18, Huong Dangminh wrote: Hi Sawada-san, On Thu, Dec 7, 2017 at 11:07 AM, Masahiko Sawada wrote: On Thu, Dec 7, 2017 at 12:23 AM, Dang Minh Huong wrote: Hi Sawada-san, Sorry for my late response. On 2017/12/05 0:11, Masahiko Sawada wrote: There is one more case that us

Re: plpgsql fails to reinitialize record variables at block re-entry

Pavel Stehule writes: > 2017-12-09 7:24 GMT+01:00 Tom Lane : >> Surely that ought to have failed at the i=2 iteration. There is >> code in plpgsql's exec_stmt_block() that tries to reinitialize >> PLPGSQL_DTYPE_REC variables, but it's never reached (as a quick >> look at coverage.postgresql.org w

Re: Building PL/Perl with ActiveState Perl 5.22 and MSVC

On Mon, Nov 13, 2017 at 07:41:42AM +, Noah Misch wrote: > On Sat, Mar 26, 2016 at 03:43:21PM +0300, Victor Wagner wrote: > > 1. ActiveState Perl doesn't ship MSVC-build import library perl522.lib > > for their perl522.dll. Instead they ship MINGW-build library > > libperl522.a. > > 2. There is

Re: pl/perl extension fails on Windows

On Wed, Nov 29, 2017 at 11:45:35PM -0500, Tom Lane wrote: > Noah Misch writes: > > On Wed, Nov 29, 2017 at 11:34:56PM -0500, Tom Lane wrote: > >> I don't really have an opinion about the relative merits of these changes, > >> but why do anything? The existing solution has the buildfarm happy, and

SIGPIPE in TAP tests

Two buildfarm runs[1][2] from the last 90 days have failed in src/test/authentication, like this: t/001_password.pl .. Failed 3/8 subtests t/002_saslprep.pl .. ok 1815 ms ( 0.00 usr 0.00 sys + 0.89 cusr 0.26 csys = 1.15 CPU) Test Summary Report --- t/001_pas

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

On Thu, Dec 7, 2017 at 11:28 PM, Rushabh Lathia wrote: > I thought parallel_leader_participation is generic GUC which get effect > for all parallel operation. isn't it? On that understanding I just update > the > documentation of parallel_leader_participation into config.sgml to > make it more ge

Re: proposal: alternative psql commands quit and exit

On 12/8/17 14:08, hvjunk wrote: > Sounds like the VI exit issue? > https://stackoverflow.com/questions/11828270/how-to-exit-the-vim-editor > > Having “made that ‘mistake’” once, by lots of users, does that imply it > is a constant problem for those users? Yeah, I'm not sure I buy the way we are r

Re: proposal: alternative psql commands quit and exit

On 12/8/17 10:19, Tom Lane wrote: > Meh. I never thought that the "help" business was particularly well > thought out, and this proposal isn't better. The irony is that before the "help" thing was put in, the psql startup message said Type: \copyright for distribution terms \h for help w

Re: Jsonb transform for pl/python

On 12/6/17 06:40, Anthony Bykov wrote: > Hello, > fixed the issues: > 1. Rising errors when invalid object being transformed. > 2. We don't rise the exception when transforming range(3) only in > python 2. In third one it is an error. > > Please, find the 4-th version of the patch in attachments t

Re: proposal: alternative psql commands quit and exit

This one I’ll support to have those messages brought back for psql (especially when it’s connected to a pty), as then the SO question would fade away into obscurity (At least for those users that actually read :D ) > On 09 Des. 2017, at 11:45 nm., Peter Eisentraut > wrote: > > The irony is th

Re: proposal: alternative psql commands quit and exit

Peter Eisentraut writes: > On 12/8/17 10:19, Tom Lane wrote: >> Meh. I never thought that the "help" business was particularly well >> thought out, and this proposal isn't better. > The perhaps the fix is to revert the "help" thing? No, my problem with it is that there are lots of contexts wher

Rethinking MemoryContext creation

While fooling around with a different problem, I got annoyed at how slow MemoryContext creation and deletion is. A big chunk of that seems to be the palloc/pfree cycle needed to allocate the context header block in TopMemoryContext. After thinking about it for a bit, I decided that it'd be smarte

Re: Typo in recent commit

On 9 December 2017 at 16:11, Magnus Hagander wrote: > ​​ > > Thanks, fixed for the report. > > Thanks Magnus. However, although it was backpatched correctly, looks like the fix on master missed out identity.out related fix.​ Ref: https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/

Re: Typo in recent commit

On Sun, Dec 10, 2017 at 11:51 AM, Robins Tharakan wrote: > However, although it was backpatched correctly, looks like the fix on master > missed out identity.out related fix. Don't worry. This has been addressed already on HEAD and REL_10_STABLE. See ce1468d. -- Michael

Re: Rethinking MemoryContext creation

On Sat, Dec 9, 2017 at 5:53 PM, Tom Lane wrote: > Overall I'm seeing about a 5% improvement in a "pgbench -S" scenario, > although that number is a bit shaky since the run-to-run variation > is a few percent anyway. Is that with "-M prepared", too? -- Peter Geoghegan