Re: wrong comment in libpq.h

2024-11-20 Thread Bruce Momjian
On Thu, Oct 17, 2024 at 02:24:33PM +0200, Daniel Gustafsson wrote: > > On 17 Oct 2024, at 04:45, Bruce Momjian wrote: > > > I looked at this and decided the GUC section was illogical, so I just > > moved the variables up into the be-secure.c section. Patch attached. > > No objections. Patch ap

Re: wrong comment in libpq.h

2024-10-17 Thread Daniel Gustafsson
> On 17 Oct 2024, at 04:45, Bruce Momjian wrote: > I looked at this and decided the GUC section was illogical, so I just > moved the variables up into the be-secure.c section. Patch attached. No objections. -- Daniel Gustafsson

Re: wrong comment in libpq.h

2024-10-16 Thread Bruce Momjian
On Fri, May 10, 2024 at 11:14:51AM -0700, David Zhang wrote: > > > It looks like this wording "prototypes for functions in" is used many > > times in src/include/, in many cases equally inaccurately, so I would > > suggest creating a more comprehensive patch for this. > > I noticed this "prototyp

Re: wrong comment in libpq.h

2024-05-10 Thread David Zhang
It looks like this wording "prototypes for functions in" is used many times in src/include/, in many cases equally inaccurately, so I would suggest creating a more comprehensive patch for this. I noticed this "prototypes for functions in" in many header files and briefly checked them. It ki

Re: wrong comment in libpq.h

2024-05-06 Thread Peter Eisentraut
On 04.05.24 00:29, David Zhang wrote: On 2024-05-03 4:53 a.m., Daniel Gustafsson wrote: On 3 May 2024, at 13:48, Peter Eisentraut wrote: Maybe it's easier if we just replaced     prototypes for functions in xxx.c with     declarations for xxx.c throughout src/include/libpq/libpq.h. +1 +1

Re: wrong comment in libpq.h

2024-05-03 Thread David Zhang
On 2024-05-03 4:53 a.m., Daniel Gustafsson wrote: On 3 May 2024, at 13:48, Peter Eisentraut wrote: Maybe it's easier if we just replaced prototypes for functions in xxx.c with declarations for xxx.c throughout src/include/libpq/libpq.h. +1 +1 -- Daniel Gustafsson David

Re: wrong comment in libpq.h

2024-05-03 Thread Daniel Gustafsson
> On 3 May 2024, at 13:48, Peter Eisentraut wrote: > Maybe it's easier if we just replaced > >prototypes for functions in xxx.c > > with > >declarations for xxx.c > > throughout src/include/libpq/libpq.h. +1 -- Daniel Gustafsson

Re: wrong comment in libpq.h

2024-05-03 Thread Peter Eisentraut
On 03.05.24 00:37, David Zhang wrote: Hi Hackers, There is a comment like below in src/include/libpq/libpq.h,  /*   * prototypes for functions in be-secure.c   */ extern PGDLLIMPORT char *ssl_library; extern PGDLLIMPORT char *ssl_cert_file; ... However, 'ssl_library', 'ssl_cert_file' and t

wrong comment in libpq.h

2024-05-02 Thread David Zhang
Hi Hackers, There is a comment like below in src/include/libpq/libpq.h,  /*   * prototypes for functions in be-secure.c   */ extern PGDLLIMPORT char *ssl_library; extern PGDLLIMPORT char *ssl_cert_file; ... However, 'ssl_library', 'ssl_cert_file' and the rest are global parameter settings, no