Re: tests and meson - test names and file locations

2022-08-17 Thread Peter Eisentraut
On 12.08.22 18:29, Andres Freund wrote: I don't really understand which problem this solves and how. Sure, the test output is somewhat complex, but I know where it is and I've never found myself wishing it to be somewhere else. I'd like the buildfarm and CI a) use parallelism to run tests (that

Re: tests and meson - test names and file locations

2022-08-12 Thread Andres Freund
Hi, On 2022-08-12 18:08:00 +0200, Peter Eisentraut wrote: > > At the moment there's three suites differentiating by the type of test: > > 'pg_regress', 'isolation' and 'tap'. There's also a separate "axis" of > > suites, > > describing what's being tested, e.g. 'main', 'test_decoding', 'recovery'

Re: tests and meson - test names and file locations

2022-08-12 Thread Peter Eisentraut
On 11.08.22 06:04, Andres Freund wrote: At the moment there's three suites differentiating by the type of test: 'pg_regress', 'isolation' and 'tap'. There's also a separate "axis" of suites, describing what's being tested, e.g. 'main', 'test_decoding', 'recovery' etc. That currently works out to

Re: tests and meson - test names and file locations

2022-08-11 Thread Andres Freund
Hi, On 2022-08-11 13:06:35 -0400, Tom Lane wrote: > Andres Freund writes: > > = Log and Data locations = > > > To make things like the selection of log files for a specific test easier, > > I've so far set it up so that test data and logs are stored in a separate > > directory from the sources.

Re: tests and meson - test names and file locations

2022-08-11 Thread Andrew Dunstan
On 2022-08-11 Th 11:06, Andres Freund wrote: > Hi, > > On 2022-08-11 10:20:42 -0400, Tom Lane wrote: >> Andrew Dunstan writes: >>> I also like that. I think we should take this opportunity for some >>> serious rationalization of this. Tests and associated data have grown >>> rather like Topsy, a

Re: tests and meson - test names and file locations

2022-08-11 Thread Tom Lane
Andres Freund writes: > = Log and Data locations = > To make things like the selection of log files for a specific test easier, > I've so far set it up so that test data and logs are stored in a separate > directory from the sources. > testrun/// > I do wonder if we should put test data and log

Re: tests and meson - test names and file locations

2022-08-11 Thread Tom Lane
Andres Freund writes: > I don't precisely know what Andrew was thinking of, but the relocation of log > files for example doesn't require many changes to .pl files - one change to > Utils.pm. The one exception to that is 010_tab_completion.pl, which encodes > tmp_check/ in its output. Ah. That s

Re: tests and meson - test names and file locations

2022-08-11 Thread Andres Freund
Hi, On 2022-08-11 10:20:42 -0400, Tom Lane wrote: > Andrew Dunstan writes: > > I also like that. I think we should take this opportunity for some > > serious rationalization of this. Tests and associated data have grown > > rather like Topsy, and we should fix that. So please don't feel too > > c

Re: tests and meson - test names and file locations

2022-08-11 Thread Andres Freund
Hi, On 2022-08-11 10:06:35 -0400, Andrew Dunstan wrote: > > Full log written to /tmp/meson/meson-logs/testlog.txt > > /tmp ? I often put throwaway buildtrees in /tmp. So this is just because my buildtree is in /tmp/meson, i.e. the log always is in $build_root/meson-logs/testlog.txt (there's also

Re: tests and meson - test names and file locations

2022-08-11 Thread Tom Lane
Andrew Dunstan writes: > I also like that. I think we should take this opportunity for some > serious rationalization of this. Tests and associated data have grown > rather like Topsy, and we should fix that. So please don't feel too > constrained by current practice. I'm definitely -1 on that.

Re: tests and meson - test names and file locations

2022-08-11 Thread Andrew Dunstan
On 2022-08-11 Th 00:04, Andres Freund wrote: > > The runner now creates a test.start at the start of a test and either > test.success or test.failure at the end. That should make it pretty easy for > e.g. the buildfarm and CI to make the logs for a failed test easily > accessible. I've spent far

tests and meson - test names and file locations

2022-08-10 Thread Andres Freund
Hi, One of the things motivating me to work on the meson conversion is the ability to run tests in an easily understandable way. Meson has a testrunner that both allows to run all tests at once, and run subsets of tests. = Test and testsuite naming = Each test has a unique name, and 0-n labels