Re: subscriptioncheck failure

2021-05-18 Thread vignesh C
On Wed, May 19, 2021 at 10:28 AM Amit Kapila wrote: > > On Tue, May 18, 2021 at 11:25 AM vignesh C wrote: > > > > Thanks for the comments, the attached patch has the changes for the same. > > > > Thanks, I have pushed your patch after making minor changes in the comments. Thanks for pushing this

Re: subscriptioncheck failure

2021-05-18 Thread Amit Kapila
On Tue, May 18, 2021 at 11:25 AM vignesh C wrote: > > Thanks for the comments, the attached patch has the changes for the same. > Thanks, I have pushed your patch after making minor changes in the comments. -- With Regards, Amit Kapila.

Re: subscriptioncheck failure

2021-05-17 Thread vignesh C
On Tue, May 18, 2021 at 9:09 AM Amit Kapila wrote: > > On Mon, May 17, 2021 at 5:48 PM vignesh C wrote: > > > > On Mon, May 17, 2021 at 10:40 AM Amit Kapila > > wrote: > > > > > > One more point: > > > + $node_publisher->wait_for_catchup('tap_sub'); > > > + > > > + # Ensure a transactional logi

Re: subscriptioncheck failure

2021-05-17 Thread Amit Kapila
On Mon, May 17, 2021 at 5:48 PM vignesh C wrote: > > On Mon, May 17, 2021 at 10:40 AM Amit Kapila wrote: > > > > One more point: > > + $node_publisher->wait_for_catchup('tap_sub'); > > + > > + # Ensure a transactional logical decoding message shows up on the slot > > + $node_subscriber->safe_psql

Re: subscriptioncheck failure

2021-05-17 Thread vignesh C
On Mon, May 17, 2021 at 10:40 AM Amit Kapila wrote: > > On Mon, May 17, 2021 at 9:06 AM Amit Kapila wrote: > > > > On Thu, May 13, 2021 at 7:06 PM vignesh C wrote: > > > > > > On Thu, May 13, 2021 at 4:41 PM Michael Paquier > > > wrote: > > > > Few comments: > > 1. > > + # Ensure a transaction

Re: subscriptioncheck failure

2021-05-16 Thread Amit Kapila
On Mon, May 17, 2021 at 9:06 AM Amit Kapila wrote: > > On Thu, May 13, 2021 at 7:06 PM vignesh C wrote: > > > > On Thu, May 13, 2021 at 4:41 PM Michael Paquier wrote: > > Few comments: > 1. > + # Ensure a transactional logical decoding message shows up on the slot > + $node_subscriber->safe_psql

Re: subscriptioncheck failure

2021-05-16 Thread Amit Kapila
On Thu, May 13, 2021 at 7:06 PM vignesh C wrote: > > On Thu, May 13, 2021 at 4:41 PM Michael Paquier wrote: > > > > On Thu, May 13, 2021 at 04:14:55PM +0530, vignesh C wrote: > > > +$node_publisher->wait_for_catchup('tap_sub'); > > > + > > > # Ensure a transactional logical decoding message show

Re: subscriptioncheck failure

2021-05-13 Thread Michael Paquier
On Thu, May 13, 2021 at 07:05:55PM +0530, vignesh C wrote: > Thanks for the comments, Please find the attached patch having the changes. Cool, thanks for the new version. I have spent some time understanding the initial report from Amit as well as what you are proposing here, and refactoring the

Re: subscriptioncheck failure

2021-05-13 Thread vignesh C
On Thu, May 13, 2021 at 4:41 PM Michael Paquier wrote: > > On Thu, May 13, 2021 at 04:14:55PM +0530, vignesh C wrote: > > +$node_publisher->wait_for_catchup('tap_sub'); > > + > > # Ensure a transactional logical decoding message shows up on the slot > > $node_subscriber->safe_psql('postgres', "A

Re: subscriptioncheck failure

2021-05-13 Thread vignesh C
On Thu, May 13, 2021 at 4:41 PM Michael Paquier wrote: > > On Thu, May 13, 2021 at 04:14:55PM +0530, vignesh C wrote: > > +$node_publisher->wait_for_catchup('tap_sub'); > > + > > # Ensure a transactional logical decoding message shows up on the slot > > $node_subscriber->safe_psql('postgres', "A

Re: subscriptioncheck failure

2021-05-13 Thread Michael Paquier
On Thu, May 13, 2021 at 04:14:55PM +0530, vignesh C wrote: > +$node_publisher->wait_for_catchup('tap_sub'); > + > # Ensure a transactional logical decoding message shows up on the slot > $node_subscriber->safe_psql('postgres', "ALTER SUBSCRIPTION tap_sub > DISABLE"); > > # wait for the replic

Re: subscriptioncheck failure

2021-05-13 Thread vignesh C
On Thu, May 13, 2021 at 3:12 PM Amit Kapila wrote: > > I noticed $SUBJECT in curculio. > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=curculio&dt=2021-05-11%2018%3A30%3A23 > > The failure test report: > t/020_messages.pl(Wstat: 7424 Tests: 1 Failed: 0) > Non-zero exit

subscriptioncheck failure

2021-05-13 Thread Amit Kapila
I noticed $SUBJECT in curculio. https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=curculio&dt=2021-05-11%2018%3A30%3A23 The failure test report: t/020_messages.pl(Wstat: 7424 Tests: 1 Failed: 0) Non-zero exit status: 29 Parse errors: Bad plan. You planned 5 tests but ran