Re: simplifying grammar for ALTER CONSTRAINT .. SET [NO] INHERIT

2025-03-27 Thread Álvaro Herrera
On 2025-Mar-26, Suraj Kharage wrote: > Yes, I agree. As Peter said, it is now inline with other commands. > > I have reviewed the patch and it looks good to me. Thanks for reviewing! > Since we are removing the SET keyword, how about removing that from the > below comment as well. > > /* > *

Re: simplifying grammar for ALTER CONSTRAINT .. SET [NO] INHERIT

2025-03-26 Thread Suraj Kharage
On Tue, Mar 25, 2025 at 9:32 PM Álvaro Herrera wrote: > With commit f4e53e10b6ce we introduced a way to flip the NO INHERIT bit > on not-null constraints. However, because of the way the grammar > dealt with ALTER CONSTRAINT, we were too blind to see a way to implement > it using the existing pr

Re: simplifying grammar for ALTER CONSTRAINT .. SET [NO] INHERIT

2025-03-26 Thread Peter Eisentraut
On 25.03.25 17:02, Álvaro Herrera wrote: With commit f4e53e10b6ce we introduced a way to flip the NO INHERIT bit on not-null constraints. However, because of the way the grammar dealt with ALTER CONSTRAINT, we were too blind to see a way to implement it using the existing production. It turns o

Re: simplifying grammar for ALTER CONSTRAINT .. SET [NO] INHERIT

2025-03-25 Thread Álvaro Herrera
On 2025-Mar-25, Álvaro Herrera wrote: > With commit f4e53e10b6ce we introduced a way to flip the NO INHERIT bit > on not-null constraints. However, because of the way the grammar > dealt with ALTER CONSTRAINT, we were too blind to see a way to implement > it using the existing production. Patch

simplifying grammar for ALTER CONSTRAINT .. SET [NO] INHERIT

2025-03-25 Thread Álvaro Herrera
With commit f4e53e10b6ce we introduced a way to flip the NO INHERIT bit on not-null constraints. However, because of the way the grammar dealt with ALTER CONSTRAINT, we were too blind to see a way to implement it using the existing production. It turns out that we can remove it, so the commands w