Re: remove reset_shared()

2022-07-16 Thread Nathan Bossart
On Sat, Jul 16, 2022 at 12:34:11PM -0400, Tom Lane wrote: > Pushed after fiddling with the comments. Thanks! -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: remove reset_shared()

2022-07-16 Thread Tom Lane
Pavel Borisov writes: > I see the proposed patch as uncontroversial and good enough to be > committed. It will make the code a little clearer. Personally, I don't like > leaving functions that are just wrappers for another and called only once. Yeah, I like this for a different reason: just a cou

Re: remove reset_shared()

2022-07-15 Thread Pavel Borisov
On Fri, 15 Jul 2022 at 16:41, Maxim Orlov wrote: > Hi! > > In general I'm for this patch. Some time ago I was working on a patch > related to shared memory and noticed > no reason to have reset_shared() function. > Hi, hackers! I see the proposed patch as uncontroversial and good enough to be co

Re: remove reset_shared()

2022-07-15 Thread Maxim Orlov
Hi! In general I'm for this patch. Some time ago I was working on a patch related to shared memory and noticed no reason to have reset_shared() function. -- Best regards, Maxim Orlov.

Re: remove reset_shared()

2022-03-29 Thread Julien Rouhaud
Hi, On Tue, Mar 29, 2022 at 03:17:02PM -0700, Nathan Bossart wrote: > Hi hackers, > > Is there any reason to keep reset_shared() around anymore? It is now just > a wrapper function for CreateSharedMemoryAndSemaphores(), and AFAICT the > information in the comments is already covered by comments i

remove reset_shared()

2022-03-29 Thread Nathan Bossart
so I don't intend to carry this patch further if anyone is opposed. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com >From 295e1e93a2ff4e655e85040d931c0d332d14b5bd Mon Sep 17 00:00:00 2001 From: Nathan Bossart Date: Tue, 29 Mar 2022 14:56:47 -0700 Subject: [PATCH v1 1/1] R