On Fri, 15 Jul 2022 at 16:41, Maxim Orlov <orlo...@gmail.com> wrote: > Hi! > > In general I'm for this patch. Some time ago I was working on a patch > related to shared memory and noticed > no reason to have reset_shared() function. >
Hi, hackers! I see the proposed patch as uncontroversial and good enough to be committed. It will make the code a little clearer. Personally, I don't like leaving functions that are just wrappers for another and called only once. But I think that if there's a question of code readability it's not bad to restore the comments on the purpose of a call that were originally in the code. PFA v2 of a patch (only the comment removed in v1 is restored in v2). Overall I'd like to move it to RfC if none have any objections.
v2-0001-Remove-a-wrapper-for-CreateSharedMemoryAndSemapho.patch
Description: Binary data
