Re: recovery_min_apply_delay in archive recovery causes assertion failure in latch

2019-12-15 Thread Fujii Masao
On Sat, Dec 14, 2019 at 12:35 AM Alvaro Herrera wrote: > > On 2019-Oct-19, Michael Paquier wrote: > > > On Thu, Oct 17, 2019 at 02:35:13PM +0900, Michael Paquier wrote: > > > ArchiveRecoveryRequested will be set to true if recovery.signal or > > > standby.signal are found, so it seems to me that y

Re: recovery_min_apply_delay in archive recovery causes assertion failure in latch

2019-12-13 Thread Alvaro Herrera
On 2019-Oct-19, Michael Paquier wrote: > On Thu, Oct 17, 2019 at 02:35:13PM +0900, Michael Paquier wrote: > > ArchiveRecoveryRequested will be set to true if recovery.signal or > > standby.signal are found, so it seems to me that you can make all > > those checks more simple by removing from the e

Re: recovery_min_apply_delay in archive recovery causes assertion failure in latch

2019-10-18 Thread Michael Paquier
On Thu, Oct 17, 2019 at 02:35:13PM +0900, Michael Paquier wrote: > ArchiveRecoveryRequested will be set to true if recovery.signal or > standby.signal are found, so it seems to me that you can make all > those checks more simple by removing from the equation > StandbyModeRequested, no? StandbyMode

Re: recovery_min_apply_delay in archive recovery causes assertion failure in latch

2019-10-16 Thread Michael Paquier
On Tue, Oct 08, 2019 at 02:18:00AM +0900, Fujii Masao wrote: > On Fri, Oct 4, 2019 at 9:03 PM Fujii Masao wrote: >> So archive recovery with recovery_min_apply_delay enabled would be >> intended configuration. My patch that changes archive recovery so that >> it always ignores thesetting might be

Re: recovery_min_apply_delay in archive recovery causes assertion failure in latch

2019-10-07 Thread Fujii Masao
On Fri, Oct 4, 2019 at 9:03 PM Fujii Masao wrote: > > On Mon, Sep 30, 2019 at 12:49 AM Fujii Masao wrote: > > > > Hi, > > > > I got the following assertion failure when I enabled > > recovery_min_apply_delay > > and started archive recovery (i.e., I put only recovery.signal not > > standby.signa

Re: recovery_min_apply_delay in archive recovery causes assertion failure in latch

2019-10-04 Thread Fujii Masao
On Mon, Sep 30, 2019 at 12:49 AM Fujii Masao wrote: > > Hi, > > I got the following assertion failure when I enabled recovery_min_apply_delay > and started archive recovery (i.e., I put only recovery.signal not > standby.signal). > > TRAP: FailedAssertion("latch->owner_pid == MyProcPid", File: > "

Re: recovery_min_apply_delay in archive recovery causes assertion failure in latch

2019-09-30 Thread Michael Paquier
On Mon, Sep 30, 2019 at 05:50:03PM +0900, Fujii Masao wrote: > Thanks for the review! OK, attached is the patch which also added > two assertion checks as you described. Thanks, looks fine. The indentation looks a bit wrong for the comments, but that's a nit. -- Michael signature.asc Descriptio

Re: recovery_min_apply_delay in archive recovery causes assertion failure in latch

2019-09-30 Thread Fujii Masao
On Mon, Sep 30, 2019 at 12:42 PM Michael Paquier wrote: > > On Mon, Sep 30, 2019 at 12:49:03AM +0900, Fujii Masao wrote: > > Attached patch fixes this issue by making archive recovery always ignore > > recovery_min_apply_delay. This change is OK because > > recovery_min_apply_delay was introduced

Re: recovery_min_apply_delay in archive recovery causes assertion failure in latch

2019-09-29 Thread Michael Paquier
On Mon, Sep 30, 2019 at 12:49:03AM +0900, Fujii Masao wrote: > Attached patch fixes this issue by making archive recovery always ignore > recovery_min_apply_delay. This change is OK because > recovery_min_apply_delay was introduced for standby mode, I think. > > This issue is not new in v12. I obs

recovery_min_apply_delay in archive recovery causes assertion failure in latch

2019-09-29 Thread Fujii Masao
Hi, I got the following assertion failure when I enabled recovery_min_apply_delay and started archive recovery (i.e., I put only recovery.signal not standby.signal). TRAP: FailedAssertion("latch->owner_pid == MyProcPid", File: "latch.c", Line: 522) Here is the example to reproduce the issue: --