On Mon, Sep 30, 2019 at 12:42 PM Michael Paquier <mich...@paquier.xyz> wrote: > > On Mon, Sep 30, 2019 at 12:49:03AM +0900, Fujii Masao wrote: > > Attached patch fixes this issue by making archive recovery always ignore > > recovery_min_apply_delay. This change is OK because > > recovery_min_apply_delay was introduced for standby mode, I think. > > > > This issue is not new in v12. I observed that the issue was reproduced > > in v11. So the back-patch is necessary. > > I have not directly tested, but from a lookup at the code I think > that you are right. Perhaps we'd want more safeguards in > WaitForWALToBecomeAvailable(), like an assert within the > XLOG_FROM_STREAM part similar to the check you are adding? My point > is that we should switch to XLOG_FROM_STREAM only if we are in standby > mode, and that's the only place where the startup process looks at > recoveryWakeupLatch.
Thanks for the review! OK, attached is the patch which also added two assertion checks as you described. Regards, -- Fujii Masao
fix-assertion-failure-in-latch_v2.patch
Description: Binary data
