Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus

2025-04-05 Thread Robert Haas
On Tue, Mar 18, 2025 at 12:36 AM Masahiko Sawada wrote: > > Cool. The commit message refers to 003_char_signedness, but the test > > name is 005, not 003. > > Thank you for reviewing the patch. I've pushed the patch after fixing it. Thanks for taking care of it (and so quickly!). -- Robert Haas

Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus

2025-03-17 Thread Masahiko Sawada
On Mon, Mar 17, 2025 at 8:02 PM Robert Haas wrote: > > On Mon, Mar 17, 2025 at 6:02 PM Masahiko Sawada wrote: > > I've confirmed the issue and attached a patch to fix it. > > Cool. The commit message refers to 003_char_signedness, but the test > name is 005, not 003. Thank you for reviewing the

Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus

2025-03-17 Thread Robert Haas
On Mon, Mar 17, 2025 at 6:02 PM Masahiko Sawada wrote: > I've confirmed the issue and attached a patch to fix it. Cool. The commit message refers to 003_char_signedness, but the test name is 005, not 003. -- Robert Haas EDB: http://www.enterprisedb.com

Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus

2025-03-17 Thread Masahiko Sawada
On Mon, Mar 17, 2025 at 10:20 AM Robert Haas wrote: > > On Fri, Feb 21, 2025 at 1:20 PM Masahiko Sawada > wrote: > > pg_upgrade: Preserve default char signedness value from old cluster. > > Hi, > > I noticed that after running 'meson test --suite setup --suite > pg_upgrade', the file delete_old_

Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus

2025-03-17 Thread Robert Haas
On Fri, Feb 21, 2025 at 1:20 PM Masahiko Sawada wrote: > pg_upgrade: Preserve default char signedness value from old cluster. Hi, I noticed that after running 'meson test --suite setup --suite pg_upgrade', the file delete_old_cluster.sh is left behind in the source directory, which should not ha