Re: pgsql: Use data directory inode number, not port, to select SysV resour

2019-09-12 Thread Noah Misch
On Sun, Sep 08, 2019 at 05:54:12PM -0400, Andrew Dunstan wrote: > I'm going to disable this test (src/test/recovery/t/017_shm.pl) on > Windows on the back branches too unless there's a violent objection. The > reason is that the script runs "postgres --single" and that fails on > Windows when run b

Re: pgsql: Use data directory inode number, not port, to select SysV resour

2019-09-08 Thread Tom Lane
Andrew Dunstan writes: > I'm going to disable this test (src/test/recovery/t/017_shm.pl) on > Windows on the back branches too unless there's a violent objection. As I said before, I think that test does nothing useful unless SysV shmem is in use, so I see no reason not to disable it on Windows.

Re: pgsql: Use data directory inode number, not port, to select SysV resour

2019-09-08 Thread Andrew Dunstan
On 9/6/19 3:51 PM, Andrew Dunstan wrote: > On 9/6/19 2:42 PM, Tom Lane wrote: >> Andrew Dunstan writes: >>> Given your stated intention, I think the simplest way to get it is just >>> this, without worrying about what the perl modules might do: >>> -if ($@) >>> +if ($@ || $windows_os) >> WFM, do