Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

2019-01-14 Thread Andres Freund
Hi, On 2019-01-07 17:03:20 +0530, Amit Khandekar wrote: > On Sat, 5 Jan 2019 at 02:09, Andres Freund wrote: > > On 2019-01-03 13:40:42 -0500, Tom Lane wrote: > > > I noticed that this patch has broken restores of existing dump files: > > > > > > psql:testbed.public.backup:82: ERROR: unrecognized

Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

2019-01-07 Thread Amit Khandekar
On Sat, 5 Jan 2019 at 02:09, Andres Freund wrote: > > Hi, > > On 2019-01-03 13:40:42 -0500, Tom Lane wrote: > > I noticed that this patch has broken restores of existing dump files: > > > > psql:testbed.public.backup:82: ERROR: unrecognized configuration parameter > > "default_with_oids" > > > >

Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

2019-01-04 Thread Andres Freund
Hi, On 2019-01-03 13:40:42 -0500, Tom Lane wrote: > I noticed that this patch has broken restores of existing dump files: > > psql:testbed.public.backup:82: ERROR: unrecognized configuration parameter > "default_with_oids" > > Quite aside from the fact that this won't work if the user tries to

Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

2019-01-03 Thread Tom Lane
I noticed that this patch has broken restores of existing dump files: psql:testbed.public.backup:82: ERROR: unrecognized configuration parameter "default_with_oids" Quite aside from the fact that this won't work if the user tries to restore in single-transaction or no-error mode, this is really

Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

2018-11-21 Thread Peter Eisentraut
On 21/11/2018 09:20, Christoph Berg wrote: > Re: Andres Freund 2018-11-21 >> The biggest user of WITH OID columns was postgres' catalog. This >> commit changes all 'magic' oid columns to be columns that are normally >> declared and stored. > > postgres=# \d+ pg_class > [...] > Indexe: > "pg_c

Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

2018-11-21 Thread Christoph Berg
Re: Gavin Flower 2018-11-21 > Curious, is there a reason 'Index' is spelt with a trailing 'e'? LANG=de_DE.UTF-8 Christoph

Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

2018-11-21 Thread Gavin Flower
On 21/11/2018 21:20, Christoph Berg wrote: Re: Andres Freund 2018-11-21 The biggest user of WITH OID columns was postgres' catalog. This commit changes all 'magic' oid columns to be columns that are normally declared and stored. postgres=# \d+ pg_class [...] Indexe: "pg_class_oid_index" U

Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

2018-11-21 Thread Christoph Berg
Re: Andres Freund 2018-11-21 > The biggest user of WITH OID columns was postgres' catalog. This > commit changes all 'magic' oid columns to be columns that are normally > declared and stored. postgres=# \d+ pg_class [...] Indexe: "pg_class_oid_index" UNIQUE, btree (oid) Now that oid is a pro