Hi, On 2019-01-03 13:40:42 -0500, Tom Lane wrote: > I noticed that this patch has broken restores of existing dump files: > > psql:testbed.public.backup:82: ERROR: unrecognized configuration parameter > "default_with_oids" > > Quite aside from the fact that this won't work if the user tries to > restore in single-transaction or no-error mode, this is really really > unhelpful because it's impossible to tell whether the error is > ignorable or not, except by digging through the dump file. > > What you should do is restore that GUC, but add a check-hook that throws > an error for an attempt to set it to "true".
Makes sense, I (or a colleague) will look into that next week. Wanna get my head out of pluggable storage first... Greetings, Andres Freund
