On Wed, Nov 11, 2020 at 04:51:27PM +0100, Magnus Hagander wrote:
> Gah. For some reason, I did not spot this email until after I had
> applied the other patch. And not only that, I also missed one line in
> my patch that you included in yours :/
>
> My apologies.
No worries, thanks.
--
Michael
On Wed, Nov 11, 2020 at 2:21 AM Michael Paquier wrote:
>
> On Tue, Nov 10, 2020 at 10:21:04AM +0900, Michael Paquier wrote:
> > On Mon, Nov 09, 2020 at 03:47:22PM +0100, Peter Eisentraut wrote:
> >> You should just remove those calls. There is no need to replace them with
> >> vacuumdb calls. Th
On Mon, Nov 9, 2020 at 3:47 PM Peter Eisentraut
wrote:
>
> On 2020-11-09 11:22, Magnus Hagander wrote:
> >> I have spotted one small-ish thing. This patch is missing to update
> >> the following code in vcregress.pl:
> >> print "\nSetting up stats on new cluster\n\n";
> >> system(".\\an
On Tue, Nov 10, 2020 at 10:21:04AM +0900, Michael Paquier wrote:
> On Mon, Nov 09, 2020 at 03:47:22PM +0100, Peter Eisentraut wrote:
>> You should just remove those calls. There is no need to replace them with
>> vacuumdb calls. The reason those calls were there is that they were testing
>> the g
On Mon, Nov 09, 2020 at 03:47:22PM +0100, Peter Eisentraut wrote:
> You should just remove those calls. There is no need to replace them with
> vacuumdb calls. The reason those calls were there is that they were testing
> the generated script itself. If the script is gone, there is no more need.
On 2020-11-09 11:22, Magnus Hagander wrote:
I have spotted one small-ish thing. This patch is missing to update
the following code in vcregress.pl:
print "\nSetting up stats on new cluster\n\n";
system(".\\analyze_new_cluster.bat") == 0 or exit 1;
Ah, nice catch -- thanks! I guess thi
On Mon, Nov 9, 2020 at 11:22 AM Magnus Hagander wrote:
>
> On Mon, Nov 9, 2020 at 8:53 AM Michael Paquier wrote:
> >
> > On Mon, Nov 02, 2020 at 02:18:32PM +0100, Magnus Hagander wrote:
> > > On Fri, Oct 30, 2020 at 5:10 PM Georgios Kokolatos
> > > wrote:
> > >> I did notice that the cfbot [1] i
On Mon, Nov 9, 2020 at 8:53 AM Michael Paquier wrote:
>
> On Mon, Nov 02, 2020 at 02:18:32PM +0100, Magnus Hagander wrote:
> > On Fri, Oct 30, 2020 at 5:10 PM Georgios Kokolatos
> > wrote:
> >> I did notice that the cfbot [1] is failing for this patch.
> >> Please try to address the issues for th
On Mon, Nov 02, 2020 at 02:18:32PM +0100, Magnus Hagander wrote:
> On Fri, Oct 30, 2020 at 5:10 PM Georgios Kokolatos
> wrote:
>> I did notice that the cfbot [1] is failing for this patch.
>> Please try to address the issues for the upcoming Commitfest.
>
> Thanks for the notice -- PFA a rebased
On Fri, Oct 30, 2020 at 5:10 PM Georgios Kokolatos
wrote:
>
> Hi,
>
> thank you for you contribution.
>
> I did notice that the cfbot [1] is failing for this patch.
> Please try to address the issues for the upcoming Commitfest.
Thanks for the notice -- PFA a rebased version!
--
Magnus Hagande
Hi,
thank you for you contribution.
I did notice that the cfbot [1] is failing for this patch.
Please try to address the issues for the upcoming Commitfest.
Cheers,
//Georgios
[1] http://cfbot.cputube.org/magnus-hagander.html
On 2020-10-06 11:43, Magnus Hagander wrote:
For a long time now, pg_upgrade drops a script (analyze_new_cluster.sh)
that just calls vacuumdb to run the analyze in stages. This script made
a lot of sense back when it actually implemented the stages, but these
days since it's just calling a singl
On Tue, Oct 6, 2020 at 10:40:30PM +0200, Magnus Hagander wrote:
> I think that's information that belongs in the documentation, for those that
> case. I'm willing to bet that the large majority of the people who run the
> script never read that, and certainly don't cancel it. Those that need it to
On Tue, Oct 6, 2020 at 9:05 PM Bruce Momjian wrote:
> On Tue, Oct 6, 2020 at 11:43:01AM +0200, Magnus Hagander wrote:
> > For a long time now, pg_upgrade drops a script (analyze_new_cluster.sh)
> that
> > just calls vacuumdb to run the analyze in stages. This script made a lot
> of
> > sense bac
On Tue, Oct 6, 2020 at 11:43:01AM +0200, Magnus Hagander wrote:
> For a long time now, pg_upgrade drops a script (analyze_new_cluster.sh) that
> just calls vacuumdb to run the analyze in stages. This script made a lot of
> sense back when it actually implemented the stages, but these days since it
For a long time now, pg_upgrade drops a script (analyze_new_cluster.sh)
that just calls vacuumdb to run the analyze in stages. This script made a
lot of sense back when it actually implemented the stages, but these days
since it's just calling a single command, I think it's just unnecessary
complic
16 matches
Mail list logo
