On Tue, Oct 6, 2020 at 11:43:01AM +0200, Magnus Hagander wrote: > For a long time now, pg_upgrade drops a script (analyze_new_cluster.sh) that > just calls vacuumdb to run the analyze in stages. This script made a lot of > sense back when it actually implemented the stages, but these days since it's > just calling a single command, I think it's just unnecessary complication. > > I suggest we drop it and just replace it with instructions to call vacuumdb > directly.
Uh, that script has instructions on what is running. Do we want to show that at the end of running pg_upgrade or do people understand "stages" by now? > Attached patch does this. It also removes the support in the instructions that > talk about pre-8.4 databases, which I believe is dead code per https:// > postgr.es/m/CABUevEx-D0PNVe00tkeQRGennZQwDtBJn=493mjt-x6sppb...@mail.gmail.com. I just removed that. -- Bruce Momjian <br...@momjian.us> https://momjian.us EnterpriseDB https://enterprisedb.com The usefulness of a cup is in its emptiness, Bruce Lee
