On Sat, Jul 11, 2020 at 10:35:07AM +0900, Michael Paquier wrote:
> Yes, I have also opened an issue on github:
> https://github.com/macdice/cfbot/issues/11/
And Thomas has just fixed it:
https://github.com/macdice/cfbot/commit/e78438444a00bc8d83863645503b2f7c1a9da016
--
Michael
signature.asc
Des
On Fri, Jul 10, 2020 at 09:35:56AM -0400, Tom Lane wrote:
> Should now be possible to undo whatever hack you had to use ...
Yes, I have also opened an issue on github:
https://github.com/macdice/cfbot/issues/11/
--
Michael
signature.asc
Description: PGP signature
Thomas Munro writes:
> On Thu, Jun 18, 2020 at 1:42 PM Michael Paquier wrote:
>> Thanks, applied this part to HEAD then after more testing.
> Hmm, somehow this (well I guess it's this commit based on timing and
> the area it touches, not sure exactly why) made cfbot's Windows build
> fail, like
On Sun, Jun 21, 2020 at 10:38:22PM +1200, Thomas Munro wrote:
> On Sun, Jun 21, 2020 at 8:42 PM Michael Paquier wrote:
>> Thanks, and sorry for the trouble. What actually happened back in
>> 2018? I can see c2ff3c68 in the git history of the cfbot code, but it
>> does not give much details.
>
>
On Sun, Jun 21, 2020 at 8:42 PM Michael Paquier wrote:
> On Sun, Jun 21, 2020 at 12:08:37PM +1200, Thomas Munro wrote:
> > I'm not sure what needs to change, but in the meantime I told it to
> > comment out the offending test from the schedule files:
> >
> > +before_test:
> > + - 'perl -p -i.bak
On Sun, Jun 21, 2020 at 12:08:37PM +1200, Thomas Munro wrote:
> I'm not sure what needs to change, but in the meantime I told it to
> comment out the offending test from the schedule files:
>
> +before_test:
> + - 'perl -p -i.bak -e "s/^test: tablespace/#test: tablespace/"
> src/test/regress/seri
On Sat, Jun 20, 2020 at 6:46 PM Michael Paquier wrote:
> On Sat, Jun 20, 2020 at 03:01:36PM +1200, Thomas Munro wrote:
> > Thanks for the clue. Appveyor runs your build script as a privileged
> > user (unlike, I assume, the build farm animals), and that has caused a
> > problem with this test in
On Sat, Jun 20, 2020 at 03:01:36PM +1200, Thomas Munro wrote:
> Thanks for the clue. Appveyor runs your build script as a privileged
> user (unlike, I assume, the build farm animals), and that has caused a
> problem with this test in the past, though I don't know the details.
> I might go and teac
On Sat, Jun 20, 2020 at 2:42 PM Michael Paquier wrote:
> > +ERROR: could not set permissions on directory
> > "C:/projects/postgresql/src/test/regress/testtablespace": Permission
> > denied
> >
> > Any ideas? Here's what it does:
> >
> > https://github.com/macdice/cfbot/tree/master/appveyor
>
> I
On Sat, Jun 20, 2020 at 09:33:26AM +1200, Thomas Munro wrote:
> Hmm, somehow this (well I guess it's this commit based on timing and
> the area it touches, not sure exactly why) made cfbot's Windows build
> fail, like this:
>
> --- C:/projects/postgresql/src/test/regress/expected/tablespace.out
>
On Thu, Jun 18, 2020 at 1:42 PM Michael Paquier wrote:
> Thanks, applied this part to HEAD then after more testing.
Hmm, somehow this (well I guess it's this commit based on timing and
the area it touches, not sure exactly why) made cfbot's Windows build
fail, like this:
--- C:/projects/postgres
On Wed, Jun 17, 2020 at 05:02:31PM +0900, Kyotaro Horiguchi wrote:
> It look good to me as the Windows part. I agree that vcregress.pl
> don't need to parse EXTRA_REGRESS_OPTS by allowing a bit more tight
> bond between the caller sites of pg_regress and pg_regress.
Thanks, applied this part to HE
Thanks for working on this.
At Wed, 17 Jun 2020 16:12:07 +0900, Michael Paquier wrote
in
> On Fri, May 15, 2020 at 05:25:08PM +0900, Kyotaro Horiguchi wrote:
> > I thought of that but didn't in the patch. I refrained from doing
> > that because the output directory is dedicatedly created at th
On Fri, May 15, 2020 at 05:25:08PM +0900, Kyotaro Horiguchi wrote:
> I thought of that but didn't in the patch. I refrained from doing
> that because the output directory is dedicatedly created at the only
> place (pg_upgrade test) where the --outputdir is specified. (I think I
> tend to do too-mu
Thank you for looking this!
At Fri, 15 May 2020 11:58:55 +0900, Michael Paquier wrote
in
> On Mon, May 11, 2020 at 05:13:54PM +0900, Kyotaro Horiguchi wrote:
> > Tablespace directory cleanup is not done for all testing
> > targets. Actually it is not done for the tools under bin/ except
> > pg_
On Fri, May 15, 2020 at 11:58:55AM +0900, Michael Paquier wrote:
> Let's first take one problem at a time, as I can see that your patch
> 0002 is modifying a portion of what you added in 0001, and so let's
> try to remove this WIN32 stuff from pg_regress.c.
(Please note that this is not v13 materi
On Mon, May 11, 2020 at 05:13:54PM +0900, Kyotaro Horiguchi wrote:
> Tablespace directory cleanup is not done for all testing
> targets. Actually it is not done for the tools under bin/ except
> pg_upgrade.
Let's first take one problem at a time, as I can see that your patch
0002 is modifying a po
At Fri, 21 Feb 2020 17:05:07 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Thu, 20 Feb 2020 14:23:22 +0900, Michael Paquier
> wrote in
> > Removing this code from pg_regress.c makes also sense to me. Now, the
> > patch breaks "vcregress installcheck" as this is missing to patch
> > installche
At Thu, 20 Feb 2020 14:23:22 +0900, Michael Paquier wrote
in
> On Wed, Feb 19, 2020 at 04:06:33PM -0500, Tom Lane wrote:
> > I think the existing coding dates from before we had a Perl driver for
> > this, or else we had it but there were other less-functional ways to
> > replace "make check" on
On Wed, Feb 19, 2020 at 04:06:33PM -0500, Tom Lane wrote:
> I think the existing coding dates from before we had a Perl driver for
> this, or else we had it but there were other less-functional ways to
> replace "make check" on Windows. +1 for taking the code out of
> pg_regress.c --- but I'm not
Kyotaro Horiguchi writes:
> But in the first place it comes from [1] and the comment says:
>> * XXX it would be better if pg_regress.c had nothing at all to do with
>> * testtablespace, and this were handled by a .BAT file or similar on
>> * Windows. See pgsql-hackers discussion of 2008-01-18.
Hello.
I saw a failure of vcregress check with the following message several
times, on a machine under a heavy load and maybe with realtime virus
scanning.
> pg_regress: could not create directory ".../testtablespace": Permission
> denied.
I found that pg_regress repeats the sequence
rmtree(tab
22 matches
Mail list logo
