On Thu, Jun 18, 2020 at 1:42 PM Michael Paquier <mich...@paquier.xyz> wrote: > Thanks, applied this part to HEAD then after more testing.
Hmm, somehow this (well I guess it's this commit based on timing and the area it touches, not sure exactly why) made cfbot's Windows build fail, like this: --- C:/projects/postgresql/src/test/regress/expected/tablespace.out 2020-06-19 21:26:24.661817000 +0000 +++ C:/projects/postgresql/src/test/regress/results/tablespace.out 2020-06-19 21:26:28.613257500 +0000 @@ -2,83 +2,78 @@ CREATE TABLESPACE regress_tblspacewith LOCATION 'C:/projects/postgresql/src/test/regress/testtablespace' WITH (some_nonexistent_parameter = true); -- fail ERROR: unrecognized parameter "some_nonexistent_parameter" CREATE TABLESPACE regress_tblspacewith LOCATION 'C:/projects/postgresql/src/test/regress/testtablespace' WITH (random_page_cost = 3.0); -- ok +ERROR: could not set permissions on directory "C:/projects/postgresql/src/test/regress/testtablespace": Permission denied Any ideas? Here's what it does: https://github.com/macdice/cfbot/tree/master/appveyor
