Re: pg_publication repetitious code

2019-12-20 Thread Tom Lane
Alvaro Herrera writes: > This very small patch removes some duplicated code in pg_publication. Seems like the extra test on missing_oid is unnecessary: + oid = get_publication_oid(pubname, missing_ok); + if (!OidIsValid(oid) && missing_ok) + return NULL; As coded, it's

pg_publication repetitious code

2019-12-20 Thread Alvaro Herrera
This very small patch removes some duplicated code in pg_publication. -- Álvaro Herrerahttp://www.linkedin.com/in/alvherre diff --git a/src/backend/catalog/pg_publication.c b/src/backend/catalog/pg_publication.c index d442c8e0bb..347324f320 100644 --- a/src/backend/cat