Re: pg_init_privs corruption.

2023-04-13 Thread Robert Haas
On Fri, Feb 17, 2023 at 3:38 PM Tom Lane wrote: > Floris Van Nee writes: > > This is as far as I can see the same case as what I reported a few years > > ago here: > > https://www.postgresql.org/message-id/flat/1574068566573.13088%40Optiver.com#488bd647ce6f5d2c92764673a7c58289 > > There was a d

Re: pg_init_privs corruption.

2023-04-11 Thread Greg Stark
On Fri, 17 Feb 2023 at 15:38, Tom Lane wrote: > > Hmm, so Stephen was opining that the extension's objects shouldn't > have gotten these privs attached in the first place. I'm not > quite convinced about that one way or the other, but if you buy it > then maybe this situation is unreachable once

Re: pg_init_privs corruption.

2023-02-20 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Floris Van Nee writes: > > This is as far as I can see the same case as what I reported a few years > > ago here: > > https://www.postgresql.org/message-id/flat/1574068566573.13088%40Optiver.com#488bd647ce6f5d2c92764673a7c58289 > > There was a

Re: pg_init_privs corruption.

2023-02-17 Thread Tom Lane
Floris Van Nee writes: > This is as far as I can see the same case as what I reported a few years ago > here: > https://www.postgresql.org/message-id/flat/1574068566573.13088%40Optiver.com#488bd647ce6f5d2c92764673a7c58289 > There was a discussion with some options, but no fix back then. Hmm, s

RE: pg_init_privs corruption.

2023-02-17 Thread Floris Van Nee
> Kirill Reshke writes: > > As you can see, after drop role there is invalid records in > > pg_init_privs system relation. After this, pg_dump generate sql > > statements, some of which are based on content of pg_init_privs, resulting > in invalid dump. > This is as far as I can see the same cas

Re: pg_init_privs corruption.

2023-02-17 Thread Tom Lane
Kirill Reshke writes: > As you can see, after drop role there is invalid records in pg_init_privs > system relation. After this, pg_dump generate sql statements, some of which > are based on content of pg_init_privs, resulting in invalid dump. Ugh. > PFA fix. I don't think this is anywhere near

pg_init_privs corruption.

2023-02-17 Thread Kirill Reshke
Hi hackers! Recently we faced a problem with one of our production clusters. Problem was with pg_upgrade, the reason was an invalid pg_dump of cluster schema. in pg_dump sql there was strange records like REVOKE SELECT,INSERT,DELETE,UPDATE ON TABLE *relation* FROM "144841"; but there is no role