Re: pg_dump bug for extension owned tables

Andrew Dunstan writes: > It looks like you've since discovered the cause here. Do you need me to > dig more? Nah, I've got it. Thanks. regards, tom lane

Re: pg_dump bug for extension owned tables

On 10/6/20 5:19 PM, Tom Lane wrote: > Andrew Dunstan writes: >> Thanks, Committed. Further investigation shows this was introduced in >> release 12, so that's how far back I went. > Still further investigation shows that this patch caused bug #16655 [1]. > It should *not* have been designed to u

Re: pg_dump bug for extension owned tables

Andrew Dunstan writes: > Thanks, Committed. Further investigation shows this was introduced in > release 12, so that's how far back I went. Still further investigation shows that this patch caused bug #16655 [1]. It should *not* have been designed to unconditionally clear the table's "interesting

Re: pg_dump bug for extension owned tables

On Fri, Sep 4, 2020 at 3:00 PM Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > Thanks, Committed. Further investigation shows this was introduced in > release 12, so that's how far back I went. > Thanks! -- Fabrízio de Royes Mello Timbira - http://www.timbira.com.br/ P

Re: pg_dump bug for extension owned tables

On Thu, Aug 6, 2020 at 4:12 PM Fabrízio de Royes Mello wrote: > > > On Mon, Jul 13, 2020 at 6:18 PM Fabrízio de Royes Mello > wrote: >> >> >> On Mon, Jul 13, 2020 at 5:05 PM Andrew Dunstan >> wrote: >> > >> > >> > On 7/13/20 2:46 PM, Fabrízio de Royes Mello wrote: >> > > >> > > >> > > > >> > >

Re: pg_dump bug for extension owned tables

On Mon, Jul 13, 2020 at 6:18 PM Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > On Mon, Jul 13, 2020 at 5:05 PM Andrew Dunstan < > andrew.duns...@2ndquadrant.com> wrote: > > > > > > On 7/13/20 2:46 PM, Fabrízio de Royes Mello wrote: > > > > > > > > > > > > > > yeah, that's the fix I

Re: pg_dump bug for extension owned tables

On Mon, Jul 13, 2020 at 5:05 PM Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > On 7/13/20 2:46 PM, Fabrízio de Royes Mello wrote: > > > > > > > > > > yeah, that's the fix I came up with too. The only thing I added was > > > "Assert(tbinfo->attgenerated);" at about line 2097. > > > >

Re: pg_dump bug for extension owned tables

On 7/13/20 2:46 PM, Fabrízio de Royes Mello wrote: > > > > > > yeah, that's the fix I came up with too. The only thing I added was > > "Assert(tbinfo->attgenerated);" at about line 2097. > > > > Cool. > > > > > Will wait for your TAP tests. > > > > Actually I've sent it already but it seems to ha

Re: pg_dump bug for extension owned tables

On Mon, Jul 13, 2020 at 3:29 PM Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > On 7/13/20 10:52 AM, Fabrízio de Royes Mello wrote: > > > > On Sat, Jul 11, 2020 at 8:07 PM Andrew Dunstan > > > > wrote: > > > > > > > > > On 6/26/20 2:10 PM, Fabrí

Re: pg_dump bug for extension owned tables

On 7/13/20 10:52 AM, Fabrízio de Royes Mello wrote: > > On Sat, Jul 11, 2020 at 8:07 PM Andrew Dunstan > > wrote: > > > > > > On 6/26/20 2:10 PM, Fabrízio de Royes Mello wrote: > > > > > > On Fri, Jun 26, 2020 at 11:55 AM Fabrízio de Royes Mello > > > mailt

Re: pg_dump bug for extension owned tables

On Mon, Jul 13, 2020 at 11:52 AM Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > On Sat, Jul 11, 2020 at 8:07 PM Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > > > > On 6/26/20 2:10 PM, Fabrízio de Royes Mello wrote: > > > > > > On Fri, Jun 26, 2020 at 11:55 AM Fabríz

Re: pg_dump bug for extension owned tables

On Sat, Jul 11, 2020 at 8:07 PM Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > On 6/26/20 2:10 PM, Fabrízio de Royes Mello wrote: > > > > On Fri, Jun 26, 2020 at 11:55 AM Fabrízio de Royes Mello > > mailto:fabriziome...@gmail.com>> wrote: > > > > > > > > > On Fri, Jun 26, 2020 at 11:

Re: pg_dump bug for extension owned tables

On 6/26/20 2:10 PM, Fabrízio de Royes Mello wrote: > > On Fri, Jun 26, 2020 at 11:55 AM Fabrízio de Royes Mello > mailto:fabriziome...@gmail.com>> wrote: > > > > > > On Fri, Jun 26, 2020 at 11:24 AM Andrew Dunstan > > wrote: > > > > > > > > > On 6/26/20 9:5

Re: pg_dump bug for extension owned tables

On 6/26/20 2:10 PM, Fabrízio de Royes Mello wrote: > > On Fri, Jun 26, 2020 at 11:55 AM Fabrízio de Royes Mello > mailto:fabriziome...@gmail.com>> wrote: > > > > > > On Fri, Jun 26, 2020 at 11:24 AM Andrew Dunstan > > wrote: > > > > > > > > > On 6/26/20 9:5

Re: pg_dump bug for extension owned tables

On Fri, Jun 26, 2020 at 11:55 AM Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > On Fri, Jun 26, 2020 at 11:24 AM Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > > > > On 6/26/20 9:57 AM, Andrew Dunstan wrote: > > > It appears that for extension owned tables tbinfo.att

Re: pg_dump bug for extension owned tables

On Fri, Jun 26, 2020 at 11:24 AM Andrew Dunstan < andrew.duns...@2ndquadrant.com> wrote: > > > On 6/26/20 9:57 AM, Andrew Dunstan wrote: > > It appears that for extension owned tables tbinfo.attgenerated isn't > > being properly populated, so line 2050 in REL_12_STABLE, which is line > > 2109 in gi

Re: pg_dump bug for extension owned tables

On 6/26/20 9:57 AM, Andrew Dunstan wrote: > It appears that for extension owned tables tbinfo.attgenerated isn't > being properly populated, so line 2050 in REL_12_STABLE, which is line > 2109 in git tip, is failing. > > Should have mentioned this is in src/bin/pg_dump/pg_dump.c cheers andre

pg_dump bug for extension owned tables

Found when working against release 12. Given the following extension: :: share/postgresql/extension/dummy--1.0.0.sql :: -- complain if script is sourced in psql, rather than via CREATE EXTENSION \echo Use "CREATE EXTENSION dummy" to load this file. \quit CREATE TABLE