On 7/13/20 10:52 AM, Fabrízio de Royes Mello wrote: > > On Sat, Jul 11, 2020 at 8:07 PM Andrew Dunstan > <andrew.duns...@2ndquadrant.com > <mailto:andrew.duns...@2ndquadrant.com>> wrote: > > > > > > On 6/26/20 2:10 PM, Fabrízio de Royes Mello wrote: > > > > > > On Fri, Jun 26, 2020 at 11:55 AM Fabrízio de Royes Mello > > > <fabriziome...@gmail.com <mailto:fabriziome...@gmail.com> > <mailto:fabriziome...@gmail.com <mailto:fabriziome...@gmail.com>>> wrote: > > > > > > > > > > > > On Fri, Jun 26, 2020 at 11:24 AM Andrew Dunstan > > > <andrew.duns...@2ndquadrant.com > <mailto:andrew.duns...@2ndquadrant.com> > > > <mailto:andrew.duns...@2ndquadrant.com > <mailto:andrew.duns...@2ndquadrant.com>>> wrote: > > > > > > > > > > > > > > > On 6/26/20 9:57 AM, Andrew Dunstan wrote: > > > > > > It appears that for extension owned tables > tbinfo.attgenerated isn't > > > > > > being properly populated, so line 2050 in REL_12_STABLE, which > > > is line > > > > > > 2109 in git tip, is failing. > > > > > > > > > > > > > > > > > > > > > > Should have mentioned this is in src/bin/pg_dump/pg_dump.c > > > > > > > > > > > > > Having a look on it. > > > > > > > > > > Seems when qualify the schemaname the the "tbinfo->interesting" field > > > is not setted for extensions objects, so the getTableAttrs can't fill > > > the attgenerated field properly. > > > > > > I'm not 100% sure it's the correct way but the attached patch works > > > for me and all tests passed. Maybe we should add more TAP tests? > > > > > > > > > > > > I just tried this patch out on master, with the test case I gave > > upthread. It's not working, still getting a segfault. > > > > Ohh really sorry about it... my bad... i completely forgot about it!!! > > Due to my rush I ended up adding the wrong patch version. Attached the > correct version. > > Will add TAP tests to src/test/modules/test_pg_dump
yeah, that's the fix I came up with too. The only thing I added was "Assert(tbinfo->attgenerated);" at about line 2097. Will wait for your TAP tests. thanks cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
