On 2024-Nov-04, Bruce Momjian wrote:
> Someone emailed me privately saying they were confused because [...]
> I think this is someone with limited English ability, which could
> explain the confusion.
I just realized you added "Reported-by: Tom Lane" to the commit message
of this change (f722dd3
On Mon, Nov 18, 2024 at 05:14:53PM -0500, Tom Lane wrote:
> Marcos Pegoraro writes:
> > But it would be good to have this patch applied to all supported versions,
> > as soon as nothing was changed on that pg_dump option, no ?
>
> Even more to the point, should we change pg_dump's help output?
>
On Tue, Nov 5, 2024 at 10:12:20AM +0100, Álvaro Herrera wrote:
> On 2024-Nov-04, Erik Wienhold wrote:
>
> > I think Bruce's suggestion is pretty clear that it does not mean line or
> > block comments, but rather the COMMENT command. But I also think that
> > "SQL" in front of the command name is
On Mon, Nov 18, 2024 at 06:36:45PM -0300, Marcos Pegoraro wrote:
> But it would be good to have this patch applied to all supported versions, as
> soon as nothing was changed on that pg_dump option, no ?
>
> Em seg., 18 de nov. de 2024 às 18:30, Bruce Momjian
> escreveu:
>
> On Tue, Nov 5,
Marcos Pegoraro writes:
> But it would be good to have this patch applied to all supported versions,
> as soon as nothing was changed on that pg_dump option, no ?
Even more to the point, should we change pg_dump's help output?
...
--load-via-partition-rootload partitions via the root table
But it would be good to have this patch applied to all supported versions,
as soon as nothing was changed on that pg_dump option, no ?
regards
Marcos
Em seg., 18 de nov. de 2024 às 18:30, Bruce Momjian
escreveu:
> On Tue, Nov 5, 2024 at 10:12:20AM +0100, Álvaro Herrera wrote:
> > On 2024-Nov-0
On Mon, 4 Nov 2024 at 21:00, Bruce Momjian wrote:
>
> On Mon, Nov 4, 2024 at 07:49:45PM +0100, Daniel Gustafsson wrote:
> > > On 4 Nov 2024, at 17:24, Erik Wienhold wrote:
> > > But I also think that
> > > "SQL" in front of the command name is unnecessary because the man page
> > > uses the "FOO
On 2024-Nov-04, Erik Wienhold wrote:
> I think Bruce's suggestion is pretty clear that it does not mean line or
> block comments, but rather the COMMENT command. But I also think that
> "SQL" in front of the command name is unnecessary [...]
+1 for "Do not dump COMMENT commands", which is what I
On 2024-11-04 21:03 +0100, Daniel Gustafsson wrote:
> > On 4 Nov 2024, at 21:00, Bruce Momjian wrote:
>
> > Proposed patch attached.
>
> LGTM.
Seconded.
--
Erik
> On 4 Nov 2024, at 21:00, Bruce Momjian wrote:
> Proposed patch attached.
LGTM.
--
Daniel Gustafsson
On Mon, Nov 4, 2024 at 07:49:45PM +0100, Daniel Gustafsson wrote:
> > On 4 Nov 2024, at 17:24, Erik Wienhold wrote:
> > But I also think that
> > "SQL" in front of the command name is unnecessary because the man page
> > uses the "FOOBAR command" form throughout
>
> Agreed.
>
> >--inserts
>
> On 4 Nov 2024, at 17:24, Erik Wienhold wrote:
>
> On 2024-11-04 16:13 +0100, Matthias van de Meent wrote:
>> On Mon, 4 Nov 2024 at 15:41, Bruce Momjian wrote:
>>>
>>> Someone emailed me privately saying they were confused because they
>>> thought pg_dump --no-comments would remove SQL comment
On 2024-11-04 16:13 +0100, Matthias van de Meent wrote:
> On Mon, 4 Nov 2024 at 15:41, Bruce Momjian wrote:
> >
> > Someone emailed me privately saying they were confused because they
> > thought pg_dump --no-comments would remove SQL comments, not the SQL
> > COMMENT commands. Is this something
On Mon, 4 Nov 2024 at 15:41, Bruce Momjian wrote:
>
> Someone emailed me privately saying they were confused because they
> thought pg_dump --no-comments would remove SQL comments, not the SQL
> COMMENT commands. Is this something worth clarifying in our docs? I am
> not even sure how I would ex
Someone emailed me privately saying they were confused because they
thought pg_dump --no-comments would remove SQL comments, not the SQL
COMMENT commands. Is this something worth clarifying in our docs? I am
not even sure how I would express it. It currently says:
--no-comments
15 matches
Mail list logo
