Re: minor comments issue in ResultRelInfo src/include/nodes/execnodes.h

2024-08-12 Thread David Rowley
On Mon, 12 Aug 2024 at 22:32, David Rowley wrote: > > On Mon, 12 Aug 2024 at 22:03, jian he wrote: > > I think first ri_RowIdAttNo applies to MERGE also. so the comments may > > not be correct? > > Yeah, ri_RowIdAttNo is used for MERGE. We should fix that comment. > > > Other files comments are f

Re: minor comments issue in ResultRelInfo src/include/nodes/execnodes.h

2024-08-12 Thread David Rowley
On Mon, 12 Aug 2024 at 22:03, jian he wrote: > AttrNumberri_RowIdAttNo; > > /* arrays of stored generated columns expr states, for INSERT and UPDATE > */ > ExprState **ri_GeneratedExprsI; > ExprState **ri_GeneratedExprsU; > } > for the struct ResultRelInfo, i've checked the ab

minor comments issue in ResultRelInfo src/include/nodes/execnodes.h

2024-08-12 Thread jian he
hi. { /* * For UPDATE/DELETE result relations, the attribute number of the row * identity junk attribute in the source plan's output tuples */ AttrNumberri_RowIdAttNo; /* Projection to generate new tuple in an INSERT/UPDATE */ ProjectionInfo *ri_projectNew;