On Mon, 12 Aug 2024 at 22:32, David Rowley <dgrowle...@gmail.com> wrote: > > On Mon, 12 Aug 2024 at 22:03, jian he <jian.universal...@gmail.com> wrote: > > I think first ri_RowIdAttNo applies to MERGE also. so the comments may > > not be correct? > > Yeah, ri_RowIdAttNo is used for MERGE. We should fix that comment. > > > Other files comments are fine. > > I'd say ri_GeneratedExprsI and ri_GeneratedExprsU are also used for > MERGE and the comment for those is also outdated. See:
I've pushed a patch to fix these. Thanks for the report. David
