Hi,
Thanks for the review!
On 10/1/22 14:12, Peter Eisentraut wrote:
This patch could use some more in-code comments. For example, this
+# get prefix for kerberos executables and try to find them at this path
+sub test_krb5_paths
is not helpful. What does it "get", where does it put it, how
On 27.09.22 17:35, Nazir Bilal Yavuz wrote:
I updated my patch regarding these reviews.
The current logic is it will try to find all executables in that
order(if it finds all executables, it won't try remaining steps):
1 - 'krb5-config --prefix'
2 - hardcoded paths(I added arm and MacPorts
Stephen Frost writes:
> * Peter Eisentraut (peter.eisentr...@enterprisedb.com) wrote:
>> Homebrew intentionally does not install the krb5 and openldap packages into
>> the path, because they conflict with macOS-provided software. However, those
>> macOS-provided variants don't provide all the piec
Greetings,
* Peter Eisentraut (peter.eisentr...@enterprisedb.com) wrote:
> On 27.09.22 03:37, Andres Freund wrote:
> > Maybe we should rely on PATH, rather than hardcoding OS dependent locations?
> > Or at least fall back to seach binaries in PATH? Seems pretty odd to
> > hardcode
> > all these l
Hi,
Thanks for the reviews!
On 9/27/2022 5:21 AM, Tom Lane wrote:
Andres Freund writes:
Maybe we should rely on PATH, rather than hardcoding OS dependent locations?
My suggestion to consult krb5-config first was meant to allow PATH
to influence the results. However, if that doesn't work, i
On 27.09.22 03:37, Andres Freund wrote:
Maybe we should rely on PATH, rather than hardcoding OS dependent locations?
Or at least fall back to seach binaries in PATH? Seems pretty odd to hardcode
all these locations without a way to influence it from outside the test.
Homebrew intentionally does
Andres Freund writes:
> Maybe we should rely on PATH, rather than hardcoding OS dependent locations?
My suggestion to consult krb5-config first was meant to allow PATH
to influence the results. However, if that doesn't work, it's important
IMO to have a sane list of hardwired places to look in.
Hi,
On 2022-09-27 10:25:07 +0900, Michael Paquier wrote:
> On Mon, Sep 26, 2022 at 04:39:36PM +0200, Peter Eisentraut wrote:
> > On 26.09.22 13:14, Tom Lane wrote:
> >> Bilal Yavuz writes:
> >> > It seems that kerberos is installed at the '/opt/homebrew/opt/krb5' path
> >> > on
> >> > ARM CPU da
On 09/26/2022 8:25 pm, Michael Paquier wrote:
On Mon, Sep 26, 2022 at 04:39:36PM +0200, Peter Eisentraut wrote:
On 26.09.22 13:14, Tom Lane wrote:
Bilal Yavuz writes:
> It seems that kerberos is installed at the '/opt/homebrew/opt/krb5' path on
> ARM CPU darwin instances instead of the '/usr/l
On Mon, Sep 26, 2022 at 04:39:36PM +0200, Peter Eisentraut wrote:
> On 26.09.22 13:14, Tom Lane wrote:
>> Bilal Yavuz writes:
>> > It seems that kerberos is installed at the '/opt/homebrew/opt/krb5' path on
>> > ARM CPU darwin instances instead of the '/usr/local/opt/krb5' path.
>> I think this al
Larry Rosenman writes:
> On 09/26/2022 11:39 am, Nazir Bilal Yavuz wrote:
>> When "krb5-config" binary is used from brew or MacPorts installations'
>> path it gives the correct path but there is another "krb5-config"
>> binary at "/usr/bin/krb5-config" path on the macOS VMs, when this
>> binary
On 09/26/2022 11:39 am, Nazir Bilal Yavuz wrote:
Hi,
On 9/26/2022 2:14 PM, Tom Lane wrote:
Maybe we should first try "krb5-config --prefix" to see if that gives
an answer.
I tested that command on multiple OSes and it was correct for freeBSD,
debian and openSUSE.
I don't have macOS so
Hi,
On 9/26/2022 2:14 PM, Tom Lane wrote:
Maybe we should first try "krb5-config --prefix" to see if that gives an answer.
I tested that command on multiple OSes and it was correct for freeBSD,
debian and openSUSE.
I don't have macOS so I tried to use CI for running macOS VMs(both arm
a
On 26.09.22 13:14, Tom Lane wrote:
Bilal Yavuz writes:
It seems that kerberos is installed at the '/opt/homebrew/opt/krb5' path on
ARM CPU darwin instances instead of the '/usr/local/opt/krb5' path.
I think this also needs to account for MacPorts, which would likely
put it under /opt/local/sbi
Bilal Yavuz writes:
> It seems that kerberos is installed at the '/opt/homebrew/opt/krb5' path on
> ARM CPU darwin instances instead of the '/usr/local/opt/krb5' path.
I think this also needs to account for MacPorts, which would likely
put it under /opt/local/sbin. (I wonder where /usr/local/opt
Hi hackers,
I wanted to add ARM CPU darwin to the CI but it seems
that kerberos/001_auth fails on ARM CPU darwin.
OS:
Darwin admins-Virtual-Machine.local 21.6.0 Darwin Kernel Version 21.6.0:
Wed Aug 10 14:26:07 PDT 2022; root:xnu-8020.141.5~2/RELEASE_ARM64_VMAPPLE
arm64
Error message:
Can't exec
16 matches
Mail list logo
