On Fri, Jan 31, 2025 at 09:32:42PM -0500, Tom Lane wrote:
> Sure, fine by me.
This one has been done as d61b9662b09e.
--
Michael
signature.asc
Description: PGP signature
Michael Paquier writes:
> FWIW, I'd choose for keeping things simpler and just remove the word
> "output", keeping this list as all the possible values. Hence, the
> patch is OK here:
> -gettext_noop("Start a subprocess to capture stderr output and/or csvlogs
> into log files."),
> +gett
On Fri, Jan 31, 2025 at 10:19:29AM -0500, Tom Lane wrote:
> FWIW, it seems weird to me to use the word "output" with only one
> of those terms. The proposed new wording is fine by me, or we
> could do
>
> "Start a subprocess to capture stderr, csvlog and/or jsonlog output
> into log files."
>
>
Umar Hayat writes:
> On Fri, 31 Jan 2025 at 20:41, Ashutosh Bapat
> wrote:
>> - gettext_noop("Start a subprocess to capture stderr output and/or
>> csvlogs into log files."),
>> + gettext_noop("Start a subprocess to capture stderr, csvlog and/or
>> jsonlog into log files."),
>>
>> Did you remove
On Fri, 31 Jan 2025 at 20:41, Ashutosh Bapat
wrote:
>
> On Fri, Jan 31, 2025 at 2:43 PM Michael Paquier wrote:
> >
> > On Fri, Jan 31, 2025 at 06:09:48PM +0900, Umar Hayat wrote:
> > > Enabling logging_collector is required for json log. During jsonlog
> > > implementation [1], log destination an
On Fri, Jan 31, 2025 at 2:43 PM Michael Paquier wrote:
>
> On Fri, Jan 31, 2025 at 06:09:48PM +0900, Umar Hayat wrote:
> > Enabling logging_collector is required for json log. During jsonlog
> > implementation [1], log destination and logging_collector comments in
> > postgresql.conf.sample and do
On Fri, Jan 31, 2025 at 06:09:48PM +0900, Umar Hayat wrote:
> Enabling logging_collector is required for json log. During jsonlog
> implementation [1], log destination and logging_collector comments in
> postgresql.conf.sample and documentation was updated but
> logging_collector short description
Hi Hackers,
Enabling logging_collector is required for json log. During jsonlog
implementation [1], log destination and logging_collector comments in
postgresql.conf.sample and documentation was updated but
logging_collector short description was not updated in guc.c (which is
guc_table.c now).
Att
