Umar Hayat <postgresql.wiz...@gmail.com> writes:
> On Fri, 31 Jan 2025 at 20:41, Ashutosh Bapat
> <ashutosh.bapat....@gmail.com> wrote:
>> - gettext_noop("Start a subprocess to capture stderr output and/or
>> csvlogs into log files."),
>> + gettext_noop("Start a subprocess to capture stderr, csvlog and/or
>> jsonlog into log files."),
>>
>> Did you remove the word "output" intentionally? It is related to
>> stderr and not jsonlog. I think, stderr usually refers to a file or a
>> file descriptor hence we added word "output" there. I wouldn't touch
>> it.
> Yes, It was omitted intentionally to match the wording in
> postgresql.conf.sample and documentation of logging_collector.
FWIW, it seems weird to me to use the word "output" with only one
of those terms. The proposed new wording is fine by me, or we
could do
"Start a subprocess to capture stderr, csvlog and/or jsonlog output
into log files."
I read that as 'stderr, csvlog and/or jsonlog' all being modifiers
for 'output', which is sensible grammar.
regards, tom lane
