On 22.01.24 01:33, John Naylor wrote:
On Fri, Jan 19, 2024 at 9:03 PM Peter Eisentraut wrote:
The DECLARE_* macros map to actual BKI commands ("declare toast",
"declare index"). So I wanted to use a different verb to distinguish
"generate code for this" from those BKI commands.
That makes s
On Fri, Jan 19, 2024 at 9:03 PM Peter Eisentraut wrote:
>
> The DECLARE_* macros map to actual BKI commands ("declare toast",
> "declare index"). So I wanted to use a different verb to distinguish
> "generate code for this" from those BKI commands.
That makes sense to me.
On 19.01.24 06:28, John Naylor wrote:
On Wed, Jan 17, 2024 at 7:46 PM Peter Eisentraut wrote:
I updated the patch to use this style (but I swapped the first two
arguments from my example, so that the thing being created is named first).
I also changed the names of the output files a bit to ma
On Wed, Jan 17, 2024 at 7:46 PM Peter Eisentraut wrote:
>
> I updated the patch to use this style (but I swapped the first two
> arguments from my example, so that the thing being created is named first).
>
> I also changed the names of the output files a bit to make them less
> confusing. (I ini
On 10.01.24 09:00, John Naylor wrote:
I suppose a sensible alternative could be to leave the
DECLARE_..._INDEX... alone and make a separate statement, like
MAKE_SYSCACHE(pg_type_oid_index, TYPEOID, 64);
That's at least visually easier, because some of those
DECLARE_... lines are getting pretty
On Thu, Nov 2, 2023 at 4:13 AM Peter Eisentraut wrote:
>
> Here is a rebased patch set, along with a summary of the questions I
> have about these patches:
This is an excellent summary of the issues, thanks.
> v4-0001-Generate-syscache-info-from-catalog-files.patch
>
> What's a good syntax to de
Here is a rebased patch set, along with a summary of the questions I
have about these patches:
v4-0001-Generate-syscache-info-from-catalog-files.patch
What's a good syntax to declare a syscache? Currently, I have, for example
-DECLARE_UNIQUE_INDEX_PKEY(pg_type_oid_index, 2703, TypeOidIndexId
On Thu, Aug 31, 2023 at 6:23 PM Peter Eisentraut
wrote:
> Attached is an updated patch set.
> There was some discussion about whether the catalog files are the right
> place to keep syscache information. Personally, I would find that more
> convenient. (Note that we also recently moved the def
I wrote:
> + # XXX This one neither, but if I add it to @skip, PerfectHash will
fail. (???)
> + #FIXME: AttributeRelationId
>
> I took a quick look at this, and attached is the least invasive way to
get it working for now, which is to bump the table size slightly. The
comment says doing this isn't
On Thu, Aug 31, 2023 at 6:23 PM Peter Eisentraut
wrote:
> Attached is an updated patch set.
>
> One win here is that the ObjectProperty lookup now uses a hash function
> instead of a linear search. So hopefully the performance is better (to
> be confirmed) and it could now be used for things lik
I have committed 0002 and 0003, and also a small bug fix in the
ObjectProperty entry for "transforms".
I have also gotten the automatic generation of the ObjectProperty lookup
table working (with some warts).
Attached is an updated patch set.
One win here is that the ObjectProperty lookup no
On 03.07.23 07:45, Peter Eisentraut wrote:
Here is an updated patch set that adjusts for the recently introduced
named captures. I will address the other issues later. I think the
first few patches in the series can be considered nonetheless.
I have committed the 0001 patch, which was really
On Wed, May 31, 2023 at 4:58 AM Peter Eisentraut
wrote:
>
> I want to report on my on-the-plane-to-PGCon project.
>
> The idea was mentioned in [0]. genbki.pl already knows everything about
> system catalog indexes. If we add a "please also make a syscache for
> this one" flag to the catalog met
On 31.05.23 13:02, Dagfinn Ilmari Mannsåker wrote:
For other patterns without the optional bits in the keyword, it becomes
even simpler, e.g.
if (/^DECLARE_TOAST\(\s*
(?\w+),\s*
(?\d+),\s*
(?\d+)\s*
Peter Eisentraut writes:
> The idea was mentioned in [0]. genbki.pl already knows everything about
> system catalog indexes. If we add a "please also make a syscache for
> this one" flag to the catalog metadata, we can have genbki.pl produce
> the tables in syscache.c and syscache.h automatica
15 matches
Mail list logo
