On 31.05.23 13:02, Dagfinn Ilmari Mannsåker wrote:
For other patterns without the optional bits in the keyword, it becomes even simpler, e.g.if (/^DECLARE_TOAST\(\s* (?<parent_table>\w+),\s* (?<toast_oid>\d+),\s* (?<toast_index_oid>\d+)\s* \)/x ) { push @{ $catalog{toasting} }, {%+}; } I'd be happy to submit a patch to do this for all the ParseHeader() regexes (in a separate thread) if others agree this is an improvement.
I would welcome such a patch.