Re: gcc 12.1.0 warning

2024-07-15 Thread Andres Freund
On 2024-07-15 12:14:47 -0500, Nathan Bossart wrote: > On Mon, Jul 15, 2024 at 09:41:55AM -0700, Andres Freund wrote: > > On 2024-05-10 12:13:21 +0300, Nazir Bilal Yavuz wrote: > >> The fix is attached. It cleanly applies from REL_15_STABLE to > >> REL_12_STABLE, fixes the warnings and the tests pas

Re: gcc 12.1.0 warning

2024-07-15 Thread Nathan Bossart
On Mon, Jul 15, 2024 at 09:41:55AM -0700, Andres Freund wrote: > On 2024-05-10 12:13:21 +0300, Nazir Bilal Yavuz wrote: >> The fix is attached. It cleanly applies from REL_15_STABLE to >> REL_12_STABLE, fixes the warnings and the tests pass. > > Thanks! I've applied it to all branches - while it's

Re: gcc 12.1.0 warning

2024-07-15 Thread Andres Freund
Hi, On 2024-05-10 12:13:21 +0300, Nazir Bilal Yavuz wrote: > On Tue, 23 Apr 2024 at 19:59, Andres Freund wrote: > > > > > > Which seems entirely legitimate. ISTM that guc_var_compare() ought to only > > cast the pointers to the key type, i.e. char *. And incidentally that does > > prevent the wa

Re: gcc 12.1.0 warning

2024-05-10 Thread Nazir Bilal Yavuz
Hi, On Tue, 23 Apr 2024 at 19:59, Andres Freund wrote: > > > Which seems entirely legitimate. ISTM that guc_var_compare() ought to only > cast the pointers to the key type, i.e. char *. And incidentally that does > prevent the warning. > > The reason it doesn't happen in newer versions of postgr

Re: gcc 12.1.0 warning

2024-04-23 Thread Andres Freund
Hi, On 2024-04-15 11:25:05 +0300, Nazir Bilal Yavuz wrote: > I am able to reproduce this. I regenerated the debian bookworm image > and ran CI on REL_15_STABLE with this image. > > CI Run: https://cirrus-ci.com/task/4978799442395136 Hm, not sure why I wasn't able to repro - now I can. It actual

Re: gcc 12.1.0 warning

2024-04-15 Thread Nazir Bilal Yavuz
Hi, On Sat, 13 Apr 2024 at 05:25, Andres Freund wrote: > > Hi, > > On 2023-10-27 13:09:01 +0300, Nazir Bilal Yavuz wrote: > > I was testing 'upgrading CI Debian images to bookworm'. I tested the > > bookworm on REL_15, REL_16 and upstream. REL_16 and upstream finished > > successfully but the Com

Re: gcc 12.1.0 warning

2024-04-12 Thread Andres Freund
Hi, On 2023-10-27 13:09:01 +0300, Nazir Bilal Yavuz wrote: > I was testing 'upgrading CI Debian images to bookworm'. I tested the > bookworm on REL_15, REL_16 and upstream. REL_16 and upstream finished > successfully but the CompilerWarnings task failed on REL_15 with the > same error. Is that st

Re: gcc 12.1.0 warning

2023-10-27 Thread Nazir Bilal Yavuz
Hi, On Fri, 27 Oct 2023 at 12:34, Erik Rijkers wrote: > > Hi, > > Not sure if these compiler-mutterings are worth reporting but I guess > we're trying to get a silent compile. > > System: Debian 4.9.303-1 (2022-03-07) x86_64 GNU/Linux > Compiling with gcc 12.1.0 causes the below 'warning' and 'no

Re: gcc 12.1.0 warning

2022-05-06 Thread Tom Lane
Erik Rijkers writes: > Not sure if these compiler-mutterings are worth reporting but I guess > we're trying to get a silent compile. > System: Debian 4.9.303-1 (2022-03-07) x86_64 GNU/Linux > Compiling with gcc 12.1.0 causes the below 'warning' and 'note'. > Compiling with --enable-cassert --ena

gcc 12.1.0 warning

2022-05-06 Thread Erik Rijkers
Hi, Not sure if these compiler-mutterings are worth reporting but I guess we're trying to get a silent compile. System: Debian 4.9.303-1 (2022-03-07) x86_64 GNU/Linux Compiling with gcc 12.1.0 causes the below 'warning' and 'note'. Compiling with --enable-cassert --enable-debug is silent, no