Hi, On 2024-05-10 12:13:21 +0300, Nazir Bilal Yavuz wrote: > On Tue, 23 Apr 2024 at 19:59, Andres Freund <and...@anarazel.de> wrote: > > > > > > Which seems entirely legitimate. ISTM that guc_var_compare() ought to only > > cast the pointers to the key type, i.e. char *. And incidentally that does > > prevent the warning. > > > > The reason it doesn't happen in newer versions of postgres is that we aren't > > using guc_var_compare() in the relevant places anymore... > > The fix is attached. It cleanly applies from REL_15_STABLE to > REL_12_STABLE, fixes the warnings and the tests pass.
Thanks! I've applied it to all branches - while it's not required to avoid a warning in newer versions, it's still not correct as it was... Greetings, Andres
