On Sat, Dec 28, 2024 at 03:25:46PM +0800, Junwang Zhao wrote:
> I believe some redundant wording has been committed.
>
> K may be chosen may be chosen at ANALYZE time.
>
> Attached patch fixes it and with some line adjustments.
Indeed. Fixed, thanks!
--
Michael
signature.asc
Description: PGP
On Tue, Oct 31, 2023 at 11:02 PM Bruce Momjian wrote:
>
> On Mon, Aug 1, 2022 at 09:05:45PM +0900, torikoshia wrote:
> > On 2022-07-30 02:53, Alvaro Herrera wrote:
> >
> > > I don't think this refers to the statistics collector process; I
> > > understand it to refer to ANALYZE that captures the
On Thu, Jul 11, 2024 at 4:35 PM cca5507 wrote:
>
> Thank you for review!
>
> The commitfest link for tracking:
> https://commitfest.postgresql.org/49/5121/
>
I've pushed and closed the CF entry.
--
With Regards,
Amit Kapila.
Thank you for review!
The commitfest link for tracking:
https://commitfest.postgresql.org/49/5121/
--
Regards,
ChangAo Chen
On Thu, Jul 11, 2024 at 12:46 PM cca5507 wrote:
>
> - /* use Oid as relation identifier */
> + /* use Oid as type identifier */
> pq_sendint32(out, typoid);
>
> I think it must be "type identifier" rather than "relation identifier".
>
LGTM.
--
With Regards,
Amit Kapila.
Hi,
- /* use Oid as relation identifier */
+ /* use Oid as type identifier */
pq_sendint32(out, typoid);
I think it must be "type identifier" rather than "relation identifier".
--
Regards,
ChangAo Chen
0001-Fix-a-comment-error-in-logicalrep_write_t
On 2024-Jul-04, Yugo NAGATA wrote:
> On Thu, 4 Jul 2024 11:06:03 +0200
> Jelte Fennema-Nio wrote:
>
> > On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA wrote:
> > > Attached is a small patch to fix a comment on PQcancelErrorMessage.
> >
> > Oops, copy paste mis
On Thu, 4 Jul 2024 11:06:03 +0200
Jelte Fennema-Nio wrote:
> On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA wrote:
> > Attached is a small patch to fix a comment on PQcancelErrorMessage.
>
> Oops, copy paste mistake on my part I guess. New comment LGTM
Thank you for your comments.
I
On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA wrote:
> Attached is a small patch to fix a comment on PQcancelErrorMessage.
Oops, copy paste mistake on my part I guess. New comment LGTM
> Hi,
>
> Attached is a small patch to fix a comment on PQcancelErrorMessage.
>
> It was accidentally "Get the socket of the cancel connection."
> I rewrote it to "Returns the error message most recently generated
> by an operation on the cancel connection
Hi,
Attached is a small patch to fix a comment on PQcancelErrorMessage.
It was accidentally "Get the socket of the cancel connection."
I rewrote it to "Returns the error message most recently generated
by an operation on the cancel connection."
Regards,
Yugo Nagata
--
Yug
On Mon, Dec 18, 2023 at 11:28:46AM +0530, Bharath Rupireddy wrote:
> Reworded the comment a bit and attached the v2 patch.
Forgot about this one, thanks! I've simplified it a bit and applied
it.
--
Michael
signature.asc
Description: PGP signature
e dependency with
> archive_library and the module's GUC is right.
Reworded the comment a bit and attached the v2 patch.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
v2-0001-Fix-a-comment-in-basic_archive-about-NO_INSTALLCH.patch
Description: Binary data
On Mon, Aug 1, 2022 at 09:05:45PM +0900, torikoshia wrote:
> On 2022-07-30 02:53, Alvaro Herrera wrote:
>
> > I don't think this refers to the statistics collector process; I
> > understand it to refer to ANALYZE that captures the data being stored.
>
> Thanks for the explanation!
>
> > Maybe i
On Fri, 4 Aug 2023 at 18:48, Richard Guo wrote:
> As stated in [1], there is a typo in the comment in
> paraminfo_get_equal_hashops.
> [1]
> https://www.postgresql.org/message-id/cambws49dehrpe8pom_k39r2uosaozcg+y0b5a8tf7vw3uvr...@mail.gmail.com
Thanks. Pushed.
David
lateral Var 't1.a' comes from the lateral subquery.
So attach a trivial patch to fix that.
[1]
https://www.postgresql.org/message-id/cambws49dehrpe8pom_k39r2uosaozcg+y0b5a8tf7vw3uvr...@mail.gmail.com
Thanks
Richard
v1-0001-Fix-a-comment-in-paraminfo_get_equal_hashops.patch
Description: Binary data
On Thu, Apr 6, 2023 at 9:26 AM Michael Paquier wrote:
>
> On Mon, Apr 03, 2023 at 08:56:10AM +0530, Bharath Rupireddy wrote:
> > It looks like comments in make file and meson file about not running
> > basic_archive tests in NO_INSTALLCHECK mode are wrong. The comments say the
> > module needs to
On Mon, Apr 03, 2023 at 08:56:10AM +0530, Bharath Rupireddy wrote:
> It looks like comments in make file and meson file about not running
> basic_archive tests in NO_INSTALLCHECK mode are wrong. The comments say the
> module needs to be loaded via shared_preload_libraries=basic_archive, but
> it ac
te: Sat, 1 Apr 2023 08:31:52 +
Subject: [PATCH v1] Fix a comment in basic_archive about NO_INSTALLCHECK
---
contrib/basic_archive/Makefile| 5 +++--
contrib/basic_archive/meson.build | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/contrib/basic_archive/Makefile
On Fri, Aug 19, 2022 at 05:40:40PM +0530, Bharath Rupireddy wrote:
> WalSnd structure mutex is being used to protect all the variables of
> that structure, not just 'variables shown above' [1]. A tiny patch
> attached to fix the comment.
Yep, walsender.c tells the same story, aka that replyTime an
2:51 +
Subject: [PATCH v1] Fix a comment in WalSnd structure
WalSnd structure mutex is being used to protect all the variables
of that structure, not just 'variables shown above'. Correct the
comment.
---
src/include/replication/walsender_private.h | 2 +-
1 file changed, 1 inse
On 2022-07-30 02:53, Alvaro Herrera wrote:
I don't think this refers to the statistics collector process; I
understand it to refer to ANALYZE that captures the data being stored.
Thanks for the explanation!
Maybe it should just say "K may be chosen at ANALYZE time".
It seems clearer than c
On 2022-Jul-29, torikoshia wrote:
> Statistics collector has been removed since 5891c7a8ed8f2d3d5, but there was
> a comment referring 'statistics collector' in pg_statistic.h.
>
> > Note that since the arrays are variable-size, K may be chosen by the
> > statistics collector.
>
> Should it be
Hi,
Statistics collector has been removed since 5891c7a8ed8f2d3d5, but there
was a comment referring 'statistics collector' in pg_statistic.h.
Note that since the arrays are variable-size, K may be chosen by the
statistics collector.
Should it be modified to 'cumulative statistics system'
On Fri, Feb 18, 2022 at 1:48 PM Amit Kapila wrote:
>
> On Wed, Feb 16, 2022 at 4:56 PM Amit Kapila wrote:
> >
> > On Wed, Feb 16, 2022 at 5:57 AM Masahiko Sawada
> > wrote:
> > >
> > > While reading the code, I realized that the second sentence of the
> > > following comment in worker.c is not
On Wed, Feb 16, 2022 at 4:56 PM Amit Kapila wrote:
>
> On Wed, Feb 16, 2022 at 5:57 AM Masahiko Sawada wrote:
> >
> > While reading the code, I realized that the second sentence of the
> > following comment in worker.c is not correct:
> >
> >/*
> > * Exit if the subscription was disabled.
On Wed, Feb 16, 2022 at 5:57 AM Masahiko Sawada wrote:
>
> While reading the code, I realized that the second sentence of the
> following comment in worker.c is not correct:
>
>/*
> * Exit if the subscription was disabled. This normally should not happen
> * as the worker gets killed d
Hi,
While reading the code, I realized that the second sentence of the
following comment in worker.c is not correct:
/*
* Exit if the subscription was disabled. This normally should not happen
* as the worker gets killed during ALTER SUBSCRIPTION ... DISABLE.
*/
if (!newsub->en
On Sat, Apr 24, 2021 at 11:43 AM Michael Paquier wrote:
>
> On Fri, Apr 23, 2021 at 07:03:40AM +, wangyu...@fujitsu.com wrote:
> > Agree. Please see the v2 patch which delete the number in comment.
>
> Indeed, this set of comments became a bit obsolete after 1375422, as
> you saied upthread.
On Fri, Apr 23, 2021 at 07:03:40AM +, wangyu...@fujitsu.com wrote:
> Agree. Please see the v2 patch which delete the number in comment.
Indeed, this set of comments became a bit obsolete after 1375422, as
you saied upthread. This simplification looks fine to me, so
applied. I am in a mood fo
ack...@postgresql.org
Subject: Re: fix a comment
On Fri, Apr 23, 2021 at 12:12 PM wangyu...@fujitsu.com
wrote:
>
> Hi, Hackers:
>
> In function ExecGetTriggerResultRel, we can see comments:
>
> > /* First, search through the query result relations */ ...
> > /*
> >
On Fri, Apr 23, 2021 at 12:12 PM wangyu...@fujitsu.com
wrote:
>
> Hi, Hackers:
>
> In function ExecGetTriggerResultRel, we can see comments:
>
> > /* First, search through the query result relations */ ...
> > /*
> > * Third, search through the result relations that were created during
> > * tuple
Hi, Hackers:
In function ExecGetTriggerResultRel, we can see comments:
> /* First, search through the query result relations */ ...
> /*
> * Third, search through the result relations that were created during
> * tuple routing, if any.
> */
But the 'Second' was deleted since commit 1375422c78.
On Sun, Dec 8, 2019 at 4:32 PM Amit Kapila wrote:
>
> On Sun, Dec 8, 2019 at 1:10 PM Hadi Moshayedi wrote:
> >
> > It seems that explanation for the contents of the pid file has moved to
> > pidfile.h, but the comments in CreateLockFile() still point to miscadmin.h.
> >
> > The attached patch up
On Sun, Dec 8, 2019 at 1:10 PM Hadi Moshayedi wrote:
>
> It seems that explanation for the contents of the pid file has moved to
> pidfile.h, but the comments in CreateLockFile() still point to miscadmin.h.
>
> The attached patch updates those pointers.
>
Your patch looks correct to me on a quic
It seems that explanation for the contents of the pid file has moved to
pidfile.h, but the comments in CreateLockFile() still point to miscadmin.h.
The attached patch updates those pointers.
diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c
index 83c9514856..de554e
36 matches
Mail list logo
