On Thu, Apr 6, 2023 at 9:26 AM Michael Paquier <mich...@paquier.xyz> wrote: > > On Mon, Apr 03, 2023 at 08:56:10AM +0530, Bharath Rupireddy wrote: > > It looks like comments in make file and meson file about not running > > basic_archive tests in NO_INSTALLCHECK mode are wrong. The comments say the > > module needs to be loaded via shared_preload_libraries=basic_archive, but > > it actually doesn't. The custom file needs archive related parameters and > > wal_level=replica. Here's a patch correcting that comment. > > Saying that, updating the comments about the dependency with > archive_library and the module's GUC is right.
Reworded the comment a bit and attached the v2 patch. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
v2-0001-Fix-a-comment-in-basic_archive-about-NO_INSTALLCH.patch
Description: Binary data
